From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uRNHEg8DtmDFYAEAgWs5BA (envelope-from ) for ; Tue, 01 Jun 2021 11:51:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kB8RDQ8DtmDwFAAA1q6Kng (envelope-from ) for ; Tue, 01 Jun 2021 09:51:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D5901561B for ; Tue, 1 Jun 2021 11:51:10 +0200 (CEST) Received: from localhost ([::1]:60600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo13F-0003s0-HU for larch@yhetil.org; Tue, 01 Jun 2021 05:51:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo138-0003rq-Bn for guix-patches@gnu.org; Tue, 01 Jun 2021 05:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lo138-0007cA-4Q for guix-patches@gnu.org; Tue, 01 Jun 2021 05:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lo138-0006Pj-0q for guix-patches@gnu.org; Tue, 01 Jun 2021 05:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Jun 2021 09:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.162254102024575 (code B ref 47979); Tue, 01 Jun 2021 09:51:01 +0000 Received: (at 47979) by debbugs.gnu.org; 1 Jun 2021 09:50:20 +0000 Received: from localhost ([127.0.0.1]:35782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lo12R-0006OI-Qx for submit@debbugs.gnu.org; Tue, 01 Jun 2021 05:50:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lo12O-0006Nx-E2 for 47979@debbugs.gnu.org; Tue, 01 Jun 2021 05:50:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51340) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo12I-0006w2-RE; Tue, 01 Jun 2021 05:50:10 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=45336 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo127-0006tq-LU; Tue, 01 Jun 2021 05:50:10 -0400 From: Mathieu Othacehe References: <87lf88qm47.fsf_-_@gnu.org> Date: Tue, 01 Jun 2021 11:49:55 +0200 In-Reply-To: (Leo Famulari's message of "Fri, 21 May 2021 17:01:36 -0400") Message-ID: <87tumh6hj0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622541071; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=H+R/ePS8dcCKuJzwRs1/nbsewlV0yFnjH+7+7IsixxA=; b=iHAHuf26iyeFG09iqlNkDHFGgEk0tXVuXgrlVaYKjiiGZPmfqu66t8KeFQ973GVHr/Tvph 1q437ZFYXI+xf0+8RnWDaLwQ/+5nThItr2b9kFHTQAzKGcqLXTyu/pADjjpUOgXKHxt57+ Unn7lw4WV8xd3qKwkgx9K5Vz2ktz5z3QeOGaLLhr1y/R6kusu2YgVa7vnrsXcDSXJCH7Sk HD/num37IqTljGcMJlpGhnQGugxVVw5Iow/cPmRNVJb+UT+3Tzn6mHDfqnY4SuxawVLWVr a2fodHXrkxSyewYPJ7eR7px8Qv6d41YZJPrgsW+DMbSxvN3+fLfcAc0bNcOmeg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622541071; a=rsa-sha256; cv=none; b=TI5BVa917GoN4n1yn+J5FW5Tk/1PC+N/vT1o8IaJX7jLP5sCenEgQqmwScHgJgSzfBMqLR gERTzvqphh3gDexXJyGMBhuFhZoRAuCI2gjGY3TWbfh7feoJHXXIHKCOJrqOM8uozCd9/t x04hNrcC1jD3fa10UINaMZnM5S9KQZIeiTNRwTsYfJ7gNw13hfZwqCyQeP0Jw12dI+xPWG 6zGl8Gf8rThSEVPVCfBqYEhFiwsJ+cvjwCp5FjiLvBN+sUnJ9IRL81ZA3H2yAsUEVcrKD7 RU5/KkyZcRuNIieO6EcRnJEd6Z12ioGdRvXkokQ5fsrTgShRdYY46opG+pXC8A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8D5901561B X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: KCTWbu7bfSF8 Hey Leo, > cannot build derivation `/gnu/store/20flyxbjjl8as5aca4gzf3b54as1gr9z-ntp-4.2.8p15.drv': 1 dependencies couldn't be built The installation tests are run in a network isolated environment. This means that we need to make sure that every single derivation that will be needed during the installation is made available. It is for sure a tricky business. If you have a look to the error line I pasted above, you will see that the installer tries to build the ntp package because the ntp-service-type is now included. The following patch fixes the "gui-installed-os" test by making sure that the ntp package is available in the installation environment. I did not check for the other installation tests. --8<---------------cut here---------------start------------->8--- diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm index b5263f5f0d..e9ebc63b64 100644 --- a/gnu/tests/install.scm +++ b/gnu/tests/install.scm @@ -1608,8 +1608,9 @@ build (current-guix) and then store a couple of full system images.") (swap-devices (if encrypted? '() (list (uuid "11111111-2222-3333-4444-123456789abc")))) - (services (cons (service dhcp-client-service-type) - (operating-system-user-services %minimal-os-on-vda))))) + (services (cons* (service dhcp-client-service-type) + (service ntp-service-type) + (operating-system-user-services %minimal-os-on-vda))))) (define* (installation-target-desktop-os-for-gui-tests #:key (encrypted? #f)) --8<---------------cut here---------------end--------------->8--- Thanks, Mathieu