unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 48980@debbugs.gnu.org, Jonathan Brielmaier <jonathan.brielmaier@web.de>
Subject: [bug#48980] [PATCH 0/2] icecat, icedove: Add U2F and WebAuthn support
Date: Sat, 03 Jul 2021 13:18:59 -0400	[thread overview]
Message-ID: <87tulbgvs1.fsf@netris.org> (raw)
In-Reply-To: <87k0m7xugh.fsf_-_@waegenei.re>

Hi Brice,

Brice Waegeneire <brice@waegenei.re> writes:
> Could you take a look at this patch adding U2F support to icecat ?

Thanks for this, but I see a problem.  The new input has key "eudev":

> @@ -910,6 +911,7 @@ from forcing GEXP-PROMISE."
>         ;; UNBUNDLE-ME! ("nss" ,nss)
>         ("shared-mime-info" ,shared-mime-info)
>         ;; UNBUNDLE-ME! ("sqlite" ,sqlite)
> +       ("eudev" ,eudev)
>         ("unzip" ,unzip)
>         ("zip" ,zip)
>         ;; UNBUNDLE-ME! ("zlib" ,zlib)

but the code added to the 'wrap-program' phase looks for key "udev":

> +                    (ld-libs (map (lambda (lib)
> +                                    (string-append (assoc-ref inputs lib)
> +                                                   "/lib"))
> +                              '("libxscrnsaver"
> +                                "mesa"
> +                                "mit-krb5"
> +                                "udev"
> +                                "pulseaudio"))))

I don't see how this can work.  Did you test it?

     Regards,
       Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.




  reply	other threads:[~2021-07-03 17:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12 21:16 [bug#48980] [PATCH 0/2] icecat, icedove: Add U2F and WebAuthn support Brice Waegeneire
2021-06-12 21:19 ` [bug#48980] [PATCH 1/2] gnu: icecat: Add " Brice Waegeneire
2021-06-12 21:19 ` [bug#48980] [PATCH 2/2] gnu: icedove: " Brice Waegeneire
2021-06-12 22:09   ` Jonathan Brielmaier
2021-06-13  7:51     ` [bug#48980] [PATCH 0/2] icecat, icedove: Add U2F and " Brice Waegeneire
2021-06-20  9:32 ` [bug#48980] [PATCH v2 1/2] gnu: icecat: Add " Brice Waegeneire
2021-06-20  9:32   ` [bug#48980] [PATCH v2 2/2] gnu: icedove: " Brice Waegeneire
2021-06-23 21:09 ` [bug#48980] [PATCH 0/2] icecat, icedove: Add U2F and " Jonathan Brielmaier
2021-07-03 15:55   ` Brice Waegeneire
2021-07-03 17:18     ` Mark H Weaver [this message]
2021-07-03 20:15       ` [bug#49362] [PATCH v3] gnu: icecat: Add " Brice Waegeneire
2021-09-04  7:39         ` bug#49362: " Brice Waegeneire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tulbgvs1.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=48980@debbugs.gnu.org \
    --cc=brice@waegenei.re \
    --cc=jonathan.brielmaier@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).