From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YGtlC/QKJGEGWgAAgWs5BA (envelope-from ) for ; Mon, 23 Aug 2021 22:54:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CEXtBvQKJGHcZAAAB5/wlQ (envelope-from ) for ; Mon, 23 Aug 2021 20:54:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D19B5195F1 for ; Mon, 23 Aug 2021 22:54:11 +0200 (CEST) Received: from localhost ([::1]:34866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIGxO-0000rw-DT for larch@yhetil.org; Mon, 23 Aug 2021 16:54:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIGxG-0000ri-EX for guix-patches@gnu.org; Mon, 23 Aug 2021 16:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIGxG-0001yO-5v for guix-patches@gnu.org; Mon, 23 Aug 2021 16:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIGxG-0000UF-5P for guix-patches@gnu.org; Mon, 23 Aug 2021 16:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50076] [PATCH 1/1] gnu: Add python-flask-debugtoolbar. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Aug 2021 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50076 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: BonfaceKilz Cc: 50076@debbugs.gnu.org Received: via spool by 50076-submit@debbugs.gnu.org id=B50076.16297519961805 (code B ref 50076); Mon, 23 Aug 2021 20:54:02 +0000 Received: (at 50076) by debbugs.gnu.org; 23 Aug 2021 20:53:16 +0000 Received: from localhost ([127.0.0.1]:42693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIGwW-0000T2-9R for submit@debbugs.gnu.org; Mon, 23 Aug 2021 16:53:16 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:46304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIGwT-0000Sr-9f for 50076@debbugs.gnu.org; Mon, 23 Aug 2021 16:53:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mXYphho2bDnnX38OzDfUXDx2BuuBz71CHXRaA2oGQOI=; b=OFPxIz7b6n+iAsaHSGLU5oOYF9 7CemrZ+IT2MJHp/RV5F50e/ofVbeIboBCNCFElvvTo0PQspOGHalA9SjUKiMEuOs6ZHvpcL9Y/t9V hH29bNr7nap39b0m+StJgclINHLLLvsBNOzrroztWU9fuyBqqL/a84MTSNaFuaUpdtWt7o7XkcXh6 4XjtfKtLqfdP4pwxhufNZCs+XEcGqC5e0afZO4A/30YHD82L7Hk0U5B/AhpO768GY3vHtcWT9nBkb s2tC8kN61o02QyzgFtprPDD89D2isqWx8+nRRoUkXpUZU5kG0vEtbvsItvDdCm78fEGoI2j8dbz6n 6b7+WUig==; Received: from [192.168.2.1] (port=6842 helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mIGwP-000H0I-VM; Tue, 24 Aug 2021 02:23:10 +0530 From: Arun Isaac In-Reply-To: <20210816095059.10480-1-me@bonfacemunyoki.com> References: <20210816094722.9883-1-me@bonfacemunyoki.com> <20210816095059.10480-1-me@bonfacemunyoki.com> Date: Tue, 24 Aug 2021 02:23:03 +0530 Message-ID: <87tujfrihc.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629752051; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=mXYphho2bDnnX38OzDfUXDx2BuuBz71CHXRaA2oGQOI=; b=kL2F9H8hvhKp+PnHvMHfbn6ppFDFZ5OgqXRbsF6wjFPx6ZlbI/qOl2Xwo53mNV3A1O6eE3 BMLidmk+c5wWvdTwuQsBPmnOoIw1Lls4aahwU4ewkxmF9rf1S0McvO5Qa+mkcupcweeJZp BnX4hUAEStfrrGl5U0W+CdozmSuC5eOgcliiLXMMViVykPGquUh6fjMhFgZJHL63v1JWwk 96G1iS5Xvq0LZbkzn14mUy1d2f3r0DKdbaUAOrWiHNp4HuzIPgwvl9xkyWknS0mQuAbXLy 0ezPNfNiAFEMEsOK6dQABy+975DtGrH+I8wUDPaN8x504mCUVJUyFmqOk31N1Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629752051; a=rsa-sha256; cv=none; b=CdotduVJRptf6QDqgZaAlnI663w6QXLLUGlzTF07G8czFxDiZXGWcv+Pv2MxfNJ3R1Nwjj H69SLvSsZj/R+iqDpTKW7L32Z2AXS/MtOQDqwP0uYD+SS9DVrawi9m8j6WPE+PLLO1FbAQ GZVsxaRX7qSMiypwr84KMLI9EeMbR7+3mianGeQmkuowj14Jy0z/nxBdsRWm1xFfnkHWyK nawVUKkSGd2VKH1tVZnA1xRjM+XK2WO895NoTL7g9vy46JeJk9x3lvGCcOz29bVQEu+pBR /m/acPWq8KQRaQ6518rzCNr09y651T4Jem1ywzc7/7xuWhcSjmV887hOXpk0RQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=OFPxIz7b; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=OFPxIz7b; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D19B5195F1 X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: AXrIojkIy6P+ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Bonface, Thanks for contributing! :-) Some feedback follows. 1. Please add a copyright header. 2. Could you try packaging the tests? I think tests use pytest. Currently, no tests are run during the check phase. > + (synopsis > + "A toolbar overlay for debugging Flask applications.") 3. Could you remove the article "A" at the beginning, and the period at the end? Quoting from our manual at "(guix) Synopses and Descriptions": =2D-8<---------------cut here---------------start------------->8--- Synopses must start with a capital letter and must not end with a period. They must not start with =E2=80=9Ca=E2=80=9D or =E2=80=9Cthe=E2=80= =9D, which usually does not bring anything; for instance, prefer =E2=80=9CFile-frobbing tool=E2=80=9D o= ver =E2=80=9CA tool that frobs files=E2=80=9D. =2D-8<---------------cut here---------------end--------------->8--- > + (description > + "This extension adds a toolbar overlay to Flask applications contain= ing > +useful information for debugging.") 4. Finally, a nitpick: It would be more consistent with the rest of Guix if the synopsis and description started on the same line instead of on the next. So, something like this: =2D-8<---------------cut here---------------start------------->8--- (description "This extension adds a toolbar overlay to Flask applicatio= ns containing useful information for debugging.") =2D-8<---------------cut here---------------end--------------->8--- Thanks! Arun --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAmEkCq8bHGFydW5pc2Fh Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuz3jwIAJVxKLvog80YidrSuRl9 p3BJMrS+A6BquCZv/XYy4XGJigCir5QMDRLpM4xGJxbP9ebFlSeHPHTkx9olbLLj KluMZcmR7VN+aptpVxCr1JG5YuFbUtlNKEW7+CsEUb402Ch2KorQbin48EIpmJaK Q8uFQ7dNguqyQ3qM//23YsFtDifu+bI/Y8R862g2R/uXaZiT91FcRLOdoGZsB3W3 nSrbNOYcPk77fSc7KxI7hPeUEeaX7JarSVr8vNoiqhgRdHw9qjDiVpWfsIxhcrUM DZHw21dVeqjpGtITN0ziWX/oLTQrSxJQUeHW5dKdxT335pUyByZnIRW0gPphHElQ DGI= =O0h+ -----END PGP SIGNATURE----- --=-=-=--