From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CCpGLYfULGFGfQEAgWs5BA (envelope-from ) for ; Mon, 30 Aug 2021 14:52:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id BkGXKIfULGEvewAAbx9fmQ (envelope-from ) for ; Mon, 30 Aug 2021 12:52:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C1DEA6E8D for ; Mon, 30 Aug 2021 14:52:22 +0200 (CEST) Received: from localhost ([::1]:51594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKglx-0004TP-PN for larch@yhetil.org; Mon, 30 Aug 2021 08:52:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKgkg-0002Su-1q for guix-patches@gnu.org; Mon, 30 Aug 2021 08:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKgkf-0007OL-QE for guix-patches@gnu.org; Mon, 30 Aug 2021 08:51:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKgkf-0002fM-Nt for guix-patches@gnu.org; Mon, 30 Aug 2021 08:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49886] [PATCH v2] Add gitile and gitile service Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Aug 2021 12:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49886 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 49886@debbugs.gnu.org Received: via spool by 49886-submit@debbugs.gnu.org id=B49886.163032780510157 (code B ref 49886); Mon, 30 Aug 2021 12:51:01 +0000 Received: (at 49886) by debbugs.gnu.org; 30 Aug 2021 12:50:05 +0000 Received: from localhost ([127.0.0.1]:58418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKgjl-0002dl-Hp for submit@debbugs.gnu.org; Mon, 30 Aug 2021 08:50:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKgjk-0002ck-Ew for 49886@debbugs.gnu.org; Mon, 30 Aug 2021 08:50:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44644) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKgje-0006xL-EY; Mon, 30 Aug 2021 08:49:58 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=45100 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKgje-0008SM-5W; Mon, 30 Aug 2021 08:49:58 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210805035159.3959e01e@tachikoma.lepiller.eu> <87lf59shyi.fsf@gnu.org> <20210825233136.450d778b@tachikoma.lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Fructidor an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 30 Aug 2021 14:49:56 +0200 In-Reply-To: <20210825233136.450d778b@tachikoma.lepiller.eu> (Julien Lepiller's message of "Wed, 25 Aug 2021 23:31:36 +0200") Message-ID: <87tuj7ayh7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630327943; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=axpyllgjnm1Mfds0YoXM+/CnreJ9pawIZgklew+HX04=; b=KZzAD17RbttRvst/IxS2faiJuHQwSqyeufgiAz+6c2sveeu4TOGDfQhKBEYg4QkyfLbjlU AmmrF4bJeKgtCp9J4/EnmOF68cZGdIylWEy+MuiGews7r2KcqqXkkgMzQA0zRmxytXeZfL LLfmbUWYyJaDRSPsFs8XMTSWkjHB0izPb6NYq4p8HWFSK5KYy0aheqD8BRODQiKby6GHzH rM4F29EeVg6NAFZxo8UxyxyEk4SBn2JWtI86GXM08eORGh8T83ATF/rtTM/6nEX5i8vTK+ eEFHnvuFUaCae+Q9iQ8Yj2vcILJDoGxuRZ5/O7OCxpSfMlvpVCA1D7WwrUhqFw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630327943; a=rsa-sha256; cv=none; b=l1MFd8f29fBcQvvhrI46VTPWq1EZ69X7GCsblNqRFrNJm4wo4Q9Jl9kVyJNnUktfM2bBhA BuQfaddaTUBg3BnYSBx8f9UYCZULEGgGZgB2PMdS11z0T99gnN0KpqB3JABGhNAMk28iOS JupqYpLfZx3OgVMHS+X2UHipOzbOuFC3BAu1kkk+HETEaqsqNa0XYWCc0L6yEB9wdi58Km 2UQXsTLwqoR3GhkEQSxDpBb4WN+E4yo+VAjJA1D4SiI/uw1NR1YSR0BFcr6UITvKDVTu2S r3+sRGIpMwrmHQLFcefCvy7V6eUIlMK6jSvGCeP8YH59IG35UgQEEQfZUu+arA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C1DEA6E8D X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: K7BTfb2tc+f3 Hi Julien! Julien Lepiller skribis: > attached is a v2 of the series. I added a small change to gitolite that > allows changing UNSAFE_PATT (a regex that matches configuration values > that contain unsafe characters). I wanted to link to it and to the > nginx configuration sections in the manual, but I don't know how to > create that link? I see the @subsubheading NGINX for instance, but I > can't @ref{NGINX}. Right, you cannot cross-reference a heading; you=E2=80=99d need either a no= de or an anchor so you can cross-reference it. > I had to update gitile for the tests to pass and had a few false > starts, but now the tests pass and gitile is working even better than > before :) Yay! :-) > From d43a77241defdea7848ab4596b427c33675f050e Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Thu, 5 Aug 2021 02:57:32 +0200 > Subject: [PATCH 1/3] gnu: Add gitile. > > * gnu/packages/version-control.scm (gitile): New variable. LGTM! > From 2652e5515c84505c63072309f3b3e7837649cdb9 Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Wed, 25 Aug 2021 03:00:44 +0200 > Subject: [PATCH 2/3] gnu: gitolite: Add unsafe-patt configuration option. > > * gnu/services/version-control.scm (gitolite-rc-file): Add unsafe-patt > field. > (gitolite-rc-file-compiler): Write it. > * doc/guix.texi (Version Control Services): Document it. [...] > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -31426,6 +31426,15 @@ A value like @code{#o0027} will give read access= to the group used by Gitolite > (by default: @code{git}). This is necessary when using Gitolite with so= ftware > like cgit or gitweb. >=20=20 > +@item @code{unsafe-patt} (default: @code{#f}) I=E2=80=99d call this field =E2=80=98unsafe-pattern=E2=80=99 for clarity. > +An optional pattern for catching unsafe configurations in the configurat= ion s/pattern/Perl regular expression/ ? > +file. See > +@uref{https://gitolite.com/gitolite/git-config.html#compensating-for-uns= afe_patt, > +Gitolite's documentation} for more information. > + > +When the value is not @code{#f}, it should be a string containing a Perl > +regular expression, such as @samp{"[`~#\$\&()|;<>]"}. =E2=80=9Csuch as @samp{=E2=80=A6}, which catches XYZ.=E2=80=9D OK with changes along these lines! > From a80c856fce646eee7257239e4c05e67ac292b5fc Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Thu, 5 Aug 2021 03:46:40 +0200 > Subject: [PATCH 3/3] gnu: version-control: Add gitile service. > > * gnu/services/version-control.scm (gitile-service-type): New variable. > * doc/guix.texi (Version Control Services): Document it. > * gnu/tests/version-control.scm (%test-gitile): New variable. LGTM, thank you! Ludo=E2=80=99.