From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QCXBMyEeTmEKygAAgWs5BA (envelope-from ) for ; Fri, 24 Sep 2021 20:51:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MFhNLyEeTmFLDAAAB5/wlQ (envelope-from ) for ; Fri, 24 Sep 2021 18:51:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 66CFE11E9A for ; Fri, 24 Sep 2021 20:51:13 +0200 (CEST) Received: from localhost ([::1]:38076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTqHv-0004fT-Nd for larch@yhetil.org; Fri, 24 Sep 2021 14:51:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTqHn-0004dH-S8 for guix-patches@gnu.org; Fri, 24 Sep 2021 14:51:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTqHm-00084u-Ea for guix-patches@gnu.org; Fri, 24 Sep 2021 14:51:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTqHm-0000vh-E6 for guix-patches@gnu.org; Fri, 24 Sep 2021 14:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50756] [PATCH] gnu: Add lttng-tools. Resent-From: Olivier Dion Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Sep 2021 18:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: public@yoctocell.xyz, 50756@debbugs.gnu.org X-Debbugs-Original-To: Xinglu Chen , Olivier Dion via Guix-patches via , 50756@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16325094303480 (code B ref -1); Fri, 24 Sep 2021 18:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Sep 2021 18:50:30 +0000 Received: from localhost ([127.0.0.1]:59273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTqHF-0000tw-Jo for submit@debbugs.gnu.org; Fri, 24 Sep 2021 14:50:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:37638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTmts-0002aW-BL for submit@debbugs.gnu.org; Fri, 24 Sep 2021 11:14:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTmtr-0003aE-Ut for guix-patches@gnu.org; Fri, 24 Sep 2021 11:14:07 -0400 Received: from smtp.polymtl.ca ([132.207.4.11]:35439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTmtp-0008Li-Ko for guix-patches@gnu.org; Fri, 24 Sep 2021 11:14:07 -0400 Received: from localhost (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 18OFDimU001902 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Sep 2021 11:13:49 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 18OFDimU001902 In-Reply-To: <87mto2jbkl.fsf@yoctocell.xyz> References: <20210923124004.3164-1-olivier.dion@polymtl.ca> <87mto2jbkl.fsf@yoctocell.xyz> Date: Fri, 24 Sep 2021 11:13:44 -0400 Message-ID: <87tuia2ehj.fsf@laura> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) at Fri, 24 Sep 2021 15:13:44 +0000 Received-SPF: pass client-ip=132.207.4.11; envelope-from=olivier.dion@polymtl.ca; helo=smtp.polymtl.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 24 Sep 2021 14:50:27 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Olivier Dion X-ACL-Warn: , Olivier Dion via Guix-patches From: Olivier Dion via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632509473; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=YceaY2bqe9fxftyGj/jgxiwePZyzSXCkgW9nQU6KGiI=; b=SfipsoSIl5bHRVug0T7/aeoSjNYmGdXglqP6KrGaGTfPxVntEyDnWOx4wRhF7wH1ovDRA+ nosmbdRzYnzgzPaeIbw8X4uy5/W56ZtUM1NvLpsMMf9koNfsS68rHfMzQc8w5WWwg+16cq 0WALSDhO9Gz8e9LLBaxs8jmtEc9H44w3+mNgXKNep8SpsYB86TKnclYw5mC4jZCK/KLcDd UmeB2y0V2pft7qCRjk3jATwnlWsgvlJI2DVnABpWsPYmGOFv5AJ7ofjcaxXmT9ONl3tLyk FGH/XbX5OpW61XdmlV6caxJY/oOIfxDWIMWqE0cDvzXDemueIfOxSVAo2yL5kw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632509473; a=rsa-sha256; cv=none; b=mMAbo9ktLmmG3BHno82Fgy8PzqxX2i/2cwEu8vm8c+X10MIu2+bjGoAmbESW3JWgYJkiKz SCCfbwyN3dSx4He1GahAwfWSEUgbgvsDySd+spRzcpKpv5GREDUqsYGWEllnEkk7yWbn15 dZ9EnuHWdkgFd3ALSu0Y6xfajHb+3IOurozH1EgPbjvjw5Z3Rv9CcHx0iIAeiYKBU9LbYK AS/IcYKbwzoZ5deGSQMnI46Fmkrqls+aIX9iTPPuWm8IzDhXw5zoxfyfDb5X/99Dg4ttBP EAtTvuEKcgwgQ4b7b4UCETerXAco5neAqQVSex1hBjMlVP3C8OMsjndyeov/Cg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.39 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 66CFE11E9A X-Spam-Score: -2.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: KaGeETjrb5yq On Fri, 24 Sep 2021, Xinglu Chen wrote: > On Thu, Sep 23 2021, Olivier Dion via Guix-patches via wrote: >> +(define-public lttng-tools >> + (package >> + (name "lttng-tools") >> + (version "2.12.5") > > Version 2.13 is available; any reason for not using it? Would require to bump version of lttng-ust also I think. I prefer to do al= l of this in another patch.=20=20 >> + (arguments >> + `(#:tests? #f >> + #:parallel-tests? #f > > There is no need to set #:parallel-tests? if #:tests? is set to #f. During my testing, I noticed that test in parallel are not working because of how the lttng-daemon works. So I disable the parallel option in order to not forget it when testing will work in the future. I should probably add a comment to explain the rationale here. >> + (propagated-inputs >> + `(("libkmod" ,kmod) >> + ("modprobe" ,module-init-tools))) > > Any reason for the labels not being the same as the package? I follow the naming convention in the description of the project's README so it's easier to map the dependencies described by it to Guix's packages. I can change this, but I find it more clear that way. > >> + (native-inputs >> + `(("pkg-config" ,pkg-config) >> + ("perl" ,perl) >> + ("libpfm4" ,libpfm4) >> + ("python" ,python-3) > > While running the configure script, I get > > configure: You may configure with --enable-python-bindings if you want = Python bindings. > > So you would have to pass the =E2=80=98--enable-python-bindings=E2=80=99 = flag, and > Python would be needed during runtime as well. Does it tho? Bindings can be generated at build time. While you would require python-3 at runtime to use the bindings, you don't require python-3 to use the other tools of the project. I don't mind adding it to the inputs, I'm just asking. > Could you send an updated patch? Will do soon! --=20 Olivier Dion Polymtl