From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CDLzCZ5uX2FKCAEAgWs5BA (envelope-from ) for ; Fri, 08 Oct 2021 00:03:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aD6zBZ5uX2G0awAA1q6Kng (envelope-from ) for ; Thu, 07 Oct 2021 22:03:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A42866559 for ; Fri, 8 Oct 2021 00:03:09 +0200 (CEST) Received: from localhost ([::1]:47178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYbTm-0000BJ-Cp for larch@yhetil.org; Thu, 07 Oct 2021 18:03:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYbTi-0000B2-S8 for guix-patches@gnu.org; Thu, 07 Oct 2021 18:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYbTi-0001nl-L5 for guix-patches@gnu.org; Thu, 07 Oct 2021 18:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYbTi-0000zM-HB for guix-patches@gnu.org; Thu, 07 Oct 2021 18:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42180] bug#51061: [PATCH v2 01/23] guix: Add extracting-download. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Oct 2021 22:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42180 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 42180@debbugs.gnu.org, 51061@debbugs.gnu.org Received: via spool by 42180-submit@debbugs.gnu.org id=B42180.16336441412646 (code B ref 42180); Thu, 07 Oct 2021 22:03:02 +0000 Received: (at 42180) by debbugs.gnu.org; 7 Oct 2021 22:02:21 +0000 Received: from localhost ([127.0.0.1]:48620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYbSy-0000dR-5o for submit@debbugs.gnu.org; Thu, 07 Oct 2021 18:02:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYbSp-0000TI-3F; Thu, 07 Oct 2021 18:02:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50206) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYbSj-0000wl-J4; Thu, 07 Oct 2021 18:02:01 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36516 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYbSj-0005Ew-2O; Thu, 07 Oct 2021 18:02:01 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <626e4718c45c95a7278460f132bd38e08835e9f4.1633533541.git.h.goebel@crazy-compilers.com> <38e8edec6dab357b89821822d646708b802a665b.1633533541.git.h.goebel@crazy-compilers.com> Date: Fri, 08 Oct 2021 00:01:59 +0200 In-Reply-To: <38e8edec6dab357b89821822d646708b802a665b.1633533541.git.h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Wed, 6 Oct 2021 17:20:00 +0200") Message-ID: <87tuhs8pew.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633644189; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=sQku6/YYGSzsmMbxJTQikHEbVC8nIGXwnhuYKgCIyIM=; b=dOV7IxzsAP+sNtNN3FPEfk3CTLuFnO9/1bLbPsGIKiN4jVtKzz89NNS77Fk3+kj0KsYtbI f0Q/PSGu8dtKpWw45f3RB3vJgIeQRSz0PguNRmQ0Io+KqXa7f0VHbsRnZPouhljsUEwGE9 OtOLWlaT2PkP/qNZgZs3c0+wwT2uaRV0QWUdMMOEAzZjvA/Qv3H/g7gOlxj6l3fp8t7o6/ GWntovQuEmQnzIoehXOf3LniKNoNZ2IYKLTB31BPJu5Gu96HphtUiXB0cYkPpryFV5qk0e hiGNjbNkQJkaKXI1T5/N66I9MWwHhc0CujphObP0Wz7LrvACAuwJ7WhM7N4KrQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633644189; a=rsa-sha256; cv=none; b=kqmQ2JPXN95BV2P0zcDHN5YOY2yC4rS4aR/32x/ceGde+hnF7LQ0wgj/xch+yndI30CX+d hxz1te/67eylSjG4YFCRBI3FAV2kaHjDNIRo6YgMfWs0xsim2cnDu0YOEuH/Ax/Q5v96Fx rwwKqscURRx1l84IXFRMVabnQ66iuam50nmZq9yaA5SJ+J7HKWp6HNk3ZSCSpGN+UmFq8w j+178oj4qn5h6G6et7WVGoJblZZk4lhlBagYyktLpS1znuS7voI9utcYYVboN8aG2vtyE0 zzv1IAcPh+v9Z6BR28Er7aeSpTJD/hyNGYIFfV/1Uuz0h9v+MpMNpD/8vq/d/w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.22 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A42866559 X-Spam-Score: -2.22 X-Migadu-Scanner: scn1.migadu.com X-TUID: Vbe3trUvxZXm Hartmut Goebel skribis: > * guix/scripts/import.scm (importers): Add "hexpm". > * guix/scripts/import/hexpm.scm, guix/import/hexpm.scm, > guix/hexpm-download.scm: New files. > * guix/import/utils.scm (source-spec->object): Add "hexpm-fetch" to list = of > fetch methods. > * guix/upstream.scm (package-update/hexpm-fetch): New function. > (%method-updates) Add it. > * Makefile.am: Add them. At the very least it misses tests and documentation, like for every importer, and an entry in po/guix/POTFILES.in. The (guix hexpm-download), like extracting-download.scm, needs more attention because it=E2=80=99s a core API. Again, I=E2=80=99m in favor of reverting until it=E2=80=99s been reviewed i= n more detail. > +++ b/guix/hexpm-download.scm > @@ -0,0 +1,74 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Court=C3= =A8s > +;;; Copyright =C2=A9 2017 Mathieu Lirzin > +;;; Copyright =C2=A9 2017 Christopher Baines > +;;; Copyright =C2=A9 2020 Jakub K=C4=85dzio=C5=82ka > +;;; Copyright =C2=A9 2020 Hartmut Goebel The list of copyright holders looks bogus. > +;;; An method that fetches a package from the hex.pm repository, > +;;; unwrapping the actual content from the download tarball. It would be nice to explain in a few words what =E2=80=9Cthe hex.pm reposit= ory=E2=80=9D is (I have no idea.) > +(define* (hexpm-fetch url hash-algo hash Why another method? > +++ b/guix/import/hexpm.scm > @@ -0,0 +1,294 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2015 Cyril Roelandt > +;;; Copyright =C2=A9 2016 David Craven > +;;; Copyright =C2=A9 2017, 2019, 2020 Ludovic Court=C3=A8s > +;;; Copyright =C2=A9 2019 Martin Becze > +;;; Copyright =C2=A9 2020, 2021 Hartmut Goebel Please strip it. Thanks, Ludo=E2=80=99.