From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CC4QKEsBjmGyJAAAgWs5BA (envelope-from ) for ; Fri, 12 Nov 2021 06:53:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uAq6I0sBjmETRgAAB5/wlQ (envelope-from ) for ; Fri, 12 Nov 2021 05:53:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CB5528E77 for ; Fri, 12 Nov 2021 06:53:15 +0100 (CET) Received: from localhost ([::1]:35504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlPUw-0002w9-9p for larch@yhetil.org; Fri, 12 Nov 2021 00:53:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlPUk-0002uS-4Q for guix-patches@gnu.org; Fri, 12 Nov 2021 00:53:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlPUj-0007Fd-S5 for guix-patches@gnu.org; Fri, 12 Nov 2021 00:53:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlPUj-0001Gz-Ow for guix-patches@gnu.org; Fri, 12 Nov 2021 00:53:01 -0500 Subject: bug#50664: [PATCH core-updates-frozen] gnu: curl: Respect #:tests?. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 12 Nov 2021 05:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50664 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: othacehe@gnu.org, 50664-done@debbugs.gnu.org Mail-Followup-To: 50664@debbugs.gnu.org, maxim.cournoyer@gmail.com, iskarian@mgsn.dev Received: via spool by 50664-done@debbugs.gnu.org id=D50664.16366963714875 (code D ref 50664); Fri, 12 Nov 2021 05:53:01 +0000 Received: (at 50664-done) by debbugs.gnu.org; 12 Nov 2021 05:52:51 +0000 Received: from localhost ([127.0.0.1]:43002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlPUZ-0001GY-Fi for submit@debbugs.gnu.org; Fri, 12 Nov 2021 00:52:51 -0500 Received: from mail-qv1-f43.google.com ([209.85.219.43]:42879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlPUY-0001GM-Lo for 50664-done@debbugs.gnu.org; Fri, 12 Nov 2021 00:52:51 -0500 Received: by mail-qv1-f43.google.com with SMTP id b17so5603709qvl.9 for <50664-done@debbugs.gnu.org>; Thu, 11 Nov 2021 21:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LB2jDm4J2TIAFX9bEUz6JTld9JTUWIRzXVk/40oUV28=; b=LwZc8K21RsWc+frgRgSKvy7HUJJnYNl8Ar5J7wUFdzH+DRWVdjL4qrMCuUuid3QplO czS0cHn+BoBRvFMkUff9I8E+xC9fBv7UkAXxjd+BI107TrvdPLg8mPk2GGSXLLTkx4Ot 3BeFCRVhFz9LshaJNK0r6bl4Eas3UXjyQAOtLNhEe2Xm2qIPdu9vJQKCPvVGFZJIIhFE zoFkoH/SrIOnllg1JJ0HOBVoVwXNBp6Lml/5t9Yk4/mY4STeeiG0oAc1Xh4rwKPrWBV8 TptcmGapZw+phOQiAI70Ns4SdgKN+fJi9kuZyypWPzMlqNNjsNaY2lUcIQR+ntXf6Q/7 RHTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LB2jDm4J2TIAFX9bEUz6JTld9JTUWIRzXVk/40oUV28=; b=VgfgsccjWTCI4kr8gXX7VM0/0wnKNSO1WZpPzprBjv5qZSVfzqe43E8k1+yHGeltUU LNlA3m45inEirwan3lMxnGai8dY+H4Q5WQPHE6wq0t7nrpwlCb1DFuN2y91nQjmMwmJe jzKYdb3VTZ5UqCn7ZeNn7acPmdHitqA/vCk3tg3FqGGsqkR7VQyZts11Zlg+Azo1yndh ZYxE2OthYyO6sUDOaMsYnHECDpmmaCPYFEteI+h313VUwvdYSiQ3jINIjFG29OE6eG9E 987AxJFBWYmDT9utWDYEa+w8kZXgeg0a/Jt+mNDpA2AbDyfv6BOpcnb7IAx1wx6gBV/7 /hiA== X-Gm-Message-State: AOAM5332IgdqOYRXs66qEDBt3WzG1ehNOkqIhUWNXxHcjr8OFrO/r8Ly 7B9mZbzlXuzxAmBAtKzq38tkOrTyF8VtVJXi X-Google-Smtp-Source: ABdhPJyzdJWfuFFCJ5tENFGuQy9+gPclNwUd+pV/wxstvdcTJpPcfvRjQAwWVSFa3PkHXvYJZRn8vA== X-Received: by 2002:a05:6214:501b:: with SMTP id jo27mr12286761qvb.64.1636696365248; Thu, 11 Nov 2021 21:52:45 -0800 (PST) Received: from hurd (dsl-10-133-155.b2b2c.ca. [72.10.133.155]) by smtp.gmail.com with ESMTPSA id j13sm2392826qkp.111.2021.11.11.21.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 21:52:44 -0800 (PST) From: Maxim Cournoyer References: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> Date: Fri, 12 Nov 2021 00:52:43 -0500 In-Reply-To: (Sarah Morgensen's message of "Sun, 19 Sep 2021 11:46:52 -0700") Message-ID: <87tughq5sk.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636696395; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=LB2jDm4J2TIAFX9bEUz6JTld9JTUWIRzXVk/40oUV28=; b=RdbcVwt2PnBEq1yG2brsPT3duiZw8oEeaWVhhno9hTAkEPUiVwr07dwF7J3YI6eQmhMxpv L8RmFgCKIJiyob6oL3RgtmOyuj50cIP5DRhGfs+o3L3JBJX3KailJzr2s+aJOGTDsYvmZE HEifLEGKVYFQdRM1BmtrOgjHKgG52WLvCUZ6IZUziuPKpOKWBJ6ZMqqJs4CRUXRjZCkqKr 2BZw19mc8eplAAo7EWcdw8x2VEbAx6mlPYATAA+qoiD8Zzgy68Ig/DEFMlnltete8lC84Z cn3R5QVC9Vx/gc3pYzMMjXQ51e+AUZL/rdr3rWYaYOh0jM8FTl/SqelSWD1i4Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636696395; a=rsa-sha256; cv=none; b=s0JxRzHEbLGjh7IoDHYRXE7tMd1Dh44mKYlqmAw91LBQGyWZZHRla9QTik2NlTf0oes+Gj q1aSnbA+egUQtrjkakdFO25ztPhYf3c4F17plMDxtNDpk03sFQKm/xQhAPnlyCvSfMuhAd J077bO6i86C9zyV8meleRnBT7PEtjNvQ9+oDefIgU7i/tloskNtjDHgkXbUEZODtWSVFtB jtf83Fm2klOCxqcMmgP5fyTGEO5acjxqYM31TuYpvY3yEDDLJhHVpZYc9ZryE2qJe9SdxN 7zsNLvqPRRv1HPGw4Fm72lRoKGva123SJMyK98DoUCdNJ6bjGN90BR7E7ySnzg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LwZc8K21; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.73 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LwZc8K21; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2CB5528E77 X-Spam-Score: -1.73 X-Migadu-Scanner: scn1.migadu.com X-TUID: AosMi+tGU18m Hello, Sarah Morgensen writes: > * gnu/packages/curl.scm (curl)[arguments]<#:phases>{check}: Respect #:tests?. > --- > Changes from v1: > > * Do not provide a default value for tests?, since gnu-build-system provides > one. > > -- > Sarah > gnu/packages/curl.scm | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm > index 063a919700..4c90c7b301 100644 > --- a/gnu/packages/curl.scm > +++ b/gnu/packages/curl.scm > @@ -124,16 +124,16 @@ > (rename-file (string-append out "/share/man/man3") > (string-append doc "/share/man/man3")) > #t))) > - (replace > - 'check > - (lambda _ > - (substitute* "tests/runtests.pl" > - (("/bin/sh") (which "sh"))) > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (substitute* "tests/runtests.pl" > + (("/bin/sh") (which "sh"))) > > - ;; The top-level "make check" does "make -C tests quiet-test", which > - ;; is too quiet. Use the "test" target instead, which is more > - ;; verbose. > - (invoke "make" "-C" "tests" "test")))))) > + (when tests? > + ;; The top-level "make check" does "make -C tests quiet-test", which > + ;; is too quiet. Use the "test" target instead, which is more > + ;; verbose. > + (invoke "make" "-C" "tests" "test"))))))) > (synopsis "Command line tool for transferring data with URL syntax") > (description > "curl is a command line tool for transferring data with URL syntax, > > base-commit: 8613652f3f80105f35db13d6d9308257bbff8474 This got merged in core-updates-frozen as 460d6aca0c9a8f8443d50e5a5cf2bf9841bcc559; and I just noticed I had forgotten to put my signed-off-by line; apologies. Thank you! Closing. Maxim