[bug#51890] Vigra: disable more failing tests on core-updates-frozen

[bug#51890] Vigra: disable more failing tests on core-updates-frozen

[Vivien Kraus via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 149 bytes --]


Dear guix,

vigra fails to pass a few more tests on core-updates-frozen. I propose
that we discard them. What do you think?

Best regards,

Vivien


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Disable more failing tests for vigra --]
[-- Type: text/x-patch, Size: 1216 bytes --]

From 9c376135ea264418cdc9eaa339274f244ba2e729 Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Tue, 16 Nov 2021 08:18:42 +0000
Subject: [PATCH] gnu: vigra: Disable more failing tests.

* gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
test2.
---
 gnu/packages/image.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index ed846d7141..6d5408864e 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1230,6 +1230,12 @@ (define-public vigra
               ;; <https://github.com/ukoethe/vigra/issues/436>.
               (substitute* "vigranumpy/test/CMakeLists.txt"
                 (("test1\\.py") ""))
+              (substitute* "vigranumpy/test/CMakeLists.txt"
+                (("test[23]\\.py") ""))
+              (substitute* "vigranumpy/test/CMakeLists.txt"
+                (("test_arraytypes\\.py") ""))
+              (substitute* "vigranumpy/test/CMakeLists.txt"
+                (("test_multidef\\.py") ""))
               #t)))
         #:configure-flags
           (list "-Wno-dev" ; suppress developer mode with lots of warnings
-- 
2.33.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]

[bug#51890] Vigra: disable more failing tests on core-updates-frozen

[Vivien Kraus via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 72 bytes --]


Sorry, I forgot some disabled tests in the changelog message.

Vivien


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Disable more tests for vigra on c-u-f --]
[-- Type: text/x-patch, Size: 1258 bytes --]

From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Tue, 16 Nov 2021 08:18:42 +0000
Subject: [PATCH] gnu: vigra: Disable more failing tests.

* gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
test2, test3, test_arraytypes and test_multidef.
---
 gnu/packages/image.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index ed846d7141..6d5408864e 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1230,6 +1230,12 @@ (define-public vigra
               ;; <https://github.com/ukoethe/vigra/issues/436>.
               (substitute* "vigranumpy/test/CMakeLists.txt"
                 (("test1\\.py") ""))
+              (substitute* "vigranumpy/test/CMakeLists.txt"
+                (("test[23]\\.py") ""))
+              (substitute* "vigranumpy/test/CMakeLists.txt"
+                (("test_arraytypes\\.py") ""))
+              (substitute* "vigranumpy/test/CMakeLists.txt"
+                (("test_multidef\\.py") ""))
               #t)))
         #:configure-flags
           (list "-Wno-dev" ; suppress developer mode with lots of warnings
-- 
2.33.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]

[bug#51890] Vigra: disable more failing tests on core-updates-frozen

[Ludovic Courtès]

Hi,

Vivien Kraus <vivien@planete-kraus.eu> skribis:

> From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
> From: Vivien Kraus <vivien@planete-kraus.eu>
> Date: Tue, 16 Nov 2021 08:18:42 +0000
> Subject: [PATCH] gnu: vigra: Disable more failing tests.
>
> * gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
> test2, test3, test_arraytypes and test_multidef.

Looks like it was worked around by disabling NumPy support in Vigra, in
commit 94b76dc85ca3098bf4ceb0f5b884b5708b9e8134.

I’m not sure how NumPy is used; is there a preference between these two
options (disabling flaky tests and removing the dependency on NumPy)?

Thanks,
Ludo’.

[bug#51890] Vigra: disable more failing tests on core-updates-frozen

[Efraim Flashner]

On November 18, 2021 9:09:50 AM UTC, "Ludovic Courtès" <ludo@gnu.org> wrote:
>Hi,
>
>Vivien Kraus <vivien@planete-kraus.eu> skribis:
>
>> From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
>> From: Vivien Kraus <vivien@planete-kraus.eu>
>> Date: Tue, 16 Nov 2021 08:18:42 +0000
>> Subject: [PATCH] gnu: vigra: Disable more failing tests.
>>
>> * gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
>> test2, test3, test_arraytypes and test_multidef.
>
>Looks like it was worked around by disabling NumPy support in Vigra, in
>commit 94b76dc85ca3098bf4ceb0f5b884b5708b9e8134.
>
>I’m not sure how NumPy is used; is there a preference between these two
>options (disabling flaky tests and removing the dependency on NumPy)?
>
>Thanks,
>Ludo’.

It looked to me like vigra was limping along and numpy compatibility was being dragged along by patches here and there. When I built the dependencies of vigra nothing failed to build. I'm definitely not against reinstating support for numpy but I'm not sure just disabling the tests is the right way.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[bug#51890] Vigra: disable more failing tests on core-updates-frozen

[Maxim Cournoyer]

Hello,

Efraim Flashner <efraim@flashner.co.il> writes:

> On November 18, 2021 9:09:50 AM UTC, "Ludovic Courtès" <ludo@gnu.org> wrote:
>>Hi,
>>
>>Vivien Kraus <vivien@planete-kraus.eu> skribis:
>>
>>> From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
>>> From: Vivien Kraus <vivien@planete-kraus.eu>
>>> Date: Tue, 16 Nov 2021 08:18:42 +0000
>>> Subject: [PATCH] gnu: vigra: Disable more failing tests.
>>>
>>> * gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
>>> test2, test3, test_arraytypes and test_multidef.
>>
>>Looks like it was worked around by disabling NumPy support in Vigra, in
>>commit 94b76dc85ca3098bf4ceb0f5b884b5708b9e8134.
>>
>>I’m not sure how NumPy is used; is there a preference between these two
>>options (disabling flaky tests and removing the dependency on NumPy)?
>>
>>Thanks,
>>Ludo’.
>
> It looked to me like vigra was limping along and numpy compatibility
> was being dragged along by patches here and there. When I built the
> dependencies of vigra nothing failed to build. I'm definitely not
> against reinstating support for numpy but I'm not sure just disabling
> the tests is the right way.

I know nothing about vigra, but judging from its description "[...] It
is an image processing and analysis library that puts its main emphasis
on customizable algorithms and data structures. [...]" it seems it'd
probably make good use of Numpy?  Not sure what are the consequences of
doing without; perhaps efficiency.

Thanks,

Maxim