From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WG9KG+1VmWFZRQEAgWs5BA (envelope-from ) for ; Sat, 20 Nov 2021 21:09:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SAfbFu1VmWGYLwAAbx9fmQ (envelope-from ) for ; Sat, 20 Nov 2021 20:09:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 20CBD463B for ; Sat, 20 Nov 2021 21:09:17 +0100 (CET) Received: from localhost ([::1]:53664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moWfj-00073h-CQ for larch@yhetil.org; Sat, 20 Nov 2021 15:09:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moWfX-00073Q-7G for guix-patches@gnu.org; Sat, 20 Nov 2021 15:09:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moWfW-0001Rb-As for guix-patches@gnu.org; Sat, 20 Nov 2021 15:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moWfW-0005Ky-06 for guix-patches@gnu.org; Sat, 20 Nov 2021 15:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. In-Reply-To: <20211114124151.36743-1-philip@philipmcgrath.com> Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Nov 2021 20:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath Cc: 51838@debbugs.gnu.org, Pierre Langlois , Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163743892520463 (code B ref 51838); Sat, 20 Nov 2021 20:09:01 +0000 Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 20:08:45 +0000 Received: from localhost ([127.0.0.1]:43715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moWfF-0005Jy-77 for submit@debbugs.gnu.org; Sat, 20 Nov 2021 15:08:45 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moWf9-0005JZ-Nv for 51838@debbugs.gnu.org; Sat, 20 Nov 2021 15:08:43 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7F1E45C00DD; Sat, 20 Nov 2021 15:08:34 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 20 Nov 2021 15:08:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=HsUQuTj0Bte0NUdR0NSSDfi09hAe/fMsh+rhFccJNfI=; b=XGtRi+/f kH3UFZ+zBI+XQJ0zCQZfS4lMRm7AZhzPFKbdCPXG7We4hY9D9pZJybkMSh968Fmf AI8DhwZ11Tu9kxPK28TlAZeJkGHlO9TWWyzFd8pAh8FxsIdvIK9dGu0+QwyCZFCh 97sVbiqBCaUVDhx+3QWXOftA/OdOVcpFoQx+2VwUFVxsMSX4XkD0EqbJJXAFxXjE 5Ep99ZnjZCTdh4tmuBum0r+T5Wjslie6rI1EbPqvFoIlPcD7hEFIGj2D1I2jkOg3 yAWvxFJu5ONvyQdVApAwtapJ/cwZic/4I18Ez8xlowsEjryq7HvIjUkN+1u+Hk8v A6MdLVNEcXcb+Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgedtgddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhffffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhmohht hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtffrrg htthgvrhhnpedvtdevuddukeevgefggffhtefhueffkeegkeevudeftedugefgtdefheef jeffieenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmphhlvghtsehnghihrhhordgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 20 Nov 2021 15:08:33 -0500 (EST) From: Timothy Sample References: <20211114125830.45427-1-philip@philipmcgrath.com> <20211114130409.49241-1-philip@philipmcgrath.com> <20211114130409.49241-2-philip@philipmcgrath.com> <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@gmail.com> <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> Date: Sat, 20 Nov 2021 15:08:32 -0500 Message-ID: <87tug6bnen.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637438957; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HsUQuTj0Bte0NUdR0NSSDfi09hAe/fMsh+rhFccJNfI=; b=HjfnLVOSbPpsp6KD7wF7T/dJT2zW4Ldbx+G6TbM/ZF9QThcSjsKW5fdvm2AXZa7LxvOX4S LBboTU0wm5LbeKUFjCguLLPccgFL7DzrZNgbR8hc6FRcvCeejmmOoCGI22MMQ8DOs2AX/K 8s6d5uTHQ5LOTZ//5gPPTGUnB91HrjUznV77bnCMtpd3hpLCkuC2grJa5ULZKft6EhjAWZ 50gGqEkBpl7+bXoLNS1MYUGmA1Qvc+QQlXEKbLHRa6KuIEF6zxQocVxpaoJsL5MWtLtYjF bnLxxqnGSw/TMj3eI99VfVYsHT1YttVXfV9sQyfY3EBpwA3A1jya5oIrXbzUwA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637438957; a=rsa-sha256; cv=none; b=GQkyIeeZuT5DKBKodR1Ap5EbPuDMnMYwvlWW4RPHRffb2dzgK5PGnBE3V8jHljoUh3LDav 7w6Upn5ukp4IEv1w2iSNrJXR4tfJNFZZpG0lYJ8VGJN/kaRtVm3Pk+gpoTfhir3ID9aBQV GDmPSm+QXBdpOPpaTgOhY3UO1guPKIgY0nbFF80KFPe2EGrZ6hVdfNa1MUcZropXIphQW4 hWwoCCbAz/4g8q2ZNspEDkSAQrgjG1tZZpx/nLK6Stq668ara/KwrJOKWDsSEULetsrPTp 8POtpUF36Ax2Q1EgkFHg0mUgov5NfeIaFyxpaa7Kc961ThLBr1K/Lnwq/IG3JQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="XGtRi+/f"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.47 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="XGtRi+/f"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 20CBD463B X-Spam-Score: -0.47 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6tFKl7tbxBMR Hi Philip, There are some really valuable changes in here, thanks! I would like to start understanding and reviewing the changes so that we can get some of this good stuff merged in. However, I have one question that I couldn=E2= =80=99t answer from reading here or at : is there an agreement between you and Pierre that these patches are the =E2=80=9Cright=E2=80=9D way to do native addons for Node.js. More importan= tly, is the general plan that we merge these changes, and then Pierre rebases their Tree-sitter changes on top these? Pierre, maybe you could weigh in here? Sorry if I missed something. I assume everything is OK, but I want to be sure before I start digging into the details of the patches =E2=80=93 especially those first few more complicated ones. :) Thanks! -- Tim