From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cIX+H+mrmmEWJQEAgWs5BA (envelope-from ) for ; Sun, 21 Nov 2021 21:28:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +N63G+mrmmEzawAA1q6Kng (envelope-from ) for ; Sun, 21 Nov 2021 20:28:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 17DAA2E9C0 for ; Sun, 21 Nov 2021 21:28:25 +0100 (CET) Received: from localhost ([::1]:46010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1motRn-0001ig-Qh for larch@yhetil.org; Sun, 21 Nov 2021 15:28:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1motRT-0001iE-3P for guix-patches@gnu.org; Sun, 21 Nov 2021 15:28:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1motRS-0006QM-Qt for guix-patches@gnu.org; Sun, 21 Nov 2021 15:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1motRS-0006AJ-FD for guix-patches@gnu.org; Sun, 21 Nov 2021 15:28:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52027] [PATCH] Add lz4json Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Nov 2021 20:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52027 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Baptiste Strazzulla Cc: 52027@debbugs.gnu.org Received: via spool by 52027-submit@debbugs.gnu.org id=B52027.163752645923668 (code B ref 52027); Sun, 21 Nov 2021 20:28:02 +0000 Received: (at 52027) by debbugs.gnu.org; 21 Nov 2021 20:27:39 +0000 Received: from localhost ([127.0.0.1]:46120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1motR5-00069g-E1 for submit@debbugs.gnu.org; Sun, 21 Nov 2021 15:27:39 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:60195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1motR2-00069N-J2 for 52027@debbugs.gnu.org; Sun, 21 Nov 2021 15:27:37 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 876C3FF807; Sun, 21 Nov 2021 20:27:29 +0000 (UTC) From: Nicolas Goaziou References: Date: Sun, 21 Nov 2021 21:27:28 +0100 In-Reply-To: (Baptiste Strazzulla's message of "Sun, 21 Nov 2021 19:55:22 +0000") Message-ID: <87tug5uudr.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637526505; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=5+gEoyxuIQ6COrH8AsF7gr4p4OryyLtpjdDGhkt9Ht0=; b=ulOVLRu4qZacw62WOdk1xlnB5rh6HPB8L3Y3/m/hGCiL36NSqqLTFPEt3lYEwOAMSdqjuh qj6KTqj1X/EvAX4385xObjazisGs89WQwLuYwWy9Q23Hi5UJKwYEyTTsVTyH80ay7vByET 6aIG0IzMCRuAF7hmGmBZ5Vexe06qZS0SRGZwkBKjE1jSKfuPxk6tvC95MZSqRRIoBNQBf0 QM0TNsDODHu5lHGn4dmYVhj/wku1D6Bl1B6u+MyjD7jqVNUoFdFVQTCkdIQ3Psovrvh95A M1NMUJ/0DKXcurAJn68g5ubIoA4UbE9f/SjeGnv8cqEwfTRQSo+FZiEMSBap4Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637526505; a=rsa-sha256; cv=none; b=Eei/B5mAKicJb/Jf53Ts6pxYYRELVSp3NQ43ndXQGXL72cWQ7DFfpVLLWKYgp6mqfK/KG6 bzoLUg/2boAGIslE68fA/qjgK18PGYBpFTxe4QtZQ7WvOoNqyQVZ2lxevddiPMWeYKmjnT Pf5qfRjtx8OG9FB2/GJ1f5KW6L9DYgthcitc4+0hnMAJKksJSZD5OKr1Nt51B6z+rfgPke VZVjURZfsMOmMgpam/KKBXNWymHcQhQaciljDu2jHqtoCZgxWRgZFu6dKa09lqBKb3JgeI bg2hd2jIhznLntcQnIXoJ/hUoHb4gvnJN5mA4WMwAm6gpsCO3yhBjb9tuafIOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.98 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 17DAA2E9C0 X-Spam-Score: -2.98 X-Migadu-Scanner: scn0.migadu.com X-TUID: O9rB4GFiDjTG Hello, Baptiste Strazzulla writes: > I couldn't figure out a license for this package. It says " * > Copyright (c) 2014 Intel Corporation" in the source. I don't even know > if it's an actual license. > In any case, it doesn't seem really > engaging and there's no mention of it in `licenses.scm`=E2=80=A6 How shall > I proceed? The license is below, in the lz4jsoncat.c header. It's bsd-2 > +(define-public lz4json > + (package > + (name "lz4json") > + (version "2") > + (home-page "https://github.com/andikleen/lz4json") This should be moved right before the synopsis field. > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference (url home-page) (commit (string-append "v" versio= n)))) (url ...) should provide the github URL and not re-use the home-page. Also there should be newline characters before and after the url field. > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (delete 'check) > + (replace 'install Could you add comment explaining why 'configure' is deleted (probably because there is no configure script) and 'install' is replaced (probably because upstream provides no install script either). Instead of deleting `check', you should use: #:tests? #false instead. > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (man (string-append out "/share/man/man1"))) > + (install-file "lz4jsoncat" bin) > + (install-file "lz4jsoncat.1" man)) > + #t))) You can remove the trailing boolean at the end of the phase. > + #:make-flags '("CC=3Dgcc"))) The above is not cross-compilation friendly. It should become `(,(string-append "CC=3D" (cc-for-target))) instead. > + (synopsis "C decompress tool for mozilla lz4json format") > + (description > + "A little utility to unpack lz4json files as generated by Firefox's > +bookmark backups and session restore. This is a different format from w= hat > +the normal lz4 utility expects. The data is dumped to stdout.") The description should consist of full sentences. So it may start as @code{lz4json} is a little utility to unpack lz4json files=E2=80=A6 > + (license license:gpl3+))) This should be license:bsd-2. Thanks for your work. Could you send an updated patch? Regards, --=20 Nicolas Goaziou