From: "Ludovic Courtès" <ludo@gnu.org>
To: Zhu Zihao <all_but_last@163.com>
Cc: 54261@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>,
Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#54261] [PATCH]: Update GTK to 4.6.1.
Date: Fri, 01 Apr 2022 17:54:46 +0200 [thread overview]
Message-ID: <87tubcn6ih.fsf@gnu.org> (raw)
In-Reply-To: <86czi4rtfu.fsf@163.com> (Zhu Zihao's message of "Wed, 30 Mar 2022 11:45:49 +0800")
Hi,
Zhu Zihao <all_but_last@163.com> skribis:
> From 62a640576ae1de9523fba593219fb50ac97b44c6 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <all_but_last@163.com>
> Date: Mon, 21 Mar 2022 09:16:38 +0800
> Subject: [PATCH 3/4] gnu: Add fcitx5-gtk4.
>
> * gnu/packages/fcitx5.scm (fcitx5-gtk4): New variable.
> ---
> gnu/packages/fcitx5.scm | 42 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/fcitx5.scm b/gnu/packages/fcitx5.scm
> index 2d5917f3c0..be46a5036c 100644
> --- a/gnu/packages/fcitx5.scm
> +++ b/gnu/packages/fcitx5.scm
> @@ -250,6 +250,48 @@ (define (split-immodule gtk-version output)
> @end table")
> (license license:lgpl2.1+)))
>
> +;; XXX: This package is separated from fcitx5-gtk for following reasons.
> +;; 1. GTK4 has a lot more dependencies, some of which maybe unavailable on
> +;; platforms other than x86_64. See <https://issues.guix.gnu.org/53648>.
> +;; 2. GTK4 now propagates pango@1.50, it will conflict with GTK3 and GTK2
> +;; (propagates pango@1.48) if they're all in the inputs of same package.
> +;; See <https://issues.guix.gnu.org/54261>.
> +(define-public fcitx5-gtk4
> + (package
> + (inherit fcitx5-gtk)
> + (name "fcitx5-gtk4")
> + (arguments
> + (list
> + #:tests? #f ;No test
> + #:configure-flags
> + #~(list (string-append "-DCMAKE_CXX_FLAGS=-I"
> + #$(this-package-input "fcitx5-gtk")
> + "/include/Fcitx5/GClient"))
This one fails to build for me:
--8<---------------cut here---------------start------------->8---
-- Looking for shmat - found
-- Checking for module 'gtk+-2.0'
-- No package 'gtk+-2.0' found
CMake Error at /gnu/store/zga679c4nldah9l8dhd5a4hdy820hcyf-cmake-minimal-3.21.4/share/cmake-3.21/Modules/FindPkgConfig.cmake:562 (message):
A required package was not found
Call Stack (most recent call first):
/gnu/store/zga679c4nldah9l8dhd5a4hdy820hcyf-cmake-minimal-3.21.4/share/cmake-3.21/Modules/FindPkgConfig.cmake:784 (_pkg_check_modules_internal)
gtk2/CMakeLists.txt:6 (pkg_check_modules)
-- Configuring incomplete, errors occurred!
See also "/tmp/guix-build-fcitx5-gtk4-5.0.9.drv-0/build/CMakeFiles/CMakeOutput.log".
error: in phase 'configure': uncaught exception:
%exception #<&invoke-error program: "cmake" arguments: ("../fcitx5-gtk-5.0.9" "-DCMAKE_BUILD_TYPE=RelWithDebInfo" "-DCMAKE_INSTALL_PREFIX=/gnu/store/5z0a2zrr19pmg4swzsb0jm5fwqh03x0y-fcitx5-gtk4-5.0.9" "-DCMAKE_INSTALL_LIBDIR=lib" "-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=TRUE" "-DCMAKE_INSTALL_RPATH=/gnu/store/5z0a2zrr19pmg4swzsb0jm5fwqh03x0y-fcitx5-gtk4-5.0.9/lib" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DCMAKE_CXX_FLAGS=-I/gnu/store/fkq1pgfp1r43f2131f8yvx543n7gb7ww-fcitx5-gtk-5.0.9/include/Fcitx5/GClient") exit-status: 1 term-signal: #f stop-signal: #f>
phase `configure' failed after 2.9 seconds
command "cmake" "../fcitx5-gtk-5.0.9" "-DCMAKE_BUILD_TYPE=RelWithDebInfo" "-DCMAKE_INSTALL_PREFIX=/gnu/store/5z0a2zrr19pmg4swzsb0jm5fwqh03x0y-fcitx5-gtk4-5.0.9" "-DCMAKE_INSTALL_LIBDIR=lib" "-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=TRUE" "-DCMAKE_INSTALL_RPATH=/gnu/store/5z0a2zrr19pmg4swzsb0jm5fwqh03x0y-fcitx5-gtk4-5.0.9/lib" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DCMAKE_CXX_FLAGS=-I/gnu/store/fkq1pgfp1r43f2131f8yvx543n7gb7ww-fcitx5-gtk-5.0.9/include/Fcitx5/GClient" failed with status 1
builder for `/gnu/store/p9611ymj4mav45wi92fdyslb2p7854hl-fcitx5-gtk4-5.0.9.drv' failed with exit code 1
@ build-failed /gnu/store/p9611ymj4mav45wi92fdyslb2p7854hl-fcitx5-gtk4-5.0.9.drv - 1 builder for `/gnu/store/p9611ymj4mav45wi92fdyslb2p7854hl-fcitx5-gtk4-5.0.9.drv' failed with exit code 1
derivation '/gnu/store/p9611ymj4mav45wi92fdyslb2p7854hl-fcitx5-gtk4-5.0.9.drv' offloaded to 'localhost' failed: build of `/gnu/store/p9611ymj4mav45wi92fdyslb2p7854hl-fcitx5-gtk4-5.0.9.drv' failed
build of /gnu/store/p9611ymj4mav45wi92fdyslb2p7854hl-fcitx5-gtk4-5.0.9.drv failed
--8<---------------cut here---------------end--------------->8---
Could you take a look and send an updated patch?
Also, I find it surprising that ‘fcitx5-gtk4’ depends on ‘fcitx5-gtk’;
is it avoidable?
The rest LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2022-04-01 15:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 15:00 [bug#54261] [PATCH]: Update GTK to 4.6.1 Zhu Zihao
[not found] ` <handler.54261.B.164649346324787.ack@debbugs.gnu.org>
2022-03-05 15:55 ` [bug#54261] Acknowledgement ([PATCH]: Update GTK to 4.6.1.) Zhu Zihao
2022-03-11 15:15 ` Zhu Zihao
2022-03-11 15:59 ` Maxime Devos
2022-03-11 16:01 ` Maxime Devos
2022-03-12 2:38 ` Zhu Zihao
2022-03-12 9:17 ` Maxime Devos
2022-03-12 9:32 ` Maxime Devos
2022-03-12 9:40 ` Maxime Devos
2022-03-11 16:03 ` Maxime Devos
2022-03-15 15:42 ` Zhu Zihao
2022-03-18 22:48 ` [bug#54261] [PATCH]: Update GTK to 4.6.1 Ludovic Courtès
2022-03-19 3:00 ` Zhu Zihao
2022-03-21 1:17 ` Zhu Zihao
2022-03-27 3:04 ` Zhu Zihao
2022-03-27 7:38 ` Liliana Marie Prikler
2022-03-28 15:37 ` Zhu Zihao
2022-03-28 18:19 ` Liliana Marie Prikler
2022-03-29 5:56 ` Zhu Zihao
2022-03-29 6:01 ` Zhu Zihao
2022-03-30 19:56 ` Ludovic Courtès
2022-03-31 5:13 ` Zhu Zihao
2022-03-29 13:34 ` Ludovic Courtès
2022-03-30 3:45 ` Zhu Zihao
2022-04-01 15:54 ` Ludovic Courtès [this message]
2022-04-02 3:41 ` Zhu Zihao
2022-04-04 20:12 ` bug#54261: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tubcn6ih.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=54261@debbugs.gnu.org \
--cc=all_but_last@163.com \
--cc=liliana.prikler@gmail.com \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).