unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Paul A. Patience" <paul@apatience.com>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: "50080@debbugs.gnu.org" <50080@debbugs.gnu.org>
Subject: [bug#50080] Commit updating SUNDIALS to 6.1.1.
Date: Tue, 26 Apr 2022 19:47:12 +0000	[thread overview]
Message-ID: <87tuafd4az.fsf@apatience.com> (raw)
In-Reply-To: <878rs67msg.fsf@gnu.org>

Hi Ludovic,

On 2022-04-15 04:50:39-04:00, Ludovic Courtès wrote:
> "Paul A. Patience" <paul@apatience.com> skribis:
>> Do you know if the update to 6.1.1 renders the issues extraneous?
>
> Thanks for bringing it up, I had overlooked this patch of yours—my
> apologies for that.  I don’t know if the new version defaults to 64-bit
> or 32-bit indices.

Ok, I figured out what happened.

--8<---------------cut here---------------start------------->8---
      ("petsc" ,petsc-openmpi)         ;support in SUNDIALS requires MPI
-       ,@(package-inputs sundials)))
+       ("petsc-openmpi" ,petsc-openmpi)      ;support in SUNDIALS requires MPI
+       ,@(alist-delete "petsc" (package-inputs sundials))))
     (arguments
      (substitute-keyword-arguments (package-arguments sundials)
        ((#:configure-flags flags '())
-        `(cons* "-DMPI_ENABLE:BOOL=ON"
-                "-DPETSC_ENABLE:BOOL=ON"
-                (string-append "-DPETSC_INCLUDE_DIR="
-                               (assoc-ref %build-inputs "petsc")
-                               "/include")
-                (string-append "-DPETSC_LIBRARY_DIR="
-                               (assoc-ref %build-inputs "petsc")
-                               "/lib")
-                ,flags))
+        `(cons* "-DENABLE_MPI:BOOL=ON" ,flags))
--8<---------------cut here---------------end--------------->8---

You accidentally disabled PETSc support in SUNDIALS by not re-adding
PETSC_ENABLE in the sundials (not sundials-openmpi) package.
If you had done so, the configure step would have failed because PETSc
is supported in SUNDIALS only with MPI (hence the comment).
Once we enable PETSc again, the index size problem appears again, even
with SUNDIALS 6.1.1.

Basically, I think all of my changes are still relevant.
I still think setting the sundials and sundials-openmpi's index sizes to
32 bits is the most logical option (see the commit message in the
“gnu: sundials: Update to 5.7.0.” patch).

I will bring my old patch series up to date and submit it again when
it's done.

Best regards,
Paul





  parent reply	other threads:[~2022-04-26 19:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 19:36 [bug#50080] [PATCH] gnu: sundials, dealii: Update sundials to 5.7.0 and add to dealii inputs Paul A. Patience
2021-10-21 13:52 ` Paul A. Patience
2022-04-14 18:06 ` [bug#50080] Commit updating SUNDIALS to 6.1.1 Paul A. Patience
2022-04-15  8:50   ` Ludovic Courtès
2022-04-20 14:31     ` Paul A. Patience
2022-04-26 17:46     ` Paul A. Patience
2022-04-26 19:47     ` Paul A. Patience [this message]
2022-04-28 10:04       ` Ludovic Courtès
2022-04-28 17:11 ` [bug#50080] [PATCH v2 0/4] gnu: sundials: Fix various issues and update to 6.2.0 Paul A. Patience
2022-04-28 17:11   ` [bug#50080] [PATCH v2 1/4] gnu: petsc-openmpi: Fix inputs Paul A. Patience
2022-04-30  9:02     ` Maxime Devos
2022-05-02 13:56       ` Paul A. Patience
2022-04-28 17:11   ` [bug#50080] [PATCH v2 2/4] gnu: sundials: Fix various issues Paul A. Patience
2022-04-28 17:11   ` [bug#50080] [PATCH v2 3/4] gnu: sundials-openmpi: Add HYPRE dependency Paul A. Patience
2022-04-28 17:11   ` [bug#50080] [PATCH v2 4/4] gnu: sundials: Update to 6.2.0 Paul A. Patience
2022-05-02 13:28 ` [bug#50080] [PATCH v3 0/4] gnu: sundials: Fix various issues and update " Paul A. Patience
2022-05-02 13:28   ` [bug#50080] [PATCH v3 1/4] gnu: petsc-openmpi: Fix header inclusions Paul A. Patience
2022-05-02 13:28   ` [bug#50080] [PATCH v3 2/4] gnu: sundials: Fix various issues Paul A. Patience
2022-05-02 13:28   ` [bug#50080] [PATCH v3 3/4] gnu: sundials-openmpi: Add HYPRE dependency Paul A. Patience
2022-05-02 13:28   ` [bug#50080] [PATCH v3 4/4] gnu: sundials: Update to 6.2.0 Paul A. Patience
2022-05-03 15:35   ` bug#50080: [PATCH] gnu: sundials, dealii: Update sundials to 5.7.0 and add to dealii inputs Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuafd4az.fsf@apatience.com \
    --to=paul@apatience.com \
    --cc=50080@debbugs.gnu.org \
    --cc=ludovic.courtes@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).