From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MLIEDxCIiWINAQAAbAwnHQ (envelope-from ) for ; Sun, 22 May 2022 02:47:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QGIJDhCIiWLZewEAG6o9tA (envelope-from ) for ; Sun, 22 May 2022 02:47:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C72B01CF7 for ; Sun, 22 May 2022 02:47:11 +0200 (CEST) Received: from localhost ([::1]:60992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsZkU-0000lB-N8 for larch@yhetil.org; Sat, 21 May 2022 20:47:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsZkM-0000jT-EH for guix-patches@gnu.org; Sat, 21 May 2022 20:47:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nsZkM-0008Kd-5N for guix-patches@gnu.org; Sat, 21 May 2022 20:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nsZkM-0002f5-2P for guix-patches@gnu.org; Sat, 21 May 2022 20:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55517] [PATCH]: gnu: emacs-magit: Drop the libgit backend. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 May 2022 00:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55517 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Zhu Zihao Cc: 55517@debbugs.gnu.org Received: via spool by 55517-submit@debbugs.gnu.org id=B55517.165318040310205 (code B ref 55517); Sun, 22 May 2022 00:47:02 +0000 Received: (at 55517) by debbugs.gnu.org; 22 May 2022 00:46:43 +0000 Received: from localhost ([127.0.0.1]:43217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsZk2-0002eX-Kh for submit@debbugs.gnu.org; Sat, 21 May 2022 20:46:42 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:46888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsZjx-0002eH-5b for 55517@debbugs.gnu.org; Sat, 21 May 2022 20:46:40 -0400 Received: by mail-qt1-f179.google.com with SMTP id u35so10407727qtc.13 for <55517@debbugs.gnu.org>; Sat, 21 May 2022 17:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BfgmRvo3EwcIPx+jkMjtyTDleGQlXaQQ++QDInxS5WU=; b=GN5R5sVhyVjgxgreuLZi2arA1SF6vUxYIu5FLTRYijS/ry3GIt1EmkdrsNR50OaaHm gQZI566ETSqrBte4fjvPZUgWim6Bs6UdZTRGvOiCfMF8U12NdRq7mfwNoZ8FGb9uyD/2 ZBU6nWVYoW34tyPENUhotJGZwuPODfrih+mjyC4CHZQT2ziR/j0Wk/vh9H6r7QyiYqWH 1MRfgQtyngvWgMY4Ov3tmqn6+3JoT+TlwF0c/Vsv6IZxWUhM0rATiRrndQuN8nUslUMP dY5ER01ttpIPozLtqg/L9dlAjrdpOOJDcC05l7I4Puo+oQaiH6Q1/nwFeVIIXD0nYgYR ns0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BfgmRvo3EwcIPx+jkMjtyTDleGQlXaQQ++QDInxS5WU=; b=yAK2e5G/5rXKQrah8mbjXGUIreQC5BWFvrkUCPnSx4J8bUEwgQzrok9nZV+fes3T2Z SHJ2rbUlwS+ayccjtrRR0oB697wtdZV7JjEqhozosRmPGLAtmkGqtOPE6UmSG0c5rpaB tiahp4R+s45U5bjN/+agC0jfwy5dybYBgqv44OowxoiEZ4ccgAVjys1hc3kNC97NnB4M DWoSOcwcu5IB+ipWJGqY5PcRy1nbmGvZtRBAujXJXWt+uyOm+LH8gTCHeWyL5zdNJHZF 9iRDSEcJrzqO6YMhu/7ITUqdugRvE0FcTFYgWDoI/W/ttyfIU4DBakczuNbkzELLXLek 1IGA== X-Gm-Message-State: AOAM531i9oHkPGDwWHeK4dS/flb/edIZK2ACGfUFoxyLqCPEz0vDjwf1 j9LvXm4lBSY7uv/gz8fzsnLfvkkfuuBIpA== X-Google-Smtp-Source: ABdhPJxM3+UV6MFGDhgxAWYRbiRtQkNvN63fLl/LjJwtn/C+GjcbruvmB7rPhv2o9ZwPRwkxx9LYvA== X-Received: by 2002:a05:622a:514:b0:2f4:5f66:7025 with SMTP id l20-20020a05622a051400b002f45f667025mr12395460qtx.141.1653180391431; Sat, 21 May 2022 17:46:31 -0700 (PDT) Received: from hurd (dsl-152-80.b2b2c.ca. [66.158.152.80]) by smtp.gmail.com with ESMTPSA id l127-20020a37a285000000b0069fc13ce1f3sm2156206qke.36.2022.05.21.17.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 17:46:31 -0700 (PDT) From: Maxim Cournoyer References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <87tu9jbpkj.fsf_-_@gmail.com> <865ylzy1pr.fsf@163.com> Date: Sat, 21 May 2022 20:46:13 -0400 In-Reply-To: <865ylzy1pr.fsf@163.com> (Zhu Zihao's message of "Sat, 21 May 2022 11:45:46 +0800") Message-ID: <87tu9i9yy2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653180431; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BfgmRvo3EwcIPx+jkMjtyTDleGQlXaQQ++QDInxS5WU=; b=NUGA9mSSWRMAmoew1yUwEUZiJf9AyQShvXxXmW66cg5QjU/T4zjtkbOcQ0pjJeStC3Hhy3 mb2Sc/flhpG2Y7NluioC8LDaN5juryvw1O8fsKEO9ImLPW3nulMtJUkuH3QXMaZLWt4dJJ qUdYXPRh8J4+E44k+5MqD53ilzExqw9okhGOA9QADWgq5rfyDVSQMgmcFEEODwLv+FyfWo 01SS8HwhvaPRvsYDCYO2wFtww/7JYu1tZVpUhmz5xO1FgjfRePj2wQXrG2YVbKa5tLh5A5 BxuCIo1xmV0r1H9UuIg1dxYxx580gJ9zkyxAjoFtVKWTpvPmpKBQOnxZH1gpDw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653180431; a=rsa-sha256; cv=none; b=QcDNb7UsMYIkWjEUxaWM7EPVHT5fYq8VSy0rMqmY0ctE546or7ah58k0FE8QbY8Ss+cG9r eQqh+4346VZwOPyfIcA+8cozrfMEpH/BBYcX1woLlrusJzCK0UV94k7eDw0/Q3y2fnJcBi +v7Nw9rR9Z2Zh8coviFL+UZD/n1lCGYbae9piTBxgljeQUnNxOb03nuVT9GqsfLLmFzzjv CmrQRtePpKElnfA7yXnrIMPbnw8LMYPxsCuX4UXDXMVNR0vY741v1CafLHyDYpVJA5SWOh QtCCFHgPbFI/ToIkeCHlj5e/90cAeArTvUy1MPRu2spf/d7et/I8zkBdZ1TEqA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=GN5R5sVh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.64 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=GN5R5sVh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C72B01CF7 X-Spam-Score: 4.64 X-Migadu-Scanner: scn0.migadu.com X-TUID: X9XMLEYZcNJI Hello, Zhu Zihao writes: > Maxim Cournoyer writes: > >> Hi Zhu, >> >> Zhu Zihao writes: >> >>> Fix the typo in commit message >>> >>>>>From 8a2de5764a67bea1cbf789c8d6ce0ab0878ec40b Mon Sep 17 00:00:00 2001 >>> From: Zhu Zihao >>> Date: Thu, 19 May 2022 13:01:46 +0800 >>> Subject: [PATCH] gnu: emacs-magit: Drop the libgit backend. >>> >>> Drop the libgit backend for following reasons: >>> >>> 1. The libgit backend of Magitis very incomplete. There's almost no benefits, >>> but extra maintenance efforts. >> >> Could you elaborate about "almost no benefits"? Even if it's a small >> benefit, if it makes it faster, I'd still keep it since Magit is at >> times excruciatingly slow. > > It's slow? AFAIK magit user always complain that magit on Windows system > is slow. The process creation on *nix is much cheaper than Windows, so > Magit is not slow on *nix. I've never used it on Windows, but yes, when working with hundred of commits it's quite slow; just refreshing the status buffer takes ages. > I've elaborated the reason in > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55427. > > The libgit backend of Magit is almost nothing, only one function is > implemented. `magit-bare-repo-p` will be used in magit-toplevel which is > called frequently in the magit source code. But this function is cached. Thanks for that; I've looked at magit-libgit.el and it indeed doesn't appear to provide much of anything yet. I guess we could drop the dependency for now and revisit it in the future if/when development picks up again on the magit/libgit integration. Thanks, Maxim