From: Mathieu Othacehe <othacehe@gnu.org>
To: Andrew Patterson <andrewpatt7@gmail.com>
Cc: 55545@debbugs.gnu.org
Subject: [bug#55545] [PATCH] Get ~emacs-promise~ to build in emacs 28
Date: Sun, 05 Jun 2022 21:14:38 +0200 [thread overview]
Message-ID: <87tu8yncrl.fsf@gnu.org> (raw)
In-Reply-To: <87fsl4x9hy.fsf@gmail.com> (Andrew Patterson's message of "Fri, 20 May 2022 15:55:10 -0400")
Hello Andrew,
> - (source
> - (origin
> - (method git-fetch)
> - (uri (git-reference
> - (url "https://github.com/chuntaro/emacs-promise")
> - (commit version)))
> - (file-name (git-file-name name version))
> - (sha256
> - (base32 "1xb34zdbwjvahfhycjphdkm925kgd22dr298c57hwxza4ljc2hxj"))))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/chuntaro/emacs-promise")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1xb34zdbwjvahfhycjphdkm925kgd22dr298c57hwxza4ljc2hxj"))))
This change is not related to the build fix, it shouldn't be part of
this commit.
> (build-system emacs-build-system)
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-after 'unpack 'patch-obsolete
> + (lambda* _
> + (substitute* "promise.el"
> + (("\\(define-obsolete-function-alias (.*) (.*)\\)" _
> + obsolete cur) (format #f
> + "(define-obsolete-function-alias ~a ~a ~a)"
> + obsolete cur "\"2020-01-10\""))))))))
This has been fixed upstream, so you could also update the package to
the latest commit, see how it's done in the emacs-libgit package for
instance.
> (home-page "https://github.com/chuntaro/emacs-promise")
> (synopsis "Promises/A+ for Emacs")
> - (description "This is a simple implementation of Promises/A+.
> + (description
> + "This is a simple implementation of Promises/A+.
>
> This implementation ports the following Promises/A+ features
> faithfully. See @url{https://github.com/then/promise}.
> @@ -30371,7 +30381,8 @@ (define-public emacs-promise
> @item It supports \"thenable\".
> @item It supports \"Inheritance of Promise\".
> @item It supports \"rejection-tracking\".
> -@end itemize\n")
> +@end itemize
> +")
> (license license:gpl3+)))
Those changes also shouldn't be part of this patch.
Could you please send an update version?
Thanks,
Mathieu
prev parent reply other threads:[~2022-06-05 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 19:55 [bug#55545] [PATCH] Get ~emacs-promise~ to build in emacs 28 Andrew Patterson
2022-06-05 19:14 ` Mathieu Othacehe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu8yncrl.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=55545@debbugs.gnu.org \
--cc=andrewpatt7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).