From: muradm <mail@muradm.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: "\(" <paren@disroot.org>, 56858@debbugs.gnu.org
Subject: [bug#56858] [PATCH] gnu: libcgroup: Update to 2.0.2.
Date: Tue, 09 Aug 2022 23:29:09 +0300 [thread overview]
Message-ID: <87tu6lxijz.fsf@muradm.net> (raw)
In-Reply-To: <87bkst5syp.fsf_-_@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 4350 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> "(" <paren@disroot.org> skribis:
>
>> On Mon Aug 1, 2022 at 6:42 AM BST, muradm wrote:
>>> Is there a guideline where home-page should be? I find it more
>>> DRY when reusing.
>> Almost every package in Guix puts it directly above synopsis,
>> though
>> you do have a point about DRY.
>
> Yeah IMO it’s a good idea to reuse ‘home-page’ like this patch
> does.
>
>>> Their repo is not suitable for building from, instead
>>> they release sources manually.
>> Looks okay to me:
>> <https://github.com/libcgroup/libcgroup/tree/v2.0.2>
>> But there is a problem with vendoring googletest, it seems.
>> You'll want
>> to use the system's googletest, and (recursive? #t) in the
>> git-reference
>> to clone the tests repo. Also, the tarball seems to contain
>> pregenerated
>> autotools files, which are discouraged by Guix.
>
> So, first things first. The priority should be to run tests and
> remove
> the bundled googletest, which I tried with the patch below.
>
> Now, tests won’t run because apparently they try to use ‘sudo’
> (!):
>
> Traceback (most recent call last):
> File
> "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/./ftests.py",
> line 353, in <module>
> sys.exit(main(config))
> File
> "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/./ftests.py",
> line 337, in main
> setup(config, record_time=True)
> File
> "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/./ftests.py",
> line 170, in setup
> Run.run(['sudo', 'lxd', 'init', '--auto'])
> File
> "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/run.py",
> line 38, in run
> subproc = subprocess.Popen(command, shell=shell_bool,
> File
> "/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/subprocess.py",
> line 951, in __init__
> self._execute_child(args, executable, preexec_fn, close_fds,
> File
> "/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/subprocess.py",
> line 1821, in _execute_child
> raise child_exception_type(errno_num, err_msg, err_filename)
> FileNotFoundError: [Errno 2] No such file or directory: 'sudo'
> FAIL ftests.sh (exit status: 1)
>
> Could you check whether they can run at all without root
> privileges, and
> if not, document it in a comment above #:tests? #f?
unfortunately, tests are executed virtualized with lxc/lxd, while
technically it seems to be possible to execute them, but it will
require
fixing (but probably rewriting) python test runner code. Possible
but
not feasible i think.
On the other hand, as far as it is mentioned in their release
process,
sources release tarball is releaced after tests passing.
;; tests are virtualized with lxc/lxd, it is not very feasible
;; to make them executable under guix build
Will this commend do the work?
> Thanks,
> Ludo’.
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index e70d8d1a90..7eb309dfa5 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -8177,14 +8177,18 @@ (define-public libcgroup
> (uri (string-append home-page "/releases/download/v"
> version "/" name "-" version
> ".tar.gz"))
> (sha256
> - (base32
> "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf"))))
> + (base32
> "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf"))
> + (modules '((guix build utils)))
> + (snippet
> + ;; Delete the bundled copy of googletest, that even
> includes a .so.
> + '(delete-file-recursively "googletest"))))
> (build-system gnu-build-system)
> - (arguments
> - `(#:tests? #f))
> + ;; (arguments
> + ;; `(#:tests? #f))
> (native-inputs
> - (list bison flex))
> + (list bison flex python-wrapper))
> (inputs
> - (list linux-pam))
> + (list linux-pam googletest))
> (synopsis "Control groups management tools")
> (description "Control groups is Linux kernel method for
> process resource
> restriction, permission handling and more. This package
> provides userspace
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2022-08-09 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 15:29 [bug#56858] [PATCH] gnu: libcgroup: Update to 2.0.2 muradm
2022-07-31 21:48 ` ( via Guix-patches via
2022-08-01 5:42 ` muradm
2022-08-01 9:02 ` ( via Guix-patches via
2022-08-01 9:06 ` ( via Guix-patches via
2022-08-01 13:13 ` muradm
2022-08-09 15:37 ` Ludovic Courtès
2022-08-09 20:29 ` muradm [this message]
2022-08-23 21:10 ` [bug#56858] [PATCH v2] " muradm
2022-08-31 10:38 ` bug#56858: " Ludovic Courtès
2022-08-04 5:55 ` [bug#56858] [PATCH] " 宋文武 via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu6lxijz.fsf@muradm.net \
--to=mail@muradm.net \
--cc=56858@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=paren@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).