From: "Ludovic Courtès" <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 55080-done@debbugs.gnu.org
Subject: bug#55080: [PATCH shepherd] service: Gracefully handle non-existing log directories.
Date: Mon, 29 Aug 2022 17:18:58 +0200 [thread overview]
Message-ID: <87tu5v5b8d.fsf_-_@gnu.org> (raw)
In-Reply-To: <a23750234b68b0ed78a4a11da0b42994ed51a609.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 01 May 2022 15:50:25 +0200")
Hi Liliana,
Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
> Am Sonntag, dem 01.05.2022 um 15:32 +0200 schrieb Ludovic Courtès:
>> >
>> > > Did you encounter this issue while working on services?
>> > >
>> > > Am I right that the Shepherd 0.8 had the same problem?
>> > It might be, I don't know. I've encountered this for non-existing
>> > log directory, so a reproducer would be setting #:log-file to
>> > $test-tmp-directory/does-not-exist/log and check for each service.
>>
>> Usually /var/log and similar directories are created not by shepherd
>> but by Guix System, the distro being used, or whatever. That’s why I
>> wonder if it’s shepherd’s job to do that.
> Hmm, it might not be. Still, I wouldn't like shepherd to fail in such
> a weird manner if the log file can't be created.
I reread this thread and I concur. Patch finally pushed as
b0d3f625543bcb32e94167c27cba153f9fc03acd.
Thanks,
Ludo’.
prev parent reply other threads:[~2022-08-29 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 13:11 [bug#55080] [PATCH shepherd] service: Gracefully handle non-existing log directories Liliana Marie Prikler
2022-04-30 14:15 ` Ludovic Courtès
2022-04-30 14:26 ` Liliana Marie Prikler
2022-05-01 13:32 ` Ludovic Courtès
2022-05-01 13:50 ` Liliana Marie Prikler
2022-08-29 15:18 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu5v5b8d.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=55080-done@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).