From: Guillaume Le Vaillant <glv@posteo.net>
To: 51913-done@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>,
"Foo Chuan Wei" <chuanwei.foo@hotmail.com>
Subject: bug#51913: [PATCH] gnu: Add cl-binascii.
Date: Mon, 05 Sep 2022 12:09:52 +0000 [thread overview]
Message-ID: <87tu5m9g09.fsf@kitej> (raw)
In-Reply-To: <877dcc8rtr.fsf_-_@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
Ludovic Courtès <ludo@gnu.org> skribis:
> Ping! :-)
>
> Guillaume Le Vaillant <glv@posteo.net> skribis:
>
>> Foo Chuan Wei <chuanwei.foo@hotmail.com> skribis:
>>
>>> There are a few problems with this patch:
>>> * Tests are failing on ECL.
>>> * It bundles rt.lisp, which should be unbundled (use Guix's cl-rt
>>> instead).
>>
>> Concerning rt, I thing adding a snippet deleting "tests/rt.lisp" and
>> modifying the definition of "binascii-tests" in "binascii.asd" (removing
>> the references to the rt file and adding the rt system in the
>> "depends-on" list) should work.
I unbundled RT and pushed as 0f88acb9fa8f7bbdfb2a647907fe63b1974ab824
without the ecl-binascii variant, as it looks like the library doesn't
work with ECL.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
prev parent reply other threads:[~2022-09-05 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 5:40 [bug#51913] [PATCH] gnu: Add cl-binascii Foo Chuan Wei
2021-11-18 6:04 ` Foo Chuan Wei
2021-11-20 14:02 ` Guillaume Le Vaillant
2021-12-10 14:20 ` Ludovic Courtès
2022-09-05 12:09 ` Guillaume Le Vaillant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu5m9g09.fsf@kitej \
--to=glv@posteo.net \
--cc=51913-done@debbugs.gnu.org \
--cc=chuanwei.foo@hotmail.com \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).