unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Andrew Tropin <andrew@trop.in>
Cc: 58273@debbugs.gnu.org, aleksandr barakin <alex@barak.in>
Subject: [bug#58273] [PATCH] installer: checks the availability of the mirror
Date: Mon, 17 Oct 2022 09:39:34 +0200	[thread overview]
Message-ID: <87tu42nbk9.fsf_-_@gnu.org> (raw)
In-Reply-To: <87o7ub815u.fsf@trop.in> (Andrew Tropin's message of "Mon, 17 Oct 2022 09:33:17 +0400")


Hello Andrew,

>> +          (false-if-exception
>> +            (= (response-code
>> +                 (http-request "https://ci.guix.gnu.org"))
>> +               200))
>> +          (false-if-exception
>> +            (= (response-code
>> +                 (http-request "https://bordeaux.guix.gnu.org"))
>> +               200))))

Thanks for taking care of this patch. I think the following part could
be factorized:

(define (url-alive? url)
  (false-if-exception
   (= (response-code
       (http-request url))
      200)))

also, the indentation is wrong. Could you please fix it?

Thanks,

Mathieu




  reply	other threads:[~2022-10-17  7:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-03 13:55 [bug#58273] [PATCH] installer: checks the availability of the mirror aleksandr barakin
2022-10-05 10:39 ` [bug#58273] unwox via Guix-patches via
2022-10-14  5:55 ` [bug#58273] [PATCH] installer: checks the availability of the mirror Julien Lepiller
2022-10-17  5:33 ` Andrew Tropin
2022-10-17  7:39   ` Mathieu Othacehe [this message]
2022-10-17 12:51     ` Andrew Tropin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu42nbk9.fsf_-_@gnu.org \
    --to=othacehe@gnu.org \
    --cc=58273@debbugs.gnu.org \
    --cc=alex@barak.in \
    --cc=andrew@trop.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).