unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Sughosha <Sughosha@proton.me>
Cc: 58955@debbugs.gnu.org
Subject: [bug#58955] [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio
Date: Thu, 03 Nov 2022 18:27:48 +0100	[thread overview]
Message-ID: <87tu3gkktj.fsf@cbaines.net> (raw)
In-Reply-To: <1iy1gGLmq4QENuFNQ_0_KrSIcwZ6VL1WHMIRlmbaDs-1OAU8vbTqD139NyBUZaka27bxvFSBERpMqV_imzqOgMWsRFqWvOaMaC_Xs6Vva4k=@proton.me>

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]


Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/music.scm (pd): Update to 0.53-0.
> [arguments]: Unbundle oss and portaudio.
> [inputs]: Add portaudio.
> ---
>  gnu/packages/music.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Hey Sughosha,

I'm having a bit of trouble matching up the commit message with the
changes being made.

From the diff, it looks like oss is being disabled, rather than
unbundled. What's the reasoning behind disabling it?

Adding portaudio as an input seems fine I guess, but it might be good to
remove the portaudio files from the source (through a snippet) if there
are some there.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2022-11-03 17:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02  1:28 [bug#58955] [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio Sughosha via Guix-patches via
2022-11-03 17:27 ` Christopher Baines [this message]
2022-11-04 13:29   ` Sughosha via Guix-patches via
2023-01-29  6:56     ` bug#58955: " 宋文武 via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu3gkktj.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=58955@debbugs.gnu.org \
    --cc=Sughosha@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).