From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mF0JAVyZc2NzYwAAbAwnHQ (envelope-from ) for ; Tue, 15 Nov 2022 14:51:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ULLoAFyZc2ObNwEA9RJhRA (envelope-from ) for ; Tue, 15 Nov 2022 14:51:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A327129DD3 for ; Tue, 15 Nov 2022 14:51:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouwL0-0004mk-MF; Tue, 15 Nov 2022 08:50:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouwKB-0004ZN-3W for guix-patches@gnu.org; Tue, 15 Nov 2022 08:50:17 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouwKA-0007Ef-En for guix-patches@gnu.org; Tue, 15 Nov 2022 08:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouwKA-00031U-2n for guix-patches@gnu.org; Tue, 15 Nov 2022 08:50:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Nov 2022 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59253 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kyle Meyer Cc: 59253@debbugs.gnu.org, liliana.prikler@gmail.com, Thiago Jung Bauermann Received: via spool by 59253-submit@debbugs.gnu.org id=B59253.166852015311541 (code B ref 59253); Tue, 15 Nov 2022 13:50:02 +0000 Received: (at 59253) by debbugs.gnu.org; 15 Nov 2022 13:49:13 +0000 Received: from localhost ([127.0.0.1]:53495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouwJN-000303-36 for submit@debbugs.gnu.org; Tue, 15 Nov 2022 08:49:13 -0500 Received: from mail-qv1-f53.google.com ([209.85.219.53]:40639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouwJL-0002zo-2f for 59253@debbugs.gnu.org; Tue, 15 Nov 2022 08:49:11 -0500 Received: by mail-qv1-f53.google.com with SMTP id h10so9798043qvq.7 for <59253@debbugs.gnu.org>; Tue, 15 Nov 2022 05:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=yhih+W4s4/43fxbxKX2Ze5znD6ThyuyGXsK0ruXJKNg=; b=cAqoZ68Zw1G270euLLVuYiFLEoqz7i3Ztmr5/Dk6H0CktEmB3pHZpfYsYKU9UlqZ76 NmbaNnIaONzxmJcaSV+pRZw55uIw8ULxdSt4LyMOaE9V4XscYhF+4lty7L5FGrxZ7/Zj kxv8jomrouRrarTUcbnQoxKBwZ7FfLHu+4Huvf5DRsOiNPeWqAUxJXcdKNYOiVl7srwr RbAZKWVVi4ytmPjz0V3M5fD3klSSqOm4Py9vaG0EpJNHY8cxrl0S7S00YjptAu6lQhzk gC8quqMN2ue9/w9bR3EV1Orr5BHGJ1Dp9xju3rqpkLMP8IzSKTrvjTRysRDyoxtbOJk/ U2GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yhih+W4s4/43fxbxKX2Ze5znD6ThyuyGXsK0ruXJKNg=; b=NXjx5Hst4GO7wLZTH+7WhBEqRDjHvrZaIGhIXgGia5kzEQoCaz8IUZEAyTfR23Wra6 iz9Z3ZG5pWFeXOI0O7zCAIWRbja6F88qwbinK6HD9zG03CJXW13LtRpXATwM8s92YIrE tof+xUm+YIA83bUbU1pfzp0C2vbCJf01r/HI7NruDsNSuSnyyP/KDwW1tRC6INIBgQSd E4xGTXMkM/Vhv/PQTSBVhcotJVmAX5iFmP/Dwq6cRSQI/l6BC/PTMn/LYZfe65kCx1a5 HkwUOo501Qj8pKwtf8FYcLOBvZ0EMjI0QXjnJIWwsFCTLaQtMhlRlGEmQ65PM2tfUk9k IWGw== X-Gm-Message-State: ANoB5pnidI7LRfK2Qa/RW+EZ4xyhWTyjIPgsT/Rf4bNeaoGZHbqJKmlg Avm6rNKziJB/Tu8Q+x1HFm8kDlLD/Gw= X-Google-Smtp-Source: AA0mqf7lEvy9s7+giHPZXNdDqvgH9f9UCUmxPSw6j4oudvZONyeN+LnVofQIme6wZ3ozyEF1l5cX/Q== X-Received: by 2002:a05:6214:3706:b0:4bb:c66b:1c53 with SMTP id np6-20020a056214370600b004bbc66b1c53mr16582122qvb.30.1668520144390; Tue, 15 Nov 2022 05:49:04 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id z9-20020ae9c109000000b006ce76811a07sm7999751qki.75.2022.11.15.05.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:49:04 -0800 (PST) From: Maxim Cournoyer References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> <87r0y6pkac.fsf@kolabnow.com> <87y1seqlwm.fsf@gmail.com> <87h6z2p6jc.fsf@kolabnow.com> <87cz9pvy23.fsf@kyleam.com> Date: Tue, 15 Nov 2022 08:49:02 -0500 In-Reply-To: <87cz9pvy23.fsf@kyleam.com> (Kyle Meyer's message of "Mon, 14 Nov 2022 19:52:36 -0500") Message-ID: <87tu30pbu9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668520283; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yhih+W4s4/43fxbxKX2Ze5znD6ThyuyGXsK0ruXJKNg=; b=okKTgwvXZNB6rCgkIk7tlyLT6gEcxgBtbzaYhqJAxK6L9GyeeLthhG/H1TJeQ8v8JzmypU F1somd8DYOm2Euq5WhWB34CE/RXnkHkB9s6X9jgcGBu7idURRGKerjED/8NcR8z8l9GvtP Wi94XEl/3A1Cgkk4ODdj7zRcsQvwXkog2HBJ1SZhn3ssHQNhkRPkMdy1vG5hqiFDLx2XEM IvI3qaU6Q0DIi9h0pyTlip1iNeJCdSvwYdl6/0VTflwJ1/L8/Ion/MuLNFSbSicv63bh7A peb81JNKCapUaNldMIJrxTlLbBoZatrPnLK7Lnx/+jS4OC9CUohId4QmS5+g1A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668520283; a=rsa-sha256; cv=none; b=mYSgJ0UGq4a3eQOhF9eMy+tTayQmyNFcwmMNx9l3rHWbLdkpLIxc4Utu1Trp8fSN5PNAyA /HrBp2px0SraOJSzYsIanXErW+OBEEIHy+cVthxsf7Crp9iGftddcoosAwN6ds7yDSegkM DoflyHeL12du7SZdYbWFBbJqLN1BRY6k1e9Dl+LKpmyCFnV7asMPIKGJ4BmRA7UbEEHqf+ 740MazS5vKrzn3TYN2EBS/H8UR2xuqVwBjnMLseCBkfxqwpFiDLDnbZvXw2s21JQc6Bug5 05Z4fm8HVLv3k53pXhEA07nVqjKGEhFe6b2mDytPU4IRURTJsR/IEg0Gmtjt/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=cAqoZ68Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.56 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=cAqoZ68Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A327129DD3 X-Spam-Score: 5.56 X-Migadu-Scanner: scn0.migadu.com X-TUID: l/KSuOmYmJ9W Hi, Kyle Meyer writes: > Thiago Jung Bauermann via Guix-patches via writes: > >> Maxim Cournoyer writes: > [...] >>> Won't this make magit unusable from TRAMP (which already seems broken >>> for me since the time we enabled native comp -- anyone else?). >> >> Hm, interesting point. I don't know. I don't use TRAMP because it was >> too slow for me in the couple of times I've tried. >> >> magit/lisp/magit-git.el does have this custom variable though, which >> this patch didn't change: >> >> #+BEGIN_SRC elisp >> (defcustom magit-remote-git-executable "git" >> "The Git executable used by Magit on remote machines. >> On the local host `magit-git-executable' is used instead. >> Consider customizing `tramp-remote-path' instead of this >> option." >> :package-version '(magit . "3.2.0") >> :group 'magit-process >> :type 'string) >> #+END_SRC elisp >> >> So I'd say it's possible that my patch doesn't affect whether Magit >> works from TRAMP=E2=80=A6 > > That's right. magit-remote-git-executable is the executable that will > be used when operating remotely via TRAMP, so your patch shouldn't > affect it (and if it does, it's unintended behavior on Magit's end). > > Note that, as the :package-version value suggests, this split happened > in a relatively recent release, so previous some previous discussions on > the list (e.g., bug#30434) are now out of date. Excellent. Thanks for the explanation! --=20 Thanks, Maxim