unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: jgart <jgart@dismail.de>
Cc: 59327-done@debbugs.gnu.org, 59327@debbugs.gnu.org
Subject: [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input.
Date: Tue, 22 Nov 2022 09:38:06 +0000	[thread overview]
Message-ID: <87tu2rs4zs.fsf@cbaines.net> (raw)
In-Reply-To: <20221121083822.GE10366@dismail.de>

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]


jgart <jgart@dismail.de> writes:

> On Mon, 21 Nov 2022 08:34:50 -0600 jgart <jgart@dismail.de> wrote:
>> I'll check later today and report back.
>
> Oh, that test just passes an empty list if numpy is not available:
>
> https://github.com/inducer/pudb/blob/v2022.1.3/test/test_var_view.py#L32
>
> Do we want to run that test with our packaged numpy on [np.float32(5),
> np.zeros(5)]?

That seems fine to me, I've tweaked the commit message to describe it as
an "optional test dependency", rather than "missing". and pushed to
master as eda5e9aaafeacc0e21dbf43200d79b91fc1e38ed.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2022-11-22  9:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  1:48 [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input jgart via Guix-patches via
2022-11-21 12:10 ` Christopher Baines
2022-11-21 14:34   ` jgart via Guix-patches via
2022-11-21 14:38     ` jgart via Guix-patches via
2022-11-22  9:38       ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu2rs4zs.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=59327-done@debbugs.gnu.org \
    --cc=59327@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).