From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gKRwKesMoGS5gAAASxT56A (envelope-from ) for ; Sat, 01 Jul 2023 13:24:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WIhaKesMoGSY5gAA9RJhRA (envelope-from ) for ; Sat, 01 Jul 2023 13:24:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6BAF41CFB9 for ; Sat, 1 Jul 2023 13:24:27 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1688210667; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=6kJeerRosRnM6pNQU9YGWTde3yoY6BlaO6avGhvCkSw=; b=eEP0X7iD9sSFdhKT2vfoc8BaSwHNKDE3aZkmW91dV6MeTZ9IJ1ZdpBkGbroHhd1KIg+dQJ w74JtSoJb0CQTo9B9i0N+daEYYADdvn50stFmM8yq10K6CgvZwh7zayrm4pD4gS8FPwfzc H1dfLXL5LhdvgG1oxRTKnN5tyGWwcu86PmH1wSuaqXsWQ43O96Tv+8Dvi663Vv6a+P0nde ruuZoW1rUytfaW7YVLPTmiLkbouEQGco6VDWdjR1Ffnvj3FyIZ2wTAxfBqqKKCrxaNP4ZT tCMLgBUh0js5JHy1DZdhaCkpHQl9U5hwgOo90UpA7TN8EVtp/GJ805rufSynoA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1688210667; a=rsa-sha256; cv=none; b=rFSfpV1eCseTDLML1YuqjzDMFEKIF1aFg/uIq/7t5faucfpxaIxq+pgknCgvdSsLo1Nhkl GuJoktaEC0ak+5/m0/3u1e5pBTHGrcwaYjjbCUVSQSKBiz8N45P6+Eh/ft6T+QQSml+Q4Q iKCcADjWKBPefQldCCJne83yo5c0x8ASWtfABG65zjLzzhdhGcHWBongYS1FW5wcNOiayo 8vWdRUw7cWWnH9v0oGqpf/Mk6btmhEjtOh0lWB1DBnte/eB27C+wYktKBcsv8ua5sPQjQo ScKuSkxZWr5As18gMOjQo+YP2i52u9pWhVkphfe/vpH7PGcRXFy6xoZL1kTf9A== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFYhv-0003v2-C6; Sat, 01 Jul 2023 07:24:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFYht-0003uH-W5 for guix-patches@gnu.org; Sat, 01 Jul 2023 07:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFYht-0006lh-Na for guix-patches@gnu.org; Sat, 01 Jul 2023 07:24:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qFYht-0004Wq-Ja for guix-patches@gnu.org; Sat, 01 Jul 2023 07:24:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63801] [PATCH] gnu: Add yle-dl Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 01 Jul 2023 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63801 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63801@debbugs.gnu.org Cc: Saku Laesvuori , 63801-done@debbugs.gnu.org X-Debbugs-Original-To: Saku Laesvuori via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.168821059417087 (code B ref -1); Sat, 01 Jul 2023 11:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Jul 2023 11:23:14 +0000 Received: from localhost ([127.0.0.1]:56806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFYh8-0004RX-7t for submit@debbugs.gnu.org; Sat, 01 Jul 2023 07:23:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:41860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFYh6-0004RQ-IH for submit@debbugs.gnu.org; Sat, 01 Jul 2023 07:23:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFYh4-0003cl-4x for guix-patches@gnu.org; Sat, 01 Jul 2023 07:23:11 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFYh2-0006Zq-6d for guix-patches@gnu.org; Sat, 01 Jul 2023 07:23:09 -0400 X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id B136160002; Sat, 1 Jul 2023 11:22:57 +0000 (UTC) From: Nicolas Goaziou References: <20230530092254.16603-1-saku@laesvuori.fi> Date: Sat, 01 Jul 2023 13:22:48 +0200 In-Reply-To: <20230530092254.16603-1-saku@laesvuori.fi> (Saku Laesvuori via Guix-patches via's message of "Tue, 30 May 2023 12:22:54 +0300") Message-ID: <87ttunj2pj.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4b98:dc4:8::223; envelope-from=mail@nicolasgoaziou.fr; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.96 X-Spam-Score: -2.96 X-Migadu-Queue-Id: 6BAF41CFB9 X-TUID: rdEr2O5Lr0JO Hello, Saku Laesvuori via Guix-patches via writes: > * gnu/packages/video.scm (yle-dl): New variable. Applied with the changes below. Thank you. > * gnu/packages/video.scm: Import (gnu packages python-build). This information is not necessary in the commit message. > +(define-public yle-dl > + (package Indentation is off. You may want to run "guix style" command prior to sending a patch (I don't, but I'm opinionated about indentation) > + (name "yle-dl") > + (version "20221231") > + (source (origin > + ;; PyPI release doesn't include tests > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/aajanki/yle-dl.git") We usually remove ".git" suffix from URL. > + (commit "c2a4d2f3926056496f520e289334d345889b51c4"))) We don't use raw hash commits there. The project tags its releases, so it should be: (commit version) > + (add-after 'wrap 'wrap-path > + (lambda _ > + (wrap-program (string-append #$output "/bin/yle-dl") > + `("PATH" = (,(string-append #$ffmpeg "/bin") > + ,(string-append #$wget "/bin")))))) "#$ffmpeg" and "#$wget" would prevent package transformations. You should prefer, e.g., (string-append #$(this-package-input "ffmpeg") "/bin") Regards, -- Nicolas Goaziou