unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 65883@debbugs.gnu.org
Subject: [bug#65883] [PATCH] .dir-locals.el: Update bug-reference configuration and document it.
Date: Wed, 13 Sep 2023 23:20:56 -0400	[thread overview]
Message-ID: <87ttrxtp7r.fsf@gmail.com> (raw)
In-Reply-To: <87msxpke73.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 13 Sep 2023 22:31:28 +0200")

Hi,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> (nil) <bug-reference-url-format>: Update URL.  Add comment.
>> * doc/contributing.texi (The Perfect Setup): New "Viewing bugs within Emacs"
>> subsection.
>
> [...]
>
>> +     ;; For use with 'bug-reference-prog-mode'.  Extra bug-reference
>> +     ;; configuration should be done in your Emacs user configuration file;
>> +     ;; refer to (info (guix) The Perfect Setup).
>
> Nitpick: (info "(guix) The Perfect Setup“), so one can C-x C-e it.  :-)

Neat!  I was wondering what's the trick to get them turn into links in
Emacs.

>>       (bug-reference-bug-regexp
>>        . "\\(<https?://\\bugs\\.gnu\\.org/\\([0-9]+\\)>\\)")
>
> Should we add issues.guix here?

No, because issues.guix ones are already URLs, opened in a browser.  For
Emacs users who prefer to have them open in Debbugs, that's what the
documented debbugs-browse-url-regexp is for.

>
> [...]
>
>> +(setq bug-reference-bug-regexp
>> +      (concat
>> +       "\\("
>> +       "\\(?:\\b\\(?:[Bb]ug ?#?\\|[Pp]atch ?#\\|[Ff]ixes:? ?#\\|\
>
> I second Brian’s suggestion to use ‘rx’.

That looks nicer indeed.  Will review it soon.

> Other than that, I think it’s wonderful, well done!

Thanks!

-- 
Maxim




  reply	other threads:[~2023-09-14  3:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12  3:44 [bug#65883] [PATCH] .dir-locals.el: Update bug-reference configuration and document it Maxim Cournoyer
2023-09-12 14:20 ` brian via Guix-patches via
2023-09-12 14:34 ` brian via Guix-patches via
2023-09-17 20:45   ` bug#65883: " Maxim Cournoyer
2023-09-13 20:31 ` [bug#65883] " Ludovic Courtès
2023-09-14  3:20   ` Maxim Cournoyer [this message]
2023-09-19  8:08 ` Simon Tournier
2023-09-20 15:28   ` Maxim Cournoyer
2023-09-20 15:39     ` Simon Tournier
2023-09-25 16:13       ` Maxim Cournoyer
2023-09-25 16:24         ` Simon Tournier
2023-09-25 17:27           ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttrxtp7r.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=65883@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).