From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OIEzMbIIE2W0LAEA9RJhRA:P1 (envelope-from ) for ; Tue, 26 Sep 2023 18:37:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OIEzMbIIE2W0LAEA9RJhRA (envelope-from ) for ; Tue, 26 Sep 2023 18:37:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AC0189CA3 for ; Tue, 26 Sep 2023 18:37:06 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fgFuZQSo; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695746226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=iBh9TUkll7dpNnz6uC2XweKwsIBqHOawqqdnwjtiuFQ=; b=FJ2LBNUOcc3EzVyyBOJ/MLLdHjkuYFKCFLZx4Nsix7HSlN5MGA1GZQ9MxiDwOlOGR18Csp tKOQHvqrGTOX+u4TKhNCNRgzbl70YmaStpaOvDpaKiOIxnT01Rnuzv+CTI8pNmlQPNOkVh 6Th1JFWW+rVauYN3YFBIkqy4ST8QqgxXmAzUU7XfDXiyA4xD/UsujAVjgKvyAdcSi2O8Jt z2mUe8tF8SpopTbWpJQWcmirL4uOv8Ke5B9nyOuKau/YLun56ImH/TRoIoksXhL6+tMzWV zh504GizyEdRJMQZJ+9R4GI3NMV2mW9selTBYxDLAnnijjSh9CwltvoRQK6vNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695746226; a=rsa-sha256; cv=none; b=dmkjpAT1Qkx79K+bs1Uyo8eAAc2NsbYX0i1JAkXsiigzGYCK2+S6BWCHKjkMBTAXbm6H/j oDKOHpD3kCq3NGP8DQfXpIdoNDu+d1H/xcBYqBmX2JcfLKlzAqpDh7jHI6YniRyF6B4xDv qEMh6ob/jWqL7OtVvR8XVTzxeAsEHubrm8GOawAz2IxCAwBLVX8Ea8eGQpr7J3Isx/sTKK q/iQP1bVw8d7XZKo0amUjZBJcPUqbM0Q14YkYkb41sypxV6psMdU5Wzw2uSJ+0EJ+gvF24 ti22B60T0tk6mEaLqAW+ekw+YUS8a/6FlEugwwScwnj+zfWYd921/a3WLwZ1ug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fgFuZQSo; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlB3M-0006LR-Tv; Tue, 26 Sep 2023 12:36:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlB3K-0006J4-3E for guix-patches@gnu.org; Tue, 26 Sep 2023 12:36:50 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qlB3J-0000wt-Qx for guix-patches@gnu.org; Tue, 26 Sep 2023 12:36:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qlB3V-0001dY-Ka for guix-patches@gnu.org; Tue, 26 Sep 2023 12:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66171] [PATCH] gnu: git: Install shell completions. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Sep 2023 16:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66171 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 66171@debbugs.gnu.org, Simon Tournier Received: via spool by 66171-submit@debbugs.gnu.org id=B66171.16957461946256 (code B ref 66171); Tue, 26 Sep 2023 16:37:01 +0000 Received: (at 66171) by debbugs.gnu.org; 26 Sep 2023 16:36:34 +0000 Received: from localhost ([127.0.0.1]:49632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlB34-0001cq-Hc for submit@debbugs.gnu.org; Tue, 26 Sep 2023 12:36:34 -0400 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]:50189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlB30-0001ca-2b for 66171@debbugs.gnu.org; Tue, 26 Sep 2023 12:36:33 -0400 Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-7741bffd123so537973885a.0 for <66171@debbugs.gnu.org>; Tue, 26 Sep 2023 09:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695746171; x=1696350971; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=iBh9TUkll7dpNnz6uC2XweKwsIBqHOawqqdnwjtiuFQ=; b=fgFuZQSoq1LFZrkAjtHaA8sZ88MNZFsnTRb8BC851/UzyzxtpOx4Y+b2HYuMKuUNd2 jNFcM2Kc4iOTngo7Er3UGuIRclg2vuhIbqW8sp+kuVitFu5bcDgoj69WlsiboRqbLfrB Y6a8BJVsCuTPu01xblpM9gnLtah+1+p1LY3kngNi7OtZoPj9V77Ro9F+iVx2ESkV/ipy 7S2C8f2Z13Y588eACviBYrVrisKwJ/19NBOY7Sh9lAfUuBBKBRAuEh2lu76jjF8Bnmpt i3CTGegM+gpnnA1TPaVSh5N15hhqn4KEMGGfAtwliKcsSx/DXcTZB3tdQmN8fJSrMBeE 2OEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695746171; x=1696350971; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iBh9TUkll7dpNnz6uC2XweKwsIBqHOawqqdnwjtiuFQ=; b=nMy3wHmDoM08Ixh6VeFh6MV1IWcCL1xQOP6srLM4edtONVOI5lnWQsRDNVQsYtx0Pr PF3Rybvs1qylSs3ILU5eh89mg4invGor7EXGqAv4kMgkLZwYkJZ6Kb1eJkBxue48PAd2 loCXAdseRu4AGl9XE2jv2tnulC9UcFjlPzPeU1f8t8xtO5uFcQ0LaPAhT+27VrM96pSg rlO1ZHt4kwzkNKm0TbGkCI1moP8J/k96XjomRqvj6euJ6dOimhOZx3k+4/VyPYzWQsX5 NOYi0AsKZzaGL7pzN0gBn2E6RxVneRLyUH1VQMzjZJ/93B0ay2YdhbJX+h7g/hwNs45e H84A== X-Gm-Message-State: AOJu0Yw/rNcSNDWpZnXw751Au77Lron+KF9yNT0MxMLUKZQM4GaObih7 /Q8gTE1C1hlysyMJVlNhn2kW4SjfzxM= X-Google-Smtp-Source: AGHT+IF1JRvQtbj+zg2IIsD75JcQdLow4/TqLG7PeCaVNIOqfEMkFB0PgP6kN6vCtdFytZn136wREA== X-Received: by 2002:a05:620a:4593:b0:774:220c:154f with SMTP id bp19-20020a05620a459300b00774220c154fmr13604586qkb.42.1695746171284; Tue, 26 Sep 2023 09:36:11 -0700 (PDT) Received: from hurd (dsl-10-130-229.b2b2c.ca. [72.10.130.229]) by smtp.gmail.com with ESMTPSA id p22-20020ac87416000000b00419576c7b75sm350625qtq.23.2023.09.26.09.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 09:36:10 -0700 (PDT) From: Maxim Cournoyer References: <7be0975a4d30362dec08c3115e68c992e58ab549.1695660890.git.liliana.prikler@gmail.com> <877coe2lap.fsf_-_@gmail.com> <7659d2d5a891bb3ee81e87ab484924f3337cae81.camel@gmail.com> Date: Tue, 26 Sep 2023 12:36:09 -0400 In-Reply-To: <7659d2d5a891bb3ee81e87ab484924f3337cae81.camel@gmail.com> (Liliana Marie Prikler's message of "Mon, 25 Sep 2023 20:41:05 +0200") Message-ID: <87ttrgzybq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -5.14 X-Spam-Score: -5.14 X-Migadu-Queue-Id: AC0189CA3 X-TUID: 0shnIeRQZneN Hi, Liliana Marie Prikler writes: > Am Montag, dem 25.09.2023 um 13:51 -0400 schrieb Maxim Cournoyer: >> Hello, >>=20 >> Liliana Marie Prikler writes: >>=20 >> > * gnu/packages/version-control.scm (git)[outputs]: Add >> > =E2=80=9Ccompletion=E2=80=9D. >> > [#:phases]: Add =E2=80=98install-completion=E2=80=99. >> > (git-minimal)[#:phases]: Adjust accordingly. >>=20 >> Did something change in git?=C2=A0 I've always had completion in git, so >> I'm not sure what this extra phase does, or when it's useful?=C2=A0 Does >> it add *extra* completion or... ? > Which shell are you using? If it's zsh, then the completion is baked > in. If it's bash, idk, I haven't tried. I personally use this for the > included git-prompt, which allows me to have my prompt look like the > following: > > \u@\h /path/to/guix [$branch env] ($SHLVL) \$ I see. I use Bash. > >> Also, a completion output seems a bit over the top.=C2=A0 I doubt its >> weigh justifies the annoyance of special casing it. > I special-cased it because it *is* a contrib script, but also as it > might be able to conflict with whatever shell builtins you have. Now > it isn't particularly likely to do so given that other distros include > it as part of their git-core, but I prefer safe over sorry. Ah, if it's just a contrib I guess a dedicated output is fine, although i'd perhaps call such output 'contrib', as completions seem to imply that without it there are no auto-completion support, which is clearly not the case, at least for Bash. --=20 Thanks, Maxim