From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: "Nguyễn Gia Phong" <mcsinyx@disroot.org>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
64222@debbugs.gnu.org, 50035@debbugs.gnu.org,
"Sarah Morgensen" <iskarian@mgsn.dev>
Subject: [bug#50035] bug#64222: [PATCH 0/4] Add senpai IRC client
Date: Thu, 12 Oct 2023 17:53:34 +0000 [thread overview]
Message-ID: <87ttqv7mnb.fsf_-_@protonmail.com> (raw)
In-Reply-To: <5d1fcc896c0f6f63e1664f0eadabf73f0965110b.1628823527.git.iskarian@mgsn.dev>
Hi Ludo’ and Nguyễn (and cc'ing Sarah from earlier patches),
On Fri, Oct 13, 2023 at 01:16 AM, Nguyễn Gia Phong wrote:
> On 2023-10-12 at 17:12+02:00, Ludovic Courtès wrote:
>> <https://qa.guix.gnu.org/issue/64222> was inconclusive
>> (for some reason it had not built all the dependents)
>
> qa.guix.gnu.org was briefly broken at the time IIRC,
> happened to other adjacent patchsets.
>
> On 2023-10-12 at 17:12+02:00, Ludovic Courtès wrote:
>> so I checked locally and the go-github-com-godbus-dbus upgrade
>> does not introduce new breakage.
>>
I haven't checked but this might need some fixing as based on an earlier
patch for updating godbus (I can't help but read this as "god bus") the
import name has changed. Though as an example chezmoi seems to have been
broken for some time anyway. Maybe the import-name doesn't need the v5?
See
<https://issues.guix.gnu.org/50035>
and
<https://issues.guix.gnu.org/50037>.
The earlier patch also has fixes for the tests which would be good to
include now.
My apologies to Sarah as my original replies way back when only went to
the bug number (we should document this, easy beginner mistake!) and
once I became a committer this was on my list to update and push but I
didn't get around to it.
Nguyễn and/or Sarah would you like to submit a patch to change the
import path if needed, enable tests, and make any other changes? I could
also take a look if no one gets to it quickly.
>> I wrapped the long ‘description’ lines, removed ‘Signed-off-by’ tags
>> from the logs (they’re for committers), and committed.
>
> Thanks a lot!
Thanks to all on this updates!
John
PS: Looks like one extra signed-off-by tag made it through on a commit.
Oh well, glad I'm not the only one who's not perfect at these things!
next prev parent reply other threads:[~2023-10-12 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 3:06 [bug#50035] [PATCH 1/3] gnu: go-github-com-godbus-dbus: Update to 5.0.4 Sarah Morgensen
2021-08-13 3:12 ` [bug#50035] [PATCH 2/3] gnu: Rename go-github-com-godbus-dbus to go-github-com-godbus-dbus-v5 Sarah Morgensen
2021-08-13 3:12 ` [bug#50035] [PATCH 3/3] gnu: go-github-com-godbus-dbus-v5: Fix and enable tests Sarah Morgensen
2021-08-13 19:12 ` [bug#50035] [PATCH 1/3] gnu: go-github-com-godbus-dbus: Update to 5.0.4 John Kehayias via Guix-patches via
2022-02-04 20:06 ` John Kehayias via Guix-patches via
2023-10-12 17:53 ` John Kehayias via Guix-patches via [this message]
2023-10-13 4:52 ` [bug#64222] gnu: go-github-com-godbus-dbus-v5 guix-patches--- via
2024-09-03 10:10 ` bug#50035: [PATCH 1/3] gnu: go-github-com-godbus-dbus: Update to 5.0.4 Sharlatan Hellseher via Guix-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttqv7mnb.fsf_-_@protonmail.com \
--to=guix-patches@gnu.org \
--cc=50035@debbugs.gnu.org \
--cc=64222@debbugs.gnu.org \
--cc=iskarian@mgsn.dev \
--cc=john.kehayias@protonmail.com \
--cc=ludo@gnu.org \
--cc=mcsinyx@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).