unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: Zheng Junjie <zhengjunjie@iscas.ac.cn>
Cc: 67903@debbugs.gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>,
	Leo Famulari <leo@famulari.name>
Subject: [bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0.
Date: Sat, 13 Jan 2024 16:04:31 +0800	[thread overview]
Message-ID: <87ttnh4q28.wl-hako@ultrarare.space> (raw)
In-Reply-To: <87jzoomiho.fsf@iscas.ac.cn>

Hi,

On Fri, 05 Jan 2024 13:45:36 +0800,
Zheng Junjie wrote:
>
> Hilton Chain <hako@ultrarare.space> writes:
> >
> > On Sun, 24 Dec 2023 13:27:13 +0800,
> > 郑俊杰 wrote:
> >>
> >> > 在 2023年12月19日,22:51,Hilton Chain 写道:
> >> >
> >> > * gnu/packages/linux.scm (libcgroup): Update to 3.1.0.
> >> > [arguments]<#:configure-flags>: Disable systemd.
> >> >
> >> > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5
> >> > ---
> >> > gnu/packages/linux.scm | 7 ++++---
> >> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >> >
> >> > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> >> > index 3ca756dead..c4c366e21f 100644
> >> > --- a/gnu/packages/linux.scm
> >> > +++ b/gnu/packages/linux.scm
> >> > @@ -8798,7 +8798,7 @@ (define-public fbgrab
> >> > (define-public libcgroup
> >> >   (package
> >> >     (name "libcgroup")
> >> > -    (version "2.0.2")
> >> > +    (version "3.1.0")
> >> >     (home-page "https://github.com/libcgroup/libcgroup")
> >> >     (source
> >> >      (origin
> >> > @@ -8806,14 +8806,15 @@ (define-public libcgroup
> >> >        (uri (string-append home-page "/releases/download/v"
> >> >                            version "/" name "-" version ".tar.gz"))
> >>
> >> Can we switch to git-fetch?
> >
> > Is there any good reason?
>
> if use git-fetch, allow `guix build libcgroup
> --with-{branch,commit,git-url} ...` work.


Yes, that makes sense, but we still have ‘--with-version’, right?  It seems that
libcgroup's release tarball is created by ‘make dist’ and for this specific case
these options are of less use, I'd prefer not switching to git-fetch.

Thanks




  reply	other threads:[~2024-01-13  8:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19 14:21 [bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0 Hilton Chain via Guix-patches via
2023-12-24  5:27 ` 郑俊杰
2024-01-05  5:24   ` Hilton Chain via Guix-patches via
2024-01-05  5:45     ` Zheng Junjie
2024-01-13  8:04       ` Hilton Chain via Guix-patches via [this message]
2024-01-13  8:08 ` [bug#67903] [PATCH v2 1/2] gnu: libcgroup: Adjust package style Hilton Chain via Guix-patches via
2024-01-13  8:08   ` [bug#67903] [PATCH v2 2/2] gnu: libcgroup: Update to 3.1.0 Hilton Chain via Guix-patches via
2024-01-25 16:37     ` bug#67903: " Hilton Chain via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttnh4q28.wl-hako@ultrarare.space \
    --to=guix-patches@gnu.org \
    --cc=67903@debbugs.gnu.org \
    --cc=hako@ultrarare.space \
    --cc=leo@famulari.name \
    --cc=me@tobias.gr \
    --cc=zhengjunjie@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).