From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id wLKBOOxF3WXwDAAAe85BDQ:P1 (envelope-from ) for ; Tue, 27 Feb 2024 03:16:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id wLKBOOxF3WXwDAAAe85BDQ (envelope-from ) for ; Tue, 27 Feb 2024 03:16:13 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=p1mdNA23; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709000172; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=+HfwPiOPj36QPe/v+x49202UhGG0lrBl9IzMxDHsudQ=; b=reu+KsoOMZxPpve9oXSDZlaYJBftfuZNk/rvJji0ciyEGkwcDP7bvGlay2zKDOsOLKluo0 R6Yv4+uLJGepX/o92hXCh6NZnzrKz08VYXkgx8UI7Q98HBd9x7wTdgUnKsNBMLO4vvpZMs 2uEA3jqL1wlhr+hGtiEdWAKDgS6I70HOEkiR8aMLXpCTcDrGil3ZfjDvGEaI+ix2iYZDYC Num9p1hnSWqo2C7e7nLAHlzLV0UB0PznPGWaNW66exC51qvOE9hg9+Nc2uKMGir+p1ZQq/ WABARQ/BQTs87ZuIz8mrx+pd9/i2NXTUF3wSidVjLjfMvCeKDdTOG2dCmWfjRw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=p1mdNA23; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709000172; a=rsa-sha256; cv=none; b=pBtQ6ixmsWku7QcBa7yZ3PLkIH6KrrptP/+GkjPt4VUb45lXgwiuJidbMg5RgbaixXz4IQ WtageoAMiTl6RM3eQP8YaW7jEvfHh9Jq/2PS2zaAvPkD2DpWDjC2bZmW8rGerUhSPbKKYE 6gnpMQcU9y09csqpqFXS7vNGosYHb+YZjMtn8hLVuH0ulPljDssNug8a3ZmzZM6NhiYeU0 oGps6t3XMhByXzy7tlKWg2MPs+AJyAM4Lzt28fBRFSXdOfzWeANjFVlyFzoWBOimQIRJiH WVVR/l6YgHUMI3CHUG9u091/nGeyLk2WT06afeRab4enD2uyO6+Nmj/A15tfKQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB85922E8C for ; Tue, 27 Feb 2024 03:16:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ren0Y-0007iW-Ak; Mon, 26 Feb 2024 21:15:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ren0L-0007fc-69 for guix-patches@gnu.org; Mon, 26 Feb 2024 21:15:37 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ren0K-0008Mv-U7 for guix-patches@gnu.org; Mon, 26 Feb 2024 21:15:36 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ren0k-00064B-6U for guix-patches@gnu.org; Mon, 26 Feb 2024 21:16:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68250] [PATCH v2] gnu: mpv: Fix pkgconfig file. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Feb 2024 02:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68250 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Lars-Dominik Braun , Zheng Junjie , Josselin Poiret , Andrew Tropin , jgart , Marius Bakke Received: via spool by 68250-submit@debbugs.gnu.org id=B68250.170900010123091 (code B ref 68250); Tue, 27 Feb 2024 02:16:02 +0000 Received: (at 68250) by debbugs.gnu.org; 27 Feb 2024 02:15:01 +0000 Received: from localhost ([127.0.0.1]:33334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1remzl-00060C-21 for submit@debbugs.gnu.org; Mon, 26 Feb 2024 21:15:01 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:43112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1remzj-0005zx-Gr for 68250@debbugs.gnu.org; Mon, 26 Feb 2024 21:15:00 -0500 Date: Tue, 27 Feb 2024 09:31:36 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1709000054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+HfwPiOPj36QPe/v+x49202UhGG0lrBl9IzMxDHsudQ=; b=p1mdNA23VDI8ao0jesXeda3xDUlE3baGsfEZuyB4ZxtSqKwM7+yDaSh9vfLYkCN7sgqPm1 vgEVYY9AuyuZK7n911n/fqwmQhAf50hG/ArqsFFU+c3LYiBdlWFGB0VRNHzkGh+mHVk2Fs xnDkBnPNVzKC2YPeSuyOQXReSiRSID9piFt+NA5mkBR/SOkVcaVgAPtMbSPWxr9zPs0eES rcfKB8w13VKq0ntzQ92QipklhuPNObnE0RDnjdHXfZtZCvg74GXD02rK5LK6E7CLBzBZ7m X4BuRDkK06E+hqIJx+tlf3gwiC6kLkKxjVe4OMtbjYRXdNYDD/7zK4lZdW7bag== Message-ID: <87ttlu3d6v.wl-hako@ultrarare.space> In-Reply-To: <87cysjkyec.fsf_-_@gmail.com> References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> <8734uukrgq.fsf_-_@gmail.com> <87o7d04w1k.wl-hako@ultrarare.space> <87cyta66sr.fsf@gmail.com> <87cysjkyec.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: ++ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -3.41 X-Spam-Score: -3.41 X-Migadu-Queue-Id: BB85922E8C X-TUID: XR7xmYElcBhP Hi Maxim, On Tue, 27 Feb 2024 00:01:31 +0800, Maxim Cournoyer wrote: > > Hi Hilton, > > Maxim Cournoyer writes: > > > Hi Hilton, > > > > [...] > > > >>> I've just seen this, after pushing a hot fix as > >>> f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed > >>> libraries in Requires.private. > >>> > >>> I suppose that someone wanting to build something statically from mpv > >>> would benefit from having the original mpv.pc file without > >>> modifications. > >>> > >>> Perhaps we can try it out for a bit, and if the propagation causes > >>> problems, we can fall-back to this change here? > >> > >> > >> Then we should follow the approach in v1 to add libmpv as a separate package. > >> I'll send v3 later. > > > > Actually I don't think we need to split out a library for mpv here; > > there are two things we can do in the short term: > > > > 1. Build MPV strictly as a shared library (-Dbuild=shared) or something > > in Meson. Then Meson doesn't output all these Requires.private > > dependencies, which are only useful for static linking, and which > > pkg-config confusingly uses for its --exists check. > > > > 2. On core-updates, I've been experimenting with replacing pkg-config > > with pkgconf, which seems to be designed better for avoiding the above > > pkg-config's pitfall. Currently stuck on a hard to understand cycle. > > I've implemented 2. above; see: , > which removes the need to propagate pkg-config *.private fields, which > should only be needed when doing static builds. > > I'm thus closing this issue. Let me know if I've missed anything! Great to see! Thank you very much!