unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: 69579@debbugs.gnu.org
Cc: ngraves@ngraves.fr
Subject: [bug#69579] [PATCH] gnu: python-joblib: Update to 1.3.2.
Date: Fri, 08 Mar 2024 12:29:41 -0800	[thread overview]
Message-ID: <87ttlgbh6y.fsf@wireframe> (raw)
In-Reply-To: <20240306093803.4725-1-ngraves@ngraves.fr>

[-- Attachment #1: Type: text/plain, Size: 3848 bytes --]

On 2024-03-06, Nicolas Graves wrote:
> * gnu/packages/python-xyz.scm (python-joblib): Update to 1.3.2.
> [build-system]: Update to pyproject-build-system.
> [arguments]
>   <#:phases>: Remove check phase.
>   <#:test-flags>: Keep former test flag.
> [propagated-inputs]: Add python-psutil.
>
> Change-Id: Ide110a19431b1d26e1d7dd8d1adc3b3f0f417749
> ---
>  gnu/packages/python-xyz.scm | 22 ++++++++--------------
>  1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 46232d3c98..122dca6e4e 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -6169,26 +6169,20 @@ (define-public python-pystitcher
>  (define-public python-joblib
>    (package
>      (name "python-joblib")
> -    (version "1.1.1")
> +    (version "1.3.2")
>      (source (origin
>                (method url-fetch)
>                (uri (pypi-uri "joblib" version))
>                (sha256
>                 (base32
> -                "0019p280s2k941mihl67l7y6amwx86639xp3zvpsg1lmyish67rh"))))
> -    (build-system python-build-system)
> +                "1cbjjzsh9hzaqr2cqja95673p7j88b8bd02hjpkq8xz147k6by4j"))))
> +    (build-system pyproject-build-system)
>      (arguments
> -     `(#:phases
> -       (modify-phases %standard-phases
> -         (replace 'check
> -           (lambda* (#:key tests? #:allow-other-keys)
> -             (when tests?
> -               (setenv "JOBLIB_MULTIPROCESSING" "0")
> -               (invoke "pytest" "-v" "joblib"
> -                       ;; We disable this test to avoid having to depend on ipython/jupyter
> -                       "-k" "not test_parallel_call_cached_function_defined_in_jupyter")))))))
> -    (native-inputs
> -     (list python-pytest))
> +     (list
> +      #:test-flags  ; disabled to avoid having to depend on ipython/jupyter
> +      #~(list "-k" "not test_parallel_call_cached_function_defined_in_jupyter")))
> +    (native-inputs (list python-pytest))
> +    (propagated-inputs (list python-psutil))
>      (home-page "https://joblib.readthedocs.io/")
>      (synopsis "Using Python functions as pipeline jobs")
>      (description
> -- 
> 2.41.0

I did a local test build, and tried to build the moderately large list
of dependents (~90 if I recall), which seems to fix some builds and
introduces some new failures, and some still fail in both cases...

with python-joblib 1.3.2 patch:

guix build: error: build of
`/gnu/store/1f7fjigxbran1bn1lwvy4v7vfdfz09rj-python-pingouin-0.5.2.drv',
`/gnu/store/4g2r98m4d5zkwvlgghdqgvnda8p5b8lf-tadbit-1.0.1-1.5c4c1dd.drv',
`/gnu/store/8gkvizln2kjpdjn4m89vws9xpj3f62dw-python-scikit-allel-1.3.5.drv',
`/gnu/store/cm2dr4npm0bn9w7xiyrfizcq097laibw-python-pyts-0.13.0.drv',
`/gnu/store/h5l1cymbzrz2havw6ygn0gafxwvf5k9m-python-matplotlib-documentation-3.8.2.drv',
`/gnu/store/ijg5hbhwj3h89bzh0n9l8zrg595bnscz-python-openturns-1.21.3.drv',
`/gnu/store/n0f7flida4sag8ifsvmczg4r33r07ry8-python-pytorch-geometric-2.4.0.drv',
`/gnu/store/yl5rndzgfprfr0lpcrhdwmvix61zyccr-python-poliastro-0.17.0.drv'
failed

without python-joblib 1.3.2 patch:

guix build: error: build of
`/gnu/store/rhd4p3n7ih0apdbqn552dvgf67ljmj5s-python-pingouin-0.5.2.drv',
`/gnu/store/mdcf9g773mz96397fpy7hbhj624svdai-python-scikit-allel-1.3.5.drv',
`/gnu/store/7b2px2nkw02i62zbc8izh5wlc08bvpp3-python-matplotlib-documentation-3.5.2.drv',
`/gnu/store/36hdl27cw8gb9s7alf3ginmqk40lzjzm-python-xgboost-1.5.2.drv',
`/gnu/store/jja4pvcnsxd63mb6jxlilkyjjf0a524m-python-hicexplorer-3.7.2.drv',
`/gnu/store/mqzg965f7qhiz1rk93yqlq5p6p93h30j-python-episcanpy-0.4.0.drv',
`/gnu/store/r4bx6mx0bkhk25zq4g91wma0s5ll016q-python-multivelo-0.1.2.drv',
`/gnu/store/wrpm94hkilphkznif8nzan8gblaflrqp-python-ikarus-0.0.2.drv' failed

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2024-03-08 20:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06  9:38 [bug#69579] [PATCH] gnu: python-joblib: Update to 1.3.2 Nicolas Graves via Guix-patches via
2024-03-08 20:29 ` Vagrant Cascadian [this message]
2024-03-08 22:20   ` Nicolas Graves via Guix-patches via
2024-03-13  6:46   ` Nicolas Graves via Guix-patches via
2024-03-13 12:39     ` Christopher Baines
2024-03-13 13:16       ` Nicolas Graves via Guix-patches via
2024-03-15 19:15         ` Nicolas Graves via Guix-patches via
2024-03-16 12:08           ` Christopher Baines
2024-03-20 17:45             ` bug#69579: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttlgbh6y.fsf@wireframe \
    --to=vagrant@debian.org \
    --cc=69579@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).