From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
Vagrant Cascadian <vagrant@debian.org>,
Richard Sent <richard@freakingpenguin.com>,
71022@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>,
Florian Pelz <pelzflorian@pelzflorian.de>,
Ricardo Wurmus <rekado@elephly.net>,
Andreas Enge <andreas@enge.fr>,
Attila Lendvai <attila@lendvai.name>,
Matthew Trzcinski <matt@excalamus.com>,
Janneke Nieuwenhuizen <janneke@gnu.org>
Subject: [bug#71022] [PATCH] configure.ac: Set default value for the 'prefix' variable.
Date: Sun, 19 May 2024 16:16:10 +0200 [thread overview]
Message-ID: <87ttit3n11.fsf@gnu.org> (raw)
In-Reply-To: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Fri, 17 May 2024 19:52:33 -0400")
Hi Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> The Guix standard configuration uses a localstatedir of /var and a sysconfdir
> of /etc. To ease things for everyone, make the default values match that
> standard expected configuration. See
> <https://lists.gnu.org/archive/html/guix-devel/2024-05/msg00003.html> for a
> related discussion.
>
> * configure.ac: Default $prefix to '' unless already set.
> * doc/contributing.texi (Building from Git): Streamline doc.
> * doc/guix-cookbook.texi (Guix environment via direnv): Likewise.
>
> Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212
[...]
> +dnl Set some sane default directory variables for use with the Guix. This
> +dnl also causes localstatedir to be /var and sysconfdir to be /etc.
> +test "$prefix" = NONE && prefix=
Shouldn’t it read “prefix=/”?
Might be good to check whether this breaks “make distcheck”, so I
suppose it should be fine.
Apart from that it LGTM. Thanks for this patch!
Ludo’.
next prev parent reply other threads:[~2024-05-19 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 23:52 [bug#71022] [PATCH] configure.ac: Set default value for the 'prefix' variable Maxim Cournoyer
2024-05-19 10:42 ` Ricardo Wurmus
2024-05-22 0:16 ` Maxim Cournoyer
2024-05-19 14:16 ` Ludovic Courtès [this message]
2024-05-22 12:30 ` Maxim Cournoyer
2024-05-23 9:17 ` Ludovic Courtès
2024-05-22 0:24 ` Maxim Cournoyer
2024-05-22 12:51 ` [bug#71022] [PATCH v2] " Maxim Cournoyer
2024-05-23 9:17 ` Ludovic Courtès
2024-05-26 3:38 ` bug#71022: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttit3n11.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=71022@debbugs.gnu.org \
--cc=andreas@enge.fr \
--cc=attila@lendvai.name \
--cc=efraim@flashner.co.il \
--cc=janneke@gnu.org \
--cc=matt@excalamus.com \
--cc=maxim.cournoyer@gmail.com \
--cc=pelzflorian@pelzflorian.de \
--cc=rekado@elephly.net \
--cc=richard@freakingpenguin.com \
--cc=vagrant@debian.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).