From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id CMllGfBAWWYtjAAAqHPOHw:P1 (envelope-from ) for ; Fri, 31 May 2024 05:16:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id CMllGfBAWWYtjAAAqHPOHw (envelope-from ) for ; Fri, 31 May 2024 05:16:00 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Ei6uUhe1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717125360; a=rsa-sha256; cv=none; b=NX3O5HdvS+yEv6kwc/j5AHcolpQUl9DHmh/QN7FC2DqEIbWvEMdjHhLtn18UPc90N2fouH 4QmlEDhhLs4RVPy/w1h5LPROIYNTHxtxnTiaFCOCmXlveN21zP5rSCYNcO0NCAHqc1T1pH Xu0ZOtOnNXJtdRz4/3kvFGhnmkNEg+7/BM3FiCsPaOgpnunUkOQBk0Fs7k9RdeXrdcwuid AB89KbnTROo8P9Cj8ucCMnXYTUBsaf8R1xvHMbpera2F+g7bnpR/QJEhZoM1jTvpqEsQ5i y70BkDWQ9k0dGfkOiSQlE6ZhuYsRMyUDalChRh+GPNvFZMBYJT4sjeEnhcAsiw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Ei6uUhe1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717125360; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=PzTwhzW2cJmKtcqwQWZ7tTFM2gwiiTePl6Mj66y7kH4=; b=p6E7fTiKpnrmu14kcjDtWsm6F0wszdHA5l89NV3CtUh2ynpnh9haL6IY2Q/Jcchtl5vMLK vYkO5th8pf5p7dzP2538cbpVNikytsY70+KEtTYYBXgyZXlbCXueQzo5W0ozA8jhpYFBjn gF1fRULAA8vykbzygLtRKXC0zSO4B+vOd7Ng+ghmQrh5nOUwXkYvUqMeB4R5TfKmx/iwpV 7vMlTa0CU3NCH39hJcnSoouyBQWif58EOJmxOSImKg9qATtGOQmdz9mJ6JkwyrgfABHnVg lRW5ja6tBTPiuCCIZOm0lwo6M5Yg/lxrx6e7KR8T82FbITrISpJs9M5eQayiRw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32ABA19FBE for ; Fri, 31 May 2024 05:16:00 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCskD-0004yK-GZ; Thu, 30 May 2024 23:15:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCskC-0004xz-Ex for guix-patches@gnu.org; Thu, 30 May 2024 23:15:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sCskC-00082u-3I for guix-patches@gnu.org; Thu, 30 May 2024 23:15:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sCskM-0002ff-JB for guix-patches@gnu.org; Thu, 30 May 2024 23:16:02 -0400 Subject: bug#68718: [PATCH v2] gnu: elfutils: Move inputs to propagated-inputs. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 31 May 2024 03:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68718 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: odion@efficios.com Cc: Olivier Dion , 68718-done@debbugs.gnu.org Mail-Followup-To: 68718@debbugs.gnu.org, maxim.cournoyer@gmail.com, olivier.dion@polymtl.ca Received: via spool by 68718-done@debbugs.gnu.org id=D68718.171712531810207 (code D ref 68718); Fri, 31 May 2024 03:16:02 +0000 Received: (at 68718-done) by debbugs.gnu.org; 31 May 2024 03:15:18 +0000 Received: from localhost ([127.0.0.1]:52903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCsje-0002eZ-1e for submit@debbugs.gnu.org; Thu, 30 May 2024 23:15:18 -0400 Received: from mail-qv1-f43.google.com ([209.85.219.43]:52375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCsjZ-0002eH-OD for 68718-done@debbugs.gnu.org; Thu, 30 May 2024 23:15:17 -0400 Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6ae84d0cd2eso2086246d6.0 for <68718-done@debbugs.gnu.org>; Thu, 30 May 2024 20:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717125236; x=1717730036; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PzTwhzW2cJmKtcqwQWZ7tTFM2gwiiTePl6Mj66y7kH4=; b=Ei6uUhe1b7TEssKky7hdLcl6p8hsyxDcnV8AbOHqDz0hqz27ymoU4VbnP9cWiqqflZ NREdW/IgldnBowyuO00fBOAzZWjN/5bcEWu+cj8UrqAaHszT2AIWauiO4FApkySgG/H7 RlvU1NLpXSeB/Mx9RhCRImjEjNrlLUDFdYQ/I02WK54sAOj1HF7wJOLlwtKjByicfdVF KGI/gPQPImv+X2a5oi72QAq3fP+y2S4ccR4AN8T/RdAQzZzEqYqhElMP6aXiAIl1mIWy Llg+FSP3MqNWTO0Fpb1n2gjOtQ6z1byIN6F/zSIYyAE8lYBDzjETw4HCB1RSlAlAtLmv 1+/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717125236; x=1717730036; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PzTwhzW2cJmKtcqwQWZ7tTFM2gwiiTePl6Mj66y7kH4=; b=FSwQ7O13n1jlsFtUubDCTocGnehxlF99nuxg/z3hIWQwo5QcPddiyC9AR6j6XR39X6 JEIMORpLQSWsSxtSki5q+XDTmAwEr6lgmCf2RIAmRdevai9+r2ODMxdRS+z/5Mh/408P Gp4XP4eB3wQNTCE9s9qHA0BPAt/ammtzme+NdRKaywoqTQ1Hq11t3g/Q/xvhtvFRZB4j 7f+oy2qSq5vvlbcuwE7wqe6NLtaZOXhR/1RmAjLqLMP62nlKClPbUNWXgw5zUn1P2LsM iHkFCKEGgJNL0t5rcEIxs5Bn45FTkAXaGU1HWMDO1GG8VnlSCzPv4lHJgAgb1m+3Sq1W To0Q== X-Forwarded-Encrypted: i=1; AJvYcCVJflco7XrRBQbW8+oyHRQCtuh0qNrXkceX/VvLDnCJlrHZsv8ahyzTU9E2ptspEzJmxzw/ierx0Gfmw4iiASPKtDeJE6/LmvEWsA== X-Gm-Message-State: AOJu0YyNkgkkFnJD1hK61/PXbRpQ7jwhLjigGu58iow4F4VdofirJRI/ OCCfbJ98OQs5VZcsMw8LQaNk6904HME6H4D1RO28iwXjnaEbCFVzV0gjMg== X-Google-Smtp-Source: AGHT+IEX3udCj8cE62rWHi9XJRblK6h9p8Mn5wLPWL6nDUMH3Kj/m5pG/lo8Wca7dstWidwCReuKMw== X-Received: by 2002:a05:6214:3209:b0:6a0:c339:1ede with SMTP id 6a1803df08f44-6aecd6ef0dfmr7387976d6.40.1717125236009; Thu, 30 May 2024 20:13:56 -0700 (PDT) Received: from hurd (dsl-205-233-124-92.b2b2c.ca. [205.233.124.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ae4b418d5csm3480676d6.106.2024.05.30.20.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 20:13:55 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (odion@efficios.com's message of "Thu, 30 May 2024 12:09:13 -0400") References: <874jafe7j3.fsf@gmail.com> Date: Thu, 30 May 2024 23:13:53 -0400 Message-ID: <87ttied66m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 32ABA19FBE X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: 2.65 X-Spam-Score: 2.65 X-TUID: I6/Doxk7veBi Hi, odion@efficios.com writes: > From: Olivier Dion > > zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'. > Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the xz > and zlib packages must be propagated for pkg-config to work on libdw and > libelf. > > * gnu/packages/elf.scm (elfutils): Move packages ... > [inputs]: ... from here ... > [propagated-inputs]: ... to here. I've reworded the GNU ChangeLog part like: * gnu/packages/elf.scm (elfutils) [inputs]: Turn into... [propagated-inputs]: ... this field. > Change-Id: Ic89d226b2392fe821b207302d3b386f9633b981a > --- > gnu/packages/elf.scm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm > index a100038f14..484f8dfc2c 100644 > --- a/gnu/packages/elf.scm > +++ b/gnu/packages/elf.scm > @@ -138,7 +138,11 @@ (define-public elfutils > '())))) > > (native-inputs (list m4)) > - (inputs (list xz zlib)) > + ;; zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'. > + ;; Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the > + ;; xz and zlib packages must be propagated for pkg-config to work on libdw > + ;; and libelf. > + (propagated-inputs (list xz zlib)) And simplified this to: (propagated-inputs (list xz zlib)) ;in Requires of libdw.pc, libelf.pc and... Actually, these are in 'Requires.private', which ought to be only useful for static compilation (though these would be consulted for Cflags since there's no Cflags.private in pkg-config). pkgconf handles this better than pkg-config, letting you do without propagation here, as long as the libs are found in a standard include path and you are building a shared library. I think with the planned switch to pkgconf, we probably should avoid propagation here unless really necessary; do you have a failing example at hand? -- Maxim