From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id SEgfN3h6cWayQwAAqHPOHw:P1 (envelope-from ) for ; Tue, 18 Jun 2024 12:15:53 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id SEgfN3h6cWayQwAAqHPOHw (envelope-from ) for ; Tue, 18 Jun 2024 14:15:53 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=RMIN6KuR; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718712805; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=aHwIkidhlSokjK9D4RF5yCwpwIxPfy+KqLvyM4uJDpo=; b=I7VGeda6J5OebYYNRhj2Nb+LF4vB0+WHpRpANjS0jpnul6V0jVC61XvqEDEdfj+Zuu7TTX QTpuyVYtpO08OIt9FfJw5H1wfmARbyzLqhq9uG/Y75S07wB75aASk4E2PjFVmU70uGIdnw W2uxvMF3IpJQOc9gvyu4eH1mL7VySE1Dmdy7htMXyOmWV3kro2wIrUF86dmcVV4laUE78u ghIbRDVy8xVdcKSWxF8b7LOpQpuDkDH8d4k8s+SIzXy7s5KziDI70ulvapbKDdQuJmvIgM owZOBYbz1kc8/4xlSbgHbYVikB4X/YefA4Ta20+aZr09YdViEDwn8t6pE8JJwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=RMIN6KuR; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718712805; a=rsa-sha256; cv=none; b=tOswDXWVEt5o/PfAXbF7a0fma5zjj3Ko5ZxXZ6vqmkNekBMP+5i/kEBvsiUbQzG6tP7oKJ MUbljMnfDEQV6AvO8tOkwbXneFgeLfAPmWaAg1TLvbo8pFA6mYJndzEziT9lREqOKwXfbL QAxUHJE+oKkH2jb+lMjQKSJ4ubIIHhkWkxOZQTptLIX+93YZo9fT0tnOeyuYvde4DAZWkL jVxCnqoeytwitGlizaThwSJ9E8OQPE68ek7V/6XfH0bD7FLkJGilDxG7C3KNmUrKkxvMWT 6a8D4e7ykdCVB9/uAdAtQvDSxVgxpOjxvXxM2ekEXLrDpd1kFhvgb8alXMmLNQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC7D227821 for ; Tue, 18 Jun 2024 14:13:24 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJXhu-0007Dn-8b; Tue, 18 Jun 2024 08:13:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJXhs-0007DG-7h for guix-patches@gnu.org; Tue, 18 Jun 2024 08:13:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJXhr-0008GG-VM for guix-patches@gnu.org; Tue, 18 Jun 2024 08:12:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJXhu-00016h-Am for guix-patches@gnu.org; Tue, 18 Jun 2024 08:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71371] [PATCH v2] gnu: svn-fetch: Allow specifying revisions as strings. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jun 2024 12:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71371 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 71371@debbugs.gnu.org, Josselin Poiret , Simon Tournier , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Florian Pelz , Christopher Baines , Matthew Trzcinski Received: via spool by 71371-submit@debbugs.gnu.org id=B71371.17187127414203 (code B ref 71371); Tue, 18 Jun 2024 12:13:02 +0000 Received: (at 71371) by debbugs.gnu.org; 18 Jun 2024 12:12:21 +0000 Received: from localhost ([127.0.0.1]:42124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJXhF-00015j-DV for submit@debbugs.gnu.org; Tue, 18 Jun 2024 08:12:21 -0400 Received: from mail-qt1-f182.google.com ([209.85.160.182]:43149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJXhB-00015T-11 for 71371@debbugs.gnu.org; Tue, 18 Jun 2024 08:12:20 -0400 Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4421c014b95so31322621cf.0 for <71371@debbugs.gnu.org>; Tue, 18 Jun 2024 05:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718712669; x=1719317469; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aHwIkidhlSokjK9D4RF5yCwpwIxPfy+KqLvyM4uJDpo=; b=RMIN6KuRY5LjxmsQS0uPYkf339hf7tOeGWHMby1YiRheIUzTrn6QjLs9LPJZYuXfYB Bb28HUjyuWRUhLB4rm5cOGx0N/525cymWYrU6cesUmPyfjcz2yfspaKgkvw6k0l0+k9u T9JofexO2vp9vLta4GUxIOscomsLO90msqeFpkwwqtdkGWpb24DuI1eL+RoKw1J1aDMw 1+MCig4LOsbojc+LbcydGvQoPd2hoBwisYaabjnfFtypNm3CovLPFCR0MyIkuNbVYyc8 4+DlhFkzpHvZsAV1q4uhOR3/6Hjx5KQE9rQb2jD7sj6XVuGGaAf93xtFcRpqfi9Tekac ur2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718712669; x=1719317469; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aHwIkidhlSokjK9D4RF5yCwpwIxPfy+KqLvyM4uJDpo=; b=rl5Tk+LmK+qywWkKc5+qSySA3Mq+DVXrnU9EwmhxqZr1LIzZEJ68GQVvvn+wa2YIoL t3YfETiCbPx+WPQX4yEjGHHbmjkOjV00HQRQTSjsXopM1fiThiRhYqIHA2cVPyQE5KYj CbNfYr/34/ufRVlnuS8E/we0Jb7jXENdjBuoV6bFft3FgHVOlxWB8YnayoJVMvaeqoPU OKRJuy53IgWcjvGxOzWL2yjd0AhUpiyfAjGP0e9bS+6VRL8vv2wIN7k/1tlAT+IQTIbB ze9WTL7OAspFoQMtlWRgfRVPW2VOazAopNJOK4WBiU4hFzX7wLhgJTqdgDut8Hd+Ykg7 uWWw== X-Gm-Message-State: AOJu0Yz48iPoWYNVq5aDeumecwULSyUJ2rH9dtwz1u1wG+XHkPTYgwd2 epnQL2IuN3Io8J5mIf1c3fHAFaP3luOCqDA23wTROqJAuF0T/oXG X-Google-Smtp-Source: AGHT+IGprZ5ezGhh29y6HmeDzuaLuq29g7tkXhMt8uruhmatlY7HlCGiQFgv4xSGIV+YZlcG7bD91w== X-Received: by 2002:a05:622a:1a8b:b0:440:57ca:5b6b with SMTP id d75a77b69052e-4449bb37ca4mr43442451cf.18.1718712668680; Tue, 18 Jun 2024 05:11:08 -0700 (PDT) Received: from hurd (dsl-152-211.b2b2c.ca. [66.158.152.211]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4421aafcf49sm44700611cf.37.2024.06.18.05.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 05:11:08 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <4885bc5c95529991846db147ca58f7445d3cd864.1718699410.git.mail@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 18 Jun 2024 10:30:10 +0200") References: <4885bc5c95529991846db147ca58f7445d3cd864.1718699410.git.mail@nicolasgoaziou.fr> Date: Tue, 18 Jun 2024 08:11:06 -0400 Message-ID: <87tthqe9id.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 4.14 X-Migadu-Queue-Id: CC7D227821 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 4.14 X-TUID: c5E+dVHXIZAR Hello, Nicolas Goaziou writes: > * guix/svn-download.scm (): > (svn-fetch): > (svn-multi-fetch): > * guix/build/svn.scm (svn-fetch): Revision can also be a string, not only > a number. > * doc/guix.texi (origin Reference): Document changes about REVISION field. > > Change-Id: Ibb17b539575fdf3daf895bd1ce39a40dd9b495cb > --- > v2: No longer ignore "-r" argument. Instead, allow strings, such as "HEAD". Yes, in practice, it means this relies on the tag being stable, which is the same assumption as for, e.g., tarballs. WDYT? While it may be useful to point to volatile references such as HEAD for internal projects (like I believe is also possible for our git fetcher) or the likes (with a hash of #f for example), I wouldn't like to see this used in the Guix tree (I'd consider it a bad practice). I'm not against merging this, but I think we should add a 'guix lint' rule that'd warn that some SVN reference should be specified if it wasn't. Does that sound reasonable? -- Thanks, Maxim