unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Zheng Junjie <zhengjunjie@iscas.ac.cn>
To: 72338@debbugs.gnu.org
Cc: me@fabionatali.com
Subject: [bug#72338] [PATCH] gnu: readymedia: Add coreutils to dependencies.
Date: Tue, 30 Jul 2024 13:17:34 +0800	[thread overview]
Message-ID: <87ttg7zcep.fsf@iscas.ac.cn> (raw)
In-Reply-To: <9b857352fd100cf73aef76cd4a2e82333301d31c.1722177963.git.me@fabionatali.com> (Fabio Natali via Guix-patches via's message of "Sun, 28 Jul 2024 16:20:30 +0100")

[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]

Fabio Natali via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/upnp.scm (readymedia)[inputs]: Add coreutils.
>
> Change-Id: I8f73802bd0d8fecbf5ee20853eccefc2eef82411
> ---
> Hi,
>
> This is to add coreutils to ReadyMedia/MiniDLNA's dependencies. Without
> coreutils (and the 'rm' command in particular) some ReadyMedia operations would
> otherwise fail.
>
> Thanks, cheers, Fabio.
>
>  gnu/packages/upnp.scm | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
> index aab68a6414..17605d3b96 100644
> --- a/gnu/packages/upnp.scm
> +++ b/gnu/packages/upnp.scm
> @@ -26,6 +26,7 @@
>  (define-module (gnu packages upnp)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages base)
>    #:use-module (gnu packages check)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages curl)
> @@ -154,12 +155,17 @@ (define-public readymedia
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'patch-source
> -           (lambda _
> +           (lambda* (#:key inputs #:allow-other-keys)
>               (substitute* "Makefile.am"
> -               ((".*LIBAVUTIL_LIBS.*") "")))))))
> +               ((".*LIBAVUTIL_LIBS.*") ""))
> +             (substitute* "minidlna.c"
> +               (("rm -rf")
> +                (string-append
> +                 (assoc-ref inputs "coreutils") "/bin/rm -rf"))))))))

use (string-append (search-input-file inputs "/bin/rm") " -rf")

>      (native-inputs (list autoconf automake gettext-minimal))
>      (inputs
> -     (list ffmpeg
> +     (list coreutils

please use coreutils-minimal

> +           ffmpeg
>             flac
>             libexif
>             libid3tag
>
> base-commit: 46a64c7fdd057283063aae6df058579bb07c4b6a

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2024-07-30  5:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-28 15:20 [bug#72338] [PATCH] gnu: readymedia: Add coreutils to dependencies Fabio Natali via Guix-patches via
2024-07-30  5:17 ` Zheng Junjie [this message]
2024-07-30 10:58 ` Fabio Natali via Guix-patches via
2024-08-01 15:55   ` bug#72338: " Z572
2024-08-01 16:54     ` [bug#72338] " Fabio Natali via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttg7zcep.fsf@iscas.ac.cn \
    --to=zhengjunjie@iscas.ac.cn \
    --cc=72338@debbugs.gnu.org \
    --cc=me@fabionatali.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).