From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id uF0zEWSaFmcbCgAAqHPOHw:P1 (envelope-from ) for ; Mon, 21 Oct 2024 18:16:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id uF0zEWSaFmcbCgAAqHPOHw (envelope-from ) for ; Mon, 21 Oct 2024 20:16:04 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bFeG0jAS; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ym+tGqWF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729534563; a=rsa-sha256; cv=none; b=u2yDjtek4BTW1sZ4H9b3MF63yo/Ta4XPAG1VYKazsNmuvQTWetRsZh95EyHtcCobMmTkL0 iWfhgJ8u172bc7DU1In9Dob0D+9TiTv6xZbHzbvR66C1MEMJVZAIquio9UzXAeSgPrc5Aa lY0PKc8mOiI809uiQ6ZIkQRzC+cV0THMtd6WT+vfUYA6+Yy+/mdf1vSoN8FRnd2InZGfXp dlJQutMwcIe08KWr5qVxoznVzZSuLdU7bEHJE95ki4kwqU+PWEasKhtH0IjkmYAOrsPHhy o2wVKKqUZhnHISricQKKLOAdfvEBWlb/tvyQssAGnvO6zM6pm9zR8xUptZQNkg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bFeG0jAS; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ym+tGqWF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729534563; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=FRL6OkiIHRMCvfsjGVUnuylpLVJWToUle8X9lBC3+y4=; b=ADCV754CEwmA9L76EF5hevzPhAHkumZk3MfZv/FBoNDT2aHgvpB4PpWCbHJer7hlrcKr5A MFHBP2S7+12NMckFlsIrDYoks7kQCSJQkG0cPwdl1oRDXpPGzinZgxgG0zvK4K5xLq5qO4 aIWbZCt6CeEafauPdGVusxBvI1o4gtr01c1rwRXS0Itd92uWzC24qbJutH2JECpOw5nBvX Obl5SLt17GEl/79EP3GHvCKOeSf+nsCDxfB8P64PkWztCY5ou6wGpgDsqqseZZxHtPWin4 mSzq5p50xa81pnDT9spRPSW7hfdfQO2bhYecljUl+A1cSzH00QvIj8sP+dmO2A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AEF7E8DA0B for ; Mon, 21 Oct 2024 20:16:03 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2wwT-00071O-9P; Mon, 21 Oct 2024 14:15:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2wwL-000706-1y for guix-patches@gnu.org; Mon, 21 Oct 2024 14:15:43 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2wwJ-0000hq-Ar for guix-patches@gnu.org; Mon, 21 Oct 2024 14:15:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=FRL6OkiIHRMCvfsjGVUnuylpLVJWToUle8X9lBC3+y4=; b=bFeG0jASwM70u55VT/j7bwcl3HkC3b9KO7l0UhDwQMKCh9Ft6mE5+agk1+nmNBTONTLLS2AhtxA2tRaUqa1AI/+9av30SsX2FvnYbibWeBuHxTmywH2aAzGkJUbHwAhUoN2WMI3lWDqf0xSVFCksUfoAewR1DYwejqkl2Wz35BCoFHeGIEal+qWe0hAHuGC7EKnKnccYCgbRv7PQ0Y/teJjPmCS7Df6csnUxYH5yLDmhZ8vFQqfiRyvmOepyI3Q0OgV4Eui5HS//3U13mr7OgPll33HpH0PsCo46+B7ehxuHEd78h+DTVXTyAVViOkttC5WcxyD3ZPgLholKvPnDIA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2wwk-0006ol-0f for guix-patches@gnu.org; Mon, 21 Oct 2024 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73927] [PATCH 14/16] installer: Add "Kernel" page to select the Hurd. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Oct 2024 18:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73927 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Janneke Nieuwenhuizen Cc: 73927@debbugs.gnu.org, Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 73927-submit@debbugs.gnu.org id=B73927.172953450625763 (code B ref 73927); Mon, 21 Oct 2024 18:16:01 +0000 Received: (at 73927) by debbugs.gnu.org; 21 Oct 2024 18:15:06 +0000 Received: from localhost ([127.0.0.1]:53296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2wvq-0006hT-Es for submit@debbugs.gnu.org; Mon, 21 Oct 2024 14:15:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2wvo-0006gU-2p for 73927@debbugs.gnu.org; Mon, 21 Oct 2024 14:15:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2wvH-0000S5-JB; Mon, 21 Oct 2024 14:14:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=FRL6OkiIHRMCvfsjGVUnuylpLVJWToUle8X9lBC3+y4=; b=Ym+tGqWFCZHEWVtjaqmZ XVHXvpBfV7vXaJM9wcmFyg86YakcyGRAuz9XOnCVUqRYUnFXs+TRcJhfxj+ZXdc9MCCknNFkGohJv 2ewLzhUYdhC09RNrh+GkXzNuCSkeA5O0V5WWRgFUX2PWHvdJ/NLzNVTg4aPKErQ2FE8f5bJ4Pz8fN C4ZSJTnNfSGmkMHW8+ryGDITShW04ZPC8ExoKUli10UcfIUa3qJ3b4Y6sopiNEU/UpqU3JmtCZaGY JLzkKfuwYvi7rVPXk/9Rj9WEd8hdmWG1jjXtm9gNPY93Hjpshtoh2PK+f/6cYyxO1YSY/NjlWbGmi 7+LyNX+aqpdVOQ==; From: Mathieu Othacehe In-Reply-To: (Janneke Nieuwenhuizen's message of "Mon, 21 Oct 2024 10:17:10 +0200") References: Date: Mon, 21 Oct 2024 20:14:24 +0200 Message-ID: <87ttd5cohr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 0.30 X-Spam-Score: 0.30 X-Migadu-Queue-Id: AEF7E8DA0B X-Migadu-Scanner: mx12.migadu.com X-TUID: 9E02+rO/DACP Hello Janneke, Really great to see that extension to the installer :) The installer patches look OK to me, I will try to test them on real hardware soon. > Change-Id: I15d535a7a8a917e5f3492f8c01d922d652c32ee5 > > geert none > > Change-Id: Ib6c5665638018f59a2690f603fad0702e042fb8b > > Change-Id: I01b854390240be60ce9fef8c9510a90bc6843ef3 > > geert > > Change-Id: Ibb7205443969fc92d4fe62d4dfb4f956d03229b9 ^ Maybe something to cleanup? > + ;; Ask the user to select the kernel for the system, > + ;; for x86 systems only. > + (installer-step > + (id 'kernel) > + (description (G_ "Kernel")) > + (compute (lambda _ > + (if (target-x86?) > + ((installer-kernel-page current-installer)) > + '()))) > + (configuration-formatter (lambda (result) > + (kernel->configuration result #$dry-run?)))) > + If I remember correctly, new installer steps require some adaptations in the (gnu installer tests) module. Is make check-system TESTS="gui-installed-os" working correctly? Thanks, Mathieu