unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Zheng Junjie <zhengjunjie@iscas.ac.cn>
Cc: 73981@debbugs.gnu.org
Subject: [bug#73981] [PATCH 1/4] gnu: libmbim: Update to 1.30.0.
Date: Mon, 11 Nov 2024 23:22:19 +0900	[thread overview]
Message-ID: <87ttcd97fo.fsf@gmail.com> (raw)
In-Reply-To: <d0915580877a8c1fb18160fca6515f63cbc8154a.1729755152.git.zhengjunjie@iscas.ac.cn> (Zheng Junjie's message of "Thu, 24 Oct 2024 15:40:36 +0800")

Hi Zheng,

Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:

Apologies, it seems I've duplicated your work in my just submitted
#74306!  Some comments below.

> * gnu/packages/freedesktop.scm (libmbim): Update to 1.30.0.
> [source]: Switch to git-fetch.
> [build-system]: Switch to meson-build-system.
> [native-inputs]: Add gobject-introspection, bash-completion, help2man. Replace
> python-wrapper with python-minimal.
>
> Change-Id: I607bff667a057e58bebb2f706d7021a4d1c8d763
> ---
>  gnu/packages/freedesktop.scm | 21 +++++++++++++--------
>  1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index 0ab0bb51044..a7c740f3d05 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -1900,19 +1900,24 @@ (define-public accountsservice
>  (define-public libmbim
>    (package
>      (name "libmbim")
> -    (version "1.26.4")
> +    (version "1.30.0")
>      (source (origin
> -              (method url-fetch)
> -              (uri (string-append
> -                    "https://www.freedesktop.org/software/libmbim/"
> -                    "libmbim-" version ".tar.xz"))
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitlab.freedesktop.org/mobile-broadband/libmbim")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
>                (sha256
>                 (base32
> -                "1ncaarl4lgc7i52rwz50yq701wk2rr478cjybxbifsjqqk2cx27n"))))
> -    (build-system gnu-build-system)
> +                "00kbjvpka51zrfjigzd3rk6r4x8hkg1xfj7d9zl9lccysnxyjx5h"))))
> +    (build-system meson-build-system)
>      (native-inputs
>       (list `(,glib "bin") ; for glib-mkenums
> -           pkg-config python-wrapper))
> +           pkg-config
> +           python-minimal
> +           gobject-introspection
> +           bash-completion
> +           help2man))

Here it would be nice to keep the inputs sorted alphabetically.
Shouldn't bash-completion be an 'input' instead of a 'native-input' ?

-- 
Thanks,
Maxim




  reply	other threads:[~2024-11-11 14:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24  7:36 [bug#73981] [PATCH 0/4] gnu: update modem-manager and deps Zheng Junjie
2024-10-24  7:40 ` [bug#73981] [PATCH 1/4] gnu: libmbim: Update to 1.30.0 Zheng Junjie
2024-11-11 14:22   ` Maxim Cournoyer [this message]
2024-10-24  7:40 ` [bug#73981] [PATCH 2/4] gnu: Add libqrtr-glib Zheng Junjie
2024-11-11 14:28   ` Maxim Cournoyer
2024-10-24  7:40 ` [bug#73981] [PATCH 3/4] gnu: libqmi: Update to 1.34.0 Zheng Junjie
2024-11-12  1:06   ` Maxim Cournoyer
2024-10-24  7:40 ` [bug#73981] [PATCH 4/4] gnu: modem-manager: Update to 1.22.0 Zheng Junjie
2024-11-12  1:13   ` Maxim Cournoyer
2024-11-12  3:46 ` [bug#73981] [PATCH v2 0/4] update modem-manager and deps Zheng Junjie
2024-11-12  3:46   ` [bug#73981] [PATCH v2 1/4] gnu: libmbim: Update to 1.30.0 Zheng Junjie
2024-11-12  3:46   ` [bug#73981] [PATCH v2 2/4] gnu: Add libqrtr-glib Zheng Junjie
2024-11-12  3:46   ` [bug#73981] [PATCH v2 3/4] gnu: libqmi: Update to 1.34.0 Zheng Junjie
2024-11-12  3:46   ` [bug#73981] [PATCH v2 4/4] gnu: modem-manager: Update to 1.22.0 Zheng Junjie
2024-11-15 10:54   ` bug#73981: [PATCH v2 0/4] update modem-manager and deps Z572

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttcd97fo.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=73981@debbugs.gnu.org \
    --cc=zhengjunjie@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).