From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id wBDAMs38QWfWlAAAe85BDQ:P1 (envelope-from ) for ; Sat, 23 Nov 2024 16:03:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id wBDAMs38QWfWlAAAe85BDQ (envelope-from ) for ; Sat, 23 Nov 2024 17:03:25 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=uf0yoRoE; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Qc5HRvLw; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732377805; a=rsa-sha256; cv=none; b=aJVFEee9q9rypDFWLx9qyKyi1Malf+oFYg+MVi19gGhS+rjNp0uxIm10J7eJX21nJ7senh vkIwbJqqP+bcyDjEaxUa2NZ7yDnrK1gdbIF4il5zogJNeMCiMCV+1qjFD7SUlf0ReXpwLO RdGRpcACUu3Pu1F/5zaXejAKwi/v3akKtwswixzQFIA+8IOmLKJOHKVrM7A+OjcWKltJZR UxYX2wgxpek8kfoCvCG3MbDbLEZQCpScow33B3XEm7S5P1URB6mnuPUDbUoDPsm8KBynGB Fe4sGaf5Mj+L9w9QutY0Vh/7MNd7B8w6qbWqY2PIcTtvc0CQH+n/v6pI8m6v2Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=uf0yoRoE; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Qc5HRvLw; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1732377805; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=KFPPWKDLY+FMg0ZEW6eFsd+o3aPctTNi2ovkRocMCvY=; b=iGEANjoSVPjnvr8Dk72A2steyez8oHyJFdj3PsB/Zp3xpG6oVK5tv0PDdfLUoNDX0/pezQ 9VrmhXDGvW5fLS8Wx9ptlcCdIqIcZRXGKzWcighhRpYH84TUHUw42jV6R1REEqOk5GNL3V br1grzKW6kR1NfjFUptfqf5IVKhi4pEyrBdMCoiev5rzSq9Q0VUNwytAO8hkAQ07e12BW/ BHnJ1xQgUGlXULltagbT5msZg/9ow2WlVx/Qvwm5tCd//ey4qa21b4HA/BfWd0Y2twtlGW 2uzkMa8uSIBkn6NCycPFYygXtAC2aOl79w6lL+f+1aocSBBr9hrZBn+9G6SSKQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D575919A07 for ; Sat, 23 Nov 2024 17:03:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEsbB-0003wm-MW; Sat, 23 Nov 2024 11:03:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEsb9-0003wO-0b for guix-patches@gnu.org; Sat, 23 Nov 2024 11:03:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEsb8-00030d-6p for guix-patches@gnu.org; Sat, 23 Nov 2024 11:03:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=KFPPWKDLY+FMg0ZEW6eFsd+o3aPctTNi2ovkRocMCvY=; b=uf0yoRoE1P0uqCqtnel5IzaGIcNg7DwGvmXn8T9a5VanC2aANxjC3BK+4TDB8q260QJFm74/1KwOSe4ybk0B7TppDgS6cmboNMmi/ZfIyVxAxCceOl3QYp1BMe5szNMvI0cVOfkk3DlksayeQxwe9+cvf6+1yiPzB+ZH/+BAPDTLd/yKgGQuUGIJVHROca98WKGje4rJpmmZFXUcuhEbMFXPgPtcGV7nB96GytQ6S+KWpgbwD1oh15bJUlRHOXq2EzyBtt4pnPB4hV9YK0VDhgJqTDJa1uWcm9wpRGa8kY8sGe0pyviDm0LATFDxM/KGdHuPG0BdBX78q7kV8mCEvQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEsb8-0006Ao-0i for guix-patches@gnu.org; Sat, 23 Nov 2024 11:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#73842] [PATCH v5 2/3] pack: Add support for AppImage pack format. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Nov 2024 16:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73842 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?No=C3=A9?= Lopez Cc: 73842@debbugs.gnu.org Received: via spool by 73842-submit@debbugs.gnu.org id=B73842.173237773023639 (code B ref 73842); Sat, 23 Nov 2024 16:03:01 +0000 Received: (at 73842) by debbugs.gnu.org; 23 Nov 2024 16:02:10 +0000 Received: from localhost ([127.0.0.1]:58722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEsaH-00069D-Go for submit@debbugs.gnu.org; Sat, 23 Nov 2024 11:02:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEsaD-00068T-Jm for 73842@debbugs.gnu.org; Sat, 23 Nov 2024 11:02:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEsa7-0002wJ-Fn; Sat, 23 Nov 2024 11:01:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=KFPPWKDLY+FMg0ZEW6eFsd+o3aPctTNi2ovkRocMCvY=; b=Qc5HRvLwgvaNxcn0HnBx dZR109S2rIrthpICdbNdlN/880V6seJg5OPMiflU9k48yKzODwfkoDKwFZElqJ5l005xUTe3TsFTE P/eEtRcOE07+sGAvWXXgwzJMXoRJOB5kdMDOOo0P47hnZydJ86OOpIm7VBDmxc3ej8wkirjBLvNlG HEoYnsbKbFh1Lsn2yCYepPpT6wC4d7tDvkyOwjwa829kl/xtNtqok5P1fUOM3/mdOnPtUBebd/mpS pvY1ZJu3h7UnMkeV8lSGGMkMLAdI2xmP+2Mt2/B8W0CLy1FXSEZXwtNkfOojKDBkFSN8ZnqIMHnhB bE9ylyyiim+yqA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <871pz2kqze.fsf@xn--no-cja.eu> ("=?UTF-8?Q?No=C3=A9?= Lopez"'s message of "Sat, 23 Nov 2024 14:40:53 +0100") References: <4a7795be82c20d9476dbefcbaf3c380dcb61581e.1730998051.git.noelopez@free.fr> <7507b2c56ffbbd8bc051937c5c88bb8c0e3ae8f3.1730998051.git.noelopez@free.fr> <87h688l9bk.fsf@gnu.org> <87ttc5q1b3.fsf@xn--no-cja.eu> <87ed36xg90.fsf@gnu.org> <871pz2kqze.fsf@xn--no-cja.eu> Date: Sat, 23 Nov 2024 17:01:56 +0100 Message-ID: <87ttbyos5n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.47 X-Spam-Score: -3.47 X-Migadu-Queue-Id: D575919A07 X-Migadu-Scanner: mx10.migadu.com X-TUID: w4ipsYuuAKzx --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey No=C3=A9, Pushed as 8d6389b866d91a72569ecf50ddf313c17430d34b! Thank you, and thanks for your patience! Of course, only after pushing and thinking through the FUSE issue did I realize that something must be wrong with the tests because we cannot rely on =E2=80=98fusermount3=E2=80=99 or FUSE in general in the build envir= onment. Indeed, those tests were not building anything at all because the =E2=80=98check=E2=80=99 derivation has zero outputs. So I tried the change below, but that leads to a failing test: --8<---------------cut here---------------start------------->8--- Failed to run /tmp/guix-build-check-appimage.drv-0/appimage_extracted_b74cb= 93b3ec3113d87e0f1da08dcd973/AppRun: No such file or directory builder for `/gnu/store/jxvrfa81m60zwwdrj55x0npmfbgblfv6-check-appimage.drv= ' failed with exit code 127 --8<---------------cut here---------------end--------------->8--- Could you or Sebastian take a look? No rush, but it=E2=80=99s best to have working tests for features like this. (Please open a new issue to follow up on this.) Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff --git a/tests/pack.scm b/tests/pack.scm index 1c1e312557..c395f3935f 100644 --- a/tests/pack.scm +++ b/tests/pack.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright =C2=A9 2017-2021, 2023 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2017-2021, 2023, 2024 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2018 Ricardo Wurmus ;;; Copyright =C2=A9 2021, 2023 Maxim Cournoyer ;;; Copyright =C2=A9 2023 Oleg Pykhalov @@ -356,8 +356,18 @@ (define rpm-for-tests (list #:relocatable? #t))) (check (gexp->derivation "check-appimage" - #~(invoke #$image)))) - (built-derivations (list check)))) + (with-imported-modules '((guix build utils)) + #~(begin + (use-modules (ice-9 popen) + (guix build utils)) + + (let ((pipe (open-pipe* OPEN_READ + #$image "--appimage-extra= ct-and-run"))) + (call-with-output-file #$output + (lambda (port) + (dump-port pipe port))) + (exit (status:exit-val (close-pipe pipe))))))))) + (built-derivations (list (pk 'APPIMAGE-drv check))))) =20 (unless store (test-skip 1)) (test-assertm "appimage + localstatedir" @@ -374,6 +384,7 @@ (define rpm-for-tests (list #:relocatable? #t))) (check (gexp->derivation "check-appimage" + ;; FIXME: Do something as above. #~(begin (invoke #$image))))) (built-derivations (list check)))) --=-=-=--