From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id iBc+OxwATWe73wAAqHPOHw:P1 (envelope-from ) for ; Mon, 02 Dec 2024 00:32:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id iBc+OxwATWe73wAAqHPOHw (envelope-from ) for ; Mon, 02 Dec 2024 01:32:29 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=BsvAJAOV; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=mail header.b=RI0rpo1T; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=ultrarare.space (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733099548; a=rsa-sha256; cv=none; b=jjtQe8A+pGyaVcc3RRbKlZHsa7FGqqZIisKsfJcfGjY1Gbv7NZLYMEblb+JYVcYNQbx0i0 fmV6aJdriS08QRpFVEVA1QTASdEi8kg2xrpLLGzmCANuM6pIz4aTGmbK/CP9qjUPsGlKhm 4fWHhyXeZme6GrIFgodtzU4VJ0HSfmop4qzA4V+AEDLw6CfH6+TLz6A+tnFkVLqbcPGeCP iCtSxdygwnQLVrx28uzpwapptzXyH5jzjnTTm1Br4yO8xUC2UoHYiA731H8ibQR59IFnhr OlGCrCUxKzd4h/gNS9QGf9JWfvXE17FL4wjwJ/QJ4wiyBnRmxLdlRvtmzJ4emg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=BsvAJAOV; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=mail header.b=RI0rpo1T; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=ultrarare.space (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733099548; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2if+ib2Xz5JhokiXeBwZGLKsMg/urAYuecVzWKu2Er8=; b=BMG9in2t4bHyaW9e5Uq8XZz/fTSLUz0eAp8vLmBNNz4c1xhs+mNnzgqrtwmnchWfhQHok5 tgalPm0AddwOMiP1qIK8HWCuCg5kK1bievXi4rtFemCtZHNkrrPw8PWxgL41VvjyI562Hj uRtCLHes1Z26VYqaxN5V8txHE8ovthsh0xjumRG8Pc/CR+A+kldKrJYpDzAQM3KgT/VZvN rVlKQ5sI+dgsX5C9zxpBAvFJg6mtSpG6fH2cxlUSAJN/qtQtJ3MCg8+dCNE1Gt3rWhnk8m /lko522vON74qb0NLgbJICuGfQ2SicK4sYTIZV+oQphH8euyEJvZnjCf8maimg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0845868C2 for ; Mon, 02 Dec 2024 01:32:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHuMA-0003Xw-FT; Sun, 01 Dec 2024 19:32:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHuM6-0003Xe-ML for guix-patches@gnu.org; Sun, 01 Dec 2024 19:32:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHuM6-0000Y0-DW for guix-patches@gnu.org; Sun, 01 Dec 2024 19:32:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=2if+ib2Xz5JhokiXeBwZGLKsMg/urAYuecVzWKu2Er8=; b=BsvAJAOVmcptck4Ep70JMMp4qFuDB1Js2dZnXSrAozUd/+0rqV2bcU5nUPM2qXBVNeUpkpKu0jKN4utiJcjmAhKyyWu+pArSwPfxwzp2aObKoygOjs0+sqEfw2HNr+bstr0o+LvGWRM/9NlhOkF2QZY0B/uCCR/bFMYjhjc3Wp5zQe4RxbXkk2KY9axRAFYuIc7PNedF12J8TAcX4M8v2i1ocCu9KqCBexwnoDAy2z9DX2cezFjcblryiQiY4A/QhWo5ocrYjMUV3FUZlbqRLPIcULxWIW564Zzrvsq5XPM9rnchL8L+FssMO3iAibUTik4xsDjSTm26DS3MByCsiA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tHuM5-0002Io-Sz for guix-patches@gnu.org; Sun, 01 Dec 2024 19:32:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74639] [PATCH] gnu: make-gitolite: Fix inputs references Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Dec 2024 00:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74639 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ashish SHUKLA Cc: 74639@debbugs.gnu.org Received: via spool by 74639-submit@debbugs.gnu.org id=B74639.17330994768764 (code B ref 74639); Mon, 02 Dec 2024 00:32:01 +0000 Received: (at 74639) by debbugs.gnu.org; 2 Dec 2024 00:31:16 +0000 Received: from localhost ([127.0.0.1]:53556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHuLL-0002HI-Hj for submit@debbugs.gnu.org; Sun, 01 Dec 2024 19:31:15 -0500 Received: from mx.boiledscript.com ([88.99.243.112]:59136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHuLI-0002H8-GP for 74639@debbugs.gnu.org; Sun, 01 Dec 2024 19:31:14 -0500 Date: Mon, 02 Dec 2024 08:31:10 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1733099471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2if+ib2Xz5JhokiXeBwZGLKsMg/urAYuecVzWKu2Er8=; b=RI0rpo1ThTPqS70QjHO80bYZu2/jtAzsczKHOY5MIhaUSr/eCZ78tQdCBrsYxYAcl5Bfaq it8hOTuekEYGt9KZ+p6X1eMs0P5/f5ZtkYyIDN/ggwC9vp2bFQ5Il1L9NbT9MS13pgBXPt qY+k10UzKOXQTsmj2JA+O0HVd89NsI1xD376L4pjtJz6M7Rjpk6z38HtqJoRXykRhztX/e vbf5fhGqJ8HqU5FzPRU2nu3X7s51+ZmaJuNoEjJGhOE5MZ5IzvaBuMWjm4MDmELP/agaFc ProknrNXE/Hes+d6VPquzIFugtD88JHrg76kAXHiTeta3dDCQA8yCl+wXSLOVQ== Message-ID: <87ttbndiy9.wl-hako@ultrarare.space> From: Hilton Chain In-Reply-To: <4cf43336d8892d405b0a70809b7f7e83a6012a91.1733094907.git.ashish.is@lostca.se> References: <4cf43336d8892d405b0a70809b7f7e83a6012a91.1733094907.git.ashish.is@lostca.se> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.68 X-Spam-Score: -3.68 X-Migadu-Queue-Id: A0845868C2 X-Migadu-Scanner: mx10.migadu.com X-TUID: bDvgKJDziyzd Hi Ashish, On Mon, 02 Dec 2024 07:15:07 +0800, ashish.is--- via Guix-patches via wrote: > > From: Ashish SHUKLA > > * gnu/packages/version-control.scm (make-gitolite)[arguments] > {patch-scripts,patch-source,wrap-scripts}: Update functions to reference > inputs from the inputs alist, instead of hardcoding. The commit message format we use doesn't have this ("{...}") level I think?= You can use "[#:phases]<...>" here instead. > Change-Id: Ia2468235b43c257ee1816d19325671d373ed2870 > --- > Hi, > > When trying to override inputs of "gitolite", I noticed it's hardcoding t= hem > instead of referencing the "inputs" alist parameter which is passed to the > phases, which makes overriding the inputs useless. This patches fixes that > behaviour. > > Thanks! > > gnu/packages/version-control.scm | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) Please avoid operating on input labels directly when possible, in this case= you can use =A1search-input-file=A2. Thanks