unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hilton Chain <hako@ultrarare.space>
To: Ashish SHUKLA <ashish.is@lostca.se>
Cc: 74639@debbugs.gnu.org
Subject: [bug#74639] [PATCH] gnu: make-gitolite: Fix inputs references
Date: Mon, 02 Dec 2024 08:31:10 +0800	[thread overview]
Message-ID: <87ttbndiy9.wl-hako@ultrarare.space> (raw)
In-Reply-To: <4cf43336d8892d405b0a70809b7f7e83a6012a91.1733094907.git.ashish.is@lostca.se>

Hi Ashish,

On Mon, 02 Dec 2024 07:15:07 +0800,
ashish.is--- via Guix-patches via wrote:
>
> From: Ashish SHUKLA <ashish.is@lostca.se>
>
> * gnu/packages/version-control.scm (make-gitolite)[arguments]<phases>
> {patch-scripts,patch-source,wrap-scripts}: Update functions to reference
> inputs from the inputs alist, instead of hardcoding.

The commit message format we use doesn't have this ("{...}") level I think?  You
can use "[#:phases]<...>" here instead.

> Change-Id: Ia2468235b43c257ee1816d19325671d373ed2870
> ---
> Hi,
>
> When trying to override inputs of "gitolite", I noticed it's hardcoding them
> instead of referencing the "inputs" alist parameter which is passed to the
> phases, which makes overriding the inputs useless. This patches fixes that
> behaviour.
>
> Thanks!
>
>  gnu/packages/version-control.scm | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)

Please avoid operating on input labels directly when possible, in this case you
can use ‘search-input-file’.

Thanks




  reply	other threads:[~2024-12-02  0:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-01 23:15 [bug#74639] [PATCH] gnu: make-gitolite: Fix inputs references ashish.is--- via Guix-patches via
2024-12-02  0:31 ` Hilton Chain [this message]
2024-12-02  9:48   ` [bug#74639] [PATCH v2] " ashish.is--- via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttbndiy9.wl-hako@ultrarare.space \
    --to=hako@ultrarare.space \
    --cc=74639@debbugs.gnu.org \
    --cc=ashish.is@lostca.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).