From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9Ac3-0004uY-BE for guix-patches@gnu.org; Fri, 12 May 2017 09:28:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9Aby-0005cN-9T for guix-patches@gnu.org; Fri, 12 May 2017 09:28:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37255) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d9Aby-0005cD-6p for guix-patches@gnu.org; Fri, 12 May 2017 09:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d9Abx-0000zX-Tm for guix-patches@gnu.org; Fri, 12 May 2017 09:28:01 -0400 Subject: bug#26294: [PATCH] gnu: rocksdb: Disable tests on 32-bit systems. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: <871ssqlnun.fsf@fastmail.com> References: <20170329094220.5694-1-mbakke@fastmail.com> <87zifeoh8x.fsf@gnu.org> <871ssqlnun.fsf@fastmail.com> Date: Fri, 12 May 2017 15:27:15 +0200 Message-ID: <87shkai4ss.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 26294-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Marius Bakke writes: > Ludovic Court=C3=A8s writes: > >> Hello, >> >> Marius Bakke skribis: >> >>> * gnu/packages/databases.scm (rocksdb)[arguments]: Make #:tests? condit= ional. >>> Delete unnecessary 'build' phase. >>> --- >>> gnu/packages/databases.scm | 12 +++++++++++- >>> 1 file changed, 11 insertions(+), 1 deletion(-) >>> >>> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm >>> index b87e8a210..e73635910 100644 >>> --- a/gnu/packages/databases.scm >>> +++ b/gnu/packages/databases.scm >>> @@ -533,12 +533,20 @@ types are supported, as is encryption.") >>> #t)))) >>> (build-system gnu-build-system) >>> (arguments >>> - '(#:make-flags (list "CC=3Dgcc" >>> + `(#:make-flags (list "CC=3Dgcc" >>> ;; Make the resulting library position-indep= endent so the >>> ;; static version can be included in shared = objects. >>> "EXTRA_CXXFLAGS=3D-fPIC" >>> (string-append "INSTALL_PATH=3D" >>> (assoc-ref %outputs "out"))) >>> + ;; Many tests fail on 32-bit platforms. There are multiple repo= rts about >>> + ;; this upstream, but it's not going to be supported any time s= oon. >>> + #:tests? (let ((system ,(or (%current-target-system) >>> + (%current-system))) >>> + (supported-systems '("x86_64-linux" "aarch64-lin= ux"))) >>> + (if (member system supported-systems) >>> + #t >>> + #f)) >> >> This doesn=E2=80=99t work because (%current-target-system) is a GNU trip= let, >> like =E2=80=9Carm-linux-gnueabihf=E2=80=9D, whereas (%current-system) is= a =E2=80=9Csystem >> type=E2=80=9D, like =E2=80=9Carmhf-linux=E2=80=9D. >> >> Instead you should use =E2=80=98string-prefix?=E2=80=99 or similar. >> >> Other than that, I think it should go in! > > Well, I actually tried this recently (also disabling the individual > tests, which was a rabbit hole that ultimately gave an inexplicable > error). > > Anyway, when building for i686-linux on x86_64, the compiler appears to > hit a never-ending loop at the linking stage! I'm pretty sure this was > not the case before the core-updates merge (when I tested this), so I > wonder if it's a case of > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26497 . > > To be continued, but now it would just cause the build to take up a CPU > core until it times out, rather than failing early.. I'm still hitting some loop when building for i686-linux, but decided to push this patch regardless to see if it works better on native platforms (especially ARM, now that jemalloc is fixed). Closing this bug, but will keep an eye on Hydra and open a new bug if the build farm encounters the same problem. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkVuDMACgkQoqBt8qM6 VPqscgf+NRAfN21EW0cn80iW4fq+qRRa9c1tdRyR7lREcKF3xG3YuaJO2fWqPwlR HjALwMtyd1u4Rc9GIUDPnJynzqh071pzCKwJbIC3gy+Ui1UOsQCjxibxUiTQpRi3 dhvQq3FoTclM61oXL8Dop261zecMbZCzb5O0rGxpMNbRNhhQun/sXX0GoXolUUit Ju1lMpkP3nQJyfmEVURnEktCqvw3nuf3gG6PdR89oRlKjWDpTnQJK/6lG+lcpvHn 7oIgkeTxvv5/0d+YI+EfsVGkHDL6hJncyH+H9dpQqZDhBbEgXt1SEEB8pckl5plv kfdEU2RQXll7OVjzl6MuSss85q3yVA== =FEv/ -----END PGP SIGNATURE----- --=-=-=--