From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMcts-00025d-3G for guix-patches@gnu.org; Sun, 18 Jun 2017 12:18:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMctm-0007y7-Aj for guix-patches@gnu.org; Sun, 18 Jun 2017 12:18:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:52587) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMctl-0007xs-V5 for guix-patches@gnu.org; Sun, 18 Jun 2017 12:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMctl-0008Ni-MS for guix-patches@gnu.org; Sun, 18 Jun 2017 12:18:01 -0400 Subject: [bug#27412] [PATCH] gnu: rustc: Enable tests. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170617183701.28819-1-dannym@scratchpost.org> References: <20170617183701.28819-1-dannym@scratchpost.org> Date: Sun, 18 Jun 2017 18:17:48 +0200 Message-ID: <87shixfexf.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic , 27412@debbugs.gnu.org --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > * gnu/packages/rust.scm (rustc)[source]: Remove bundled llvm. > [native-inputs]: Add bison, flex, procps. > [inputs]: Update llvm to llvm-3.9.1. > [arguments]: Patch and enable tests. Great! [...] > @@ -254,7 +262,18 @@ rustc-bootstrap and cargo-bootstrap packages.") > (substitute* "src/tools/tidy/src/main.rs" > (("^.*cargo.*::check.*$") "")) > (substitute* "src/libstd/process.rs" > - (("\"/bin/sh\"") (string-append "\"" bash "/bin/sh\""))) > + ;; The newline is intentional. > + ;; There's a line length "tidy" check in Rust which would > + ;; fail otherwise. > + (("\"/bin/sh\"") (string-append " > +\"" bash "/bin/sh\""))) Can you use '\n' instead? > + (substitute* "src/libstd/sys/unix/process/process_common.rs" > + (("fn test_process_mask") "#[cfg_attr(target_os = \"linux\", ignore)] > +fn test_process_mask")) I'm guessing this is disabled due to some build container oddity? > + (substitute* "src/vendor/libc/src/lib.rs" > + (("TODO") "TXDO")) A comment about this would be nice. > + ;; Our ld-wrapper cannot process non-UTF8 bytes in LIBRARY_PATH. > + (delete-file-recursively "src/test/run-make/linker-output-non-utf8") This is temporary, right? Maybe add the guix-devel URL? LGTM! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAllGp6wACgkQoqBt8qM6 VPrtkwgAvwXdIqevoyWB0sYqz1+S4ktqcRqgQVuDvlPlQ9BRT6xT1THGfbfVWEKU 7z3EhGxdqnC4y1Yqxj2h3DcDtRE4XezS3bmkDOjzaAMI/2bgSUuOjqAmOYvfcps7 hleeXiOyP+/9+ZPZqFgNhS2f4vl+JyPZEbp7EKl7LaNPs+ix+Jy4nieSNfjrHNxH NY6SoOqCAaXx/q2RXgEiaKw/4gmdYUSRdBkl5NA9f1o6QJsZWMMHeGnvmFXhS0Vd 659E2o7+cb2v7zwFfUqXol99TBZvWamOkNbLtPjaspKboy3YbED3pTTj+W9FeI7g yopD2ialqeyaw2T6JaQu0L0F3V0bHA== =mdPU -----END PGP SIGNATURE----- --=-=-=--