From: Marius Bakke <mbakke@fastmail.com>
To: Danny Milosavljevic <dannym@scratchpost.org>, 27412@debbugs.gnu.org
Subject: [bug#27412] [PATCH] gnu: rustc: Enable tests.
Date: Sun, 18 Jun 2017 18:17:48 +0200 [thread overview]
Message-ID: <87shixfexf.fsf@fastmail.com> (raw)
In-Reply-To: <20170617183701.28819-1-dannym@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> writes:
> * gnu/packages/rust.scm (rustc)[source]: Remove bundled llvm.
> [native-inputs]: Add bison, flex, procps.
> [inputs]: Update llvm to llvm-3.9.1.
> [arguments]: Patch and enable tests.
Great!
[...]
> @@ -254,7 +262,18 @@ rustc-bootstrap and cargo-bootstrap packages.")
> (substitute* "src/tools/tidy/src/main.rs"
> (("^.*cargo.*::check.*$") ""))
> (substitute* "src/libstd/process.rs"
> - (("\"/bin/sh\"") (string-append "\"" bash "/bin/sh\"")))
> + ;; The newline is intentional.
> + ;; There's a line length "tidy" check in Rust which would
> + ;; fail otherwise.
> + (("\"/bin/sh\"") (string-append "
> +\"" bash "/bin/sh\"")))
Can you use '\n' instead?
> + (substitute* "src/libstd/sys/unix/process/process_common.rs"
> + (("fn test_process_mask") "#[cfg_attr(target_os = \"linux\", ignore)]
> +fn test_process_mask"))
I'm guessing this is disabled due to some build container oddity?
> + (substitute* "src/vendor/libc/src/lib.rs"
> + (("TODO") "TXDO"))
A comment about this would be nice.
> + ;; Our ld-wrapper cannot process non-UTF8 bytes in LIBRARY_PATH.
> + (delete-file-recursively "src/test/run-make/linker-output-non-utf8")
This is temporary, right? Maybe add the guix-devel URL?
LGTM!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-06-18 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 18:37 [bug#27412] [PATCH] gnu: rustc: Enable tests Danny Milosavljevic
2017-06-18 16:17 ` Marius Bakke [this message]
2017-06-18 17:28 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shixfexf.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=27412@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).