unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 27865@debbugs.gnu.org
Subject: [bug#27865] [PATCH 2/3] pull: Fetch source code from Git.
Date: Mon, 31 Jul 2017 15:40:25 +0200	[thread overview]
Message-ID: <87shhc67xy.fsf@gnu.org> (raw)
In-Reply-To: <87h8xtnfac.fsf@gmail.com> (Mathieu Othacehe's message of "Mon, 31 Jul 2017 11:09:47 +0200")

Howdy Mathieu,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> From 6d6b0e48856998251284539e69bbc39e6d21635f Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Mon, 31 Jul 2017 11:08:32 +0200
> Subject: [PATCH] base: Report git errors.
>
> * src/cuirass/base.scm (report-git-error): New procedure.
> (with-git-error-handling): New macro.
> (process-specs): Use with-git-error-handling to catch and report git errors.
> * build-aux/guix.scm (package)[inputs]: Add guile-git.
> * configure.ac: Check for (git) module. Also check that (git) exports
> git-error-message procedure.

[...]

> +(define (report-git-error error)
> +  "Report the given Guile-Git error."
> +  (format #t "Git error: ~a~%" (git-error-message error)))

s/#t/(current-error-port)/

Otherwise LGTM!

Thanks,
Ludo’.

  reply	other threads:[~2017-07-31 13:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 20:28 [bug#27865] [PATCH 0/3] Use Guile-Git for 'guix pull' Ludovic Courtès
2017-07-28 20:45 ` [bug#27865] [PATCH 1/3] build: Make Guile-Git a hard requirement Ludovic Courtès
2017-07-28 20:45   ` [bug#27865] [PATCH 2/3] pull: Fetch source code from Git Ludovic Courtès
2017-07-30 13:15     ` Mathieu Othacehe
2017-07-30 20:38       ` Ludovic Courtès
2017-07-31  9:09         ` Mathieu Othacehe
2017-07-31 13:40           ` Ludovic Courtès [this message]
2017-07-31 13:56             ` Mathieu Othacehe
2017-07-28 20:45   ` [bug#27865] [PATCH 3/3] pull: Use the commit ID as the version string Ludovic Courtès
2017-07-31 15:25 ` [bug#27865] [PATCH 0/3] Use Guile-Git for 'guix pull' Ludovic Courtès
2017-08-01 22:10   ` bug#27865: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shhc67xy.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=27865@debbugs.gnu.org \
    --cc=m.othacehe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).