From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duKWH-0001mO-SS for guix-patches@gnu.org; Tue, 19 Sep 2017 11:33:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duKWD-0000ja-Sf for guix-patches@gnu.org; Tue, 19 Sep 2017 11:33:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39739) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duKWD-0000jS-Os for guix-patches@gnu.org; Tue, 19 Sep 2017 11:33:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1duKWD-0005Ek-Iy for guix-patches@gnu.org; Tue, 19 Sep 2017 11:33:01 -0400 Subject: [bug#28504] [PATCH] cuirass: Add --listen command line option. Resent-Message-ID: From: Jan Nieuwenhuizen References: <20170918200207.28095-1-janneke@gnu.org> <87shfj56wc.fsf@gnu.org> Date: Tue, 19 Sep 2017 17:32:16 +0200 In-Reply-To: <87shfj56wc.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 19 Sep 2017 12:17:55 +0200") Message-ID: <87shfi1z7j.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28504@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: >> * bin/cuirass.in (show-help): Add help for --listen option. >> (%options): Add listen option. >> (main): Pass host to run-cuirass-server. >> * doc/cuirass.texi (Invocation): Add --listen option. >> * src/cuirass/http.scm (run-cuirass-server): Add named #:host parameter. > > Good idea, LGTM thanks! Pushed to guix-cuirass master as 2a4d493e28100b8eca7d23300dd872c9f99e1f16 Attached is the corresponding Guixy side (or should I close this one and open a new bug?). Greetings, janneke --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-services-cuirass-Add-host-option.patch Content-Transfer-Encoding: quoted-printable >From 5e14a890c0ffa1b9a753be8b9a9d516f14a6955f Mon Sep 17 00:00:00 2001 From: Jan Nieuwenhuizen Date: Mon, 18 Sep 2017 22:12:18 +0200 Subject: [PATCH] services: cuirass: Add host option. * gnu/services/cuirass.scm (): Add host option. (cuirass-shepherd-service): Pass host option. * doc/guix.texi (Continuous Integration): Document it. --- doc/guix.texi | 4 ++++ gnu/services/cuirass.scm | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index 1356a357c..deb055e29 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -15335,6 +15335,10 @@ added specifications. @item @code{port} (default: @code{8081}) Port number used by the HTTP server. =20 +@item --listen=3D@var{host} +Listen on the network interface for @var{host}. The default is to +accept connections from localhost. + @item @code{specifications} (default: @code{#~'()}) A gexp (@pxref{G-Expressions}) that evaluates to a list of specifications, where a specification is an association list diff --git a/gnu/services/cuirass.scm b/gnu/services/cuirass.scm index 2ad595220..c5e9fcbb2 100644 --- a/gnu/services/cuirass.scm +++ b/gnu/services/cuirass.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2016 Mathieu Lirzin ;;; Copyright =C2=A9 2016, 2017 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2017 Mathieu Othacehe +;;; Copyright =C2=A9 2017 Jan Nieuwenhuizen ;;; ;;; This file is part of GNU Guix. ;;; @@ -61,6 +62,8 @@ (default "/var/run/cuirass/cuirass.db")) (port cuirass-configuration-port ;integer (port) (default 8081)) + (host cuirass-configuration-host ;string + (default "localhost")) (specifications cuirass-configuration-specifications) ;gexp that evaluates to specification-al= ist (use-substitutes? cuirass-configuration-use-substitutes? ;boolean @@ -84,6 +87,7 @@ (interval (cuirass-configuration-interval config)) (database (cuirass-configuration-database config)) (port (cuirass-configuration-port config)) + (host (cuirass-configuration-host config)) (specs (cuirass-configuration-specifications config)) (use-substitutes? (cuirass-configuration-use-substitutes? config)) (one-shot? (cuirass-configuration-one-shot? config)) @@ -100,6 +104,7 @@ #$(scheme-file "cuirass-specs.scm" specs) "--database" #$database "--port" #$(number->string port) + "--listen" #$host "--interval" #$(number->string interval) #$@(if use-substitutes? '("--use-substitutes")= '()) #$@(if one-shot? '("--one-shot") '()) --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com --=-=-=--