[bug#28653] [PATCH] gnu: gnome-calendar: Update to 3.26.1.

[bug#28653] [PATCH] gnu: gnome-calendar: Update to 3.26.1.

[Mohammed Sadiq]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

The following warning is not fixed:
(gnome-calendar:8477): Gtk-WARNING **: Could not load a pixbuf from /org/gtk/libgtk/theme/Adwaita/assets/bullet-symbolic.svg.
This may indicate that pixbuf loaders or the mime database could not be found.

Adding gdk-pixbuf[0] as input doesn't seem to fix the issue. Anyway, there seems no
issue so far.

[0] https://lists.gnu.org/archive/html/guix-devel/2016-11/msg00704.html

Thanks

[-- Attachment #2: 0001-gnu-gnome-calendar-Update-to-3.26.1.patch --]
[-- Type: text/x-patch, Size: 2794 bytes --]

From b44ddaad4a9d4dd06fea29907b1a59489f85d137 Mon Sep 17 00:00:00 2001
From: Mohammed Sadiq <sadiq@sadiqpk.org>
Date: Sat, 30 Sep 2017 09:06:35 +0530
Subject: [PATCH] gnu: gnome-calendar: Update to 3.26.1.

* gnu/packages/gnome.scm (gnome-calendar): Update to 3.26.1.
[build-system]: Move to meson-build-system.
[arguments]: Enable gtk+ for meson-build-system, disable tests.
[native-inputs]: Add gettext, gtk+-bin and glib-bin, remove intltool.
[inputs]: Remove bdb and desktop-file-utils.
[description]: Rephrase and add week view.
---
 gnu/packages/gnome.scm | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 84c98b0ff..1940a147d 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -6065,7 +6065,7 @@ desktop.  It supports world clock, stop watch, alarms, and count down timer.")
 (define-public gnome-calendar
   (package
     (name "gnome-calendar")
-    (version "3.24.3")
+    (version "3.26.1")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://gnome/sources/" name "/"
@@ -6073,22 +6073,27 @@ desktop.  It supports world clock, stop watch, alarms, and count down timer.")
                                   name "-" version ".tar.xz"))
               (sha256
                (base32
-                "1v7k1wcl5yg9bd4l0rz0z03h32d35zgfp4qzz21widjcyis41jry"))))
-    (build-system glib-or-gtk-build-system)
+                "0p4xg9sfhcyy2lj9sdg8pk6dmggbi80f038dycr24v0ccy3nk6f2"))))
+    (build-system meson-build-system)
+    (arguments
+     '(#:glib-or-gtk? #t
+       ;; gnome-calendar has to be installed before the tests can be run
+       ;; https://bugzilla.gnome.org/show_bug.cgi?id=788224
+       #:tests? #f))
     (native-inputs
-     `(("intltool" ,intltool)
+     `(("gettext" ,gettext-minimal)
+       ("glib-bin" ,glib "bin")         ; For glib-compile-schemas
+       ("gtk+-bin" ,gtk+ "bin")         ; For gtk-update-icon-cache
        ("pkg-config" ,pkg-config)))
     (inputs
-     `(("bdb" ,bdb)
-       ("desktop-file-utils" ,desktop-file-utils)
-       ("evolution-data-server" ,evolution-data-server)
+     `(("evolution-data-server" ,evolution-data-server)
        ("gnome-online-accounts" ,gnome-online-accounts)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
     (home-page "https://wiki.gnome.org/Apps/Calendar")
     (synopsis "GNOME's calendar application")
     (description
      "GNOME Calendar is a simple calendar application designed to fit the GNOME
-desktop.  It supports multiple calendars, monthly view and yearly view.")
+desktop.  It supports multiple calendars, month, week and year view.")
     (license license:gpl3+)))
 
 (define-public gnome-todo
-- 
2.14.1

[bug#28653] [PATCH] gnu: gnome-calendar: Update to 3.26.1.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

Mohammed Sadiq <sadiq@sadiqpk.org> writes:

> The following warning is not fixed:
> (gnome-calendar:8477): Gtk-WARNING **: Could not load a pixbuf from
> /org/gtk/libgtk/theme/Adwaita/assets/bullet-symbolic.svg.
> This may indicate that pixbuf loaders or the mime database could not be found.
>
> Adding gdk-pixbuf[0] as input doesn't seem to fix the issue. Anyway,
> there seems no
> issue so far.
>
> [0] https://lists.gnu.org/archive/html/guix-devel/2016-11/msg00704.html
>
> Thanks

LGTM! Pushed to master as a49d3e377559fdfd78cd5f90d128dbf4a1654eab.

As for the warning, it appears to happen because of an issue in one of
gnome-calendar's gtk+-related dependencies. We will find out what it is
given some time.

Thank you for contributing!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#28653] [PATCH] gnu: gnome-calendar: Update to 3.26.1.

[Ludovic Courtès]

Mohammed Sadiq <sadiq@sadiqpk.org> skribis:

> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -6065,7 +6065,7 @@ desktop.  It supports world clock, stop watch, alarms, and count down timer.")
>  (define-public gnome-calendar
>    (package
>      (name "gnome-calendar")
> -    (version "3.24.3")
> +    (version "3.26.1")

Is it OK to have a mixture of GNOME 3.24 and 3.26 applications?  (I
thought all GNOME apps/libraries had to be updated in lockstep.)

Ludo’.

[bug#28653] [PATCH] gnu: gnome-calendar: Update to 3.26.1.

[Mohammed Sadiq]

> On October 3, 2017 at 6:55 PM Ludovic Courtès <ludo@gnu.org> wrote:
> Is it OK to have a mixture of GNOME 3.24 and 3.26 applications?  (I
> thought all GNOME apps/libraries had to be updated in lockstep.)
> 

As long as the newly introduced APIs are not used, it is okay.
And the minimum required version should be specified in configure.ac
or meson.build.

So if it builds with an older library, it should also work fine.
If it doesn't work right, it is an upstream bug. The minimum required
dependency version should be updated upstream.

Thanks

> Ludo’.

[bug#28653] [PATCH] gnu: gnome-calendar: Update to 3.26.1.

[Ludovic Courtès]

Mohammed Sadiq <sadiq@sadiqpk.org> skribis:

>> On October 3, 2017 at 6:55 PM Ludovic Courtès <ludo@gnu.org> wrote:
>> Is it OK to have a mixture of GNOME 3.24 and 3.26 applications?  (I
>> thought all GNOME apps/libraries had to be updated in lockstep.)
>> 
>
> As long as the newly introduced APIs are not used, it is okay.
> And the minimum required version should be specified in configure.ac
> or meson.build.
>
> So if it builds with an older library, it should also work fine.
> If it doesn't work right, it is an upstream bug. The minimum required
> dependency version should be updated upstream.

OK, that makes sense.  Thanks for explaining!

Ludo’.