From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e461v-0005J2-1z for guix-patches@gnu.org; Mon, 16 Oct 2017 10:06:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e461r-0007ca-2c for guix-patches@gnu.org; Mon, 16 Oct 2017 10:06:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:35242) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e461q-0007cK-Ue for guix-patches@gnu.org; Mon, 16 Oct 2017 10:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e461q-0008Sp-GE for guix-patches@gnu.org; Mon, 16 Oct 2017 10:06:02 -0400 Subject: [bug#27791] [PATCH] gnu: Add passmenu Resent-Message-ID: References: <87zibw4oen.fsf@fastmail.com> <87tvyzcjmg.fsf@gnu.org> From: Jelle Licht In-reply-to: <87tvyzcjmg.fsf@gnu.org> Date: Mon, 16 Oct 2017 16:05:22 +0200 Message-ID: <87shejmbml.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27791@debbugs.gnu.org Ludovic Courtès writes: > Hi Jelle, > > Is anything holding this back? > > https://bugs.gnu.org/27791 It just fell through the cracks, thanks for reminding me :-). I still needed to address some of Marius' concerns though... > > TIA! :-) > > Ludo’. > > Marius Bakke skribis: > >> Hi Jelle, >> >> Jelle Licht writes: >> >>> Hello guix, >>> >>> Attached is a patch to include passmenu, a dmenu interface to the pass >>> password store. >>> >>> I was not quite sure how to structure this patch, as it basically installs >>> and wraps a shell script from the `password-store' sources. We could >>> instead include it as a separate output of our `password-store' package, >>> but I already had it like this in my GUIX_PACKAGE_PATH and I was not even >>> sure if that approach was in general preferable. >> >> I don't think wrapping it with dmenu in PATH is necessary. Users of this >> script are expected to have dmenu from before, and may want to use >> another implementation (e.g. rofi), another version, etc. While I agree with your general thoughts, wasn't guix supposed to prevent this ad-hoc mishmash of software? If someone wants to use another implementation (e.g. rofi), they could just create their own package that inherits from `password-store' and overrides the "dmenu" input. Case in point, I am not currently a user of dmenu (besides indirectly through the passmenu script). If people still see Marius' proposed solution as preferable, I am also okay with that. >> >> Can you try to simply add a phase to the normal password-store package >> that copies this file to out/bin? We can probably avoid the wrapper too >> by giving it the full path to `xdotool`, e.g.: >> >> (substitute "passmenu" >> (("xdotool") (string-append (assoc-ref inputs "xdotool") >> "/bin/xdotool"))) This seems nicer indeed. >> >> Adding 'xdotool' adds ~8MiB to the password-store closure size, so I >> don't think we need a separate output either. Fair enough. >> >> Thanks! Thank you for the review.