From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35520)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eILqM-0005UX-Lt
	for guix-patches@gnu.org; Fri, 24 Nov 2017 16:49:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eILqI-0000MY-BE
	for guix-patches@gnu.org; Fri, 24 Nov 2017 16:49:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:47851)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eILqI-0000M5-7F
	for guix-patches@gnu.org; Fri, 24 Nov 2017 16:49:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eILqH-0002JX-RV
	for guix-patches@gnu.org; Fri, 24 Nov 2017 16:49:01 -0500
Subject: [bug#29425] [PATCH 1/6] gnu: Add lua5.1-bitop.
Resent-Message-ID: <handler.29425.B29425.15115601258853@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87vahzei78.fsf@lassieur.org>
	<20171124165227.5743-1-clement@lassieur.org>
Date: Fri, 24 Nov 2017 22:48:38 +0100
In-Reply-To: <20171124165227.5743-1-clement@lassieur.org>
	("=?UTF-8?Q?Cl=C3=A9ment?=
	Lassieur"'s message of "Fri, 24 Nov 2017 17:52:22 +0100")
Message-ID: <87shd373gp.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: 29425@debbugs.gnu.org

Cl=C3=A9ment Lassieur <clement@lassieur.org> skribis:

> * gnu/packages/lua.scm (lua5.1-bitop): New variable.

[...]

> +(define-public lua5.1-bitop
> +  (package
> +    (inherit lua5.2-bitop)
> +    (name "lua5.1-bitop")
> +    ;; XXX: The arguments field is almost an exact copy of the field in
> +    ;; "lua5.2-bitop", except for the version string, which was derived =
from
> +    ;; "lua-5.2" and now is taken from "lua-5.1".  See this discussion f=
or
> +    ;; context:
> +    ;; http://lists.gnu.org/archive/html/guix-devel/2017-01/msg02048.html
> +    (arguments
> +     `(#:test-target "test"
> +       #:make-flags
> +       (list "INSTALL=3Dinstall -pD"
> +             (string-append "INSTALLPATH=3Dprintf "
> +                            (assoc-ref %outputs "out")
> +                            "/lib/lua/"
> +                            ,(version-major+minor (package-version lua-5=
.1))
> +                            "/bit/bit.so"))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure))))

Maybe we could write:

  (define (lua-bitop lua)
    (package
      =E2=80=A6))

  (define lua5.1-bitop (lua-bitop lua-5.1))
  (define lua5.2-bitop (lua-bitop lua-5.2))

?

If not, this patch LGTM.

Thank you,
Ludo=E2=80=99.