From: Christopher Baines <mail@cbaines.net>
To: Leo Famulari <leo@famulari.name>
Cc: 29740@debbugs.gnu.org
Subject: [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system.
Date: Sat, 16 Dec 2017 21:10:12 +0000 [thread overview]
Message-ID: <87shca5qh7.fsf@cbaines.net> (raw)
In-Reply-To: <20171216202514.GA21263@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Sat, Dec 16, 2017 at 07:20:18PM +0000, Christopher Baines wrote:
>> This improves the performance of the shared store for operations involving
>> lots of files, e.g. searching through the store.
>>
>> * gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.
>
> Okay!
>
>> diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
>> index 6102d465b..c1305d3f9 100644
>> --- a/gnu/system/vm.scm
>> +++ b/gnu/system/vm.scm
>> @@ -554,7 +554,7 @@ of the GNU system as described by OS."
>> (device (file-system->mount-tag source))
>> (type "9p")
>> (flags (if writable? '() '(read-only)))
>> - (options (string-append "trans=virtio"))
>> + (options "trans=virtio,cache=loose")
>
> Was that string-append unnecessary in this context?
I think so. It has always been like this I think, and I haven't had any
problems with this change.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2017-12-16 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 19:20 [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system Christopher Baines
2017-12-16 20:25 ` Leo Famulari
2017-12-16 21:10 ` Christopher Baines [this message]
2017-12-17 16:11 ` Ludovic Courtès
2017-12-17 20:53 ` Christopher Baines
2017-12-17 20:54 ` bug#29740: done Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shca5qh7.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=29740@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).