From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51657)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZzuJ-0005YT-Cr
	for guix-patches@gnu.org; Fri, 12 Jan 2018 09:02:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZzuE-0007S8-M9
	for guix-patches@gnu.org; Fri, 12 Jan 2018 09:02:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:45127)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eZzuE-0007Rq-JL
	for guix-patches@gnu.org; Fri, 12 Jan 2018 09:02:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZzuE-0006yA-Af
	for guix-patches@gnu.org; Fri, 12 Jan 2018 09:02:02 -0500
Subject: [bug#30084] [PATCH] gnu: Add urho3d.
Resent-Message-ID: <handler.30084.B30084.151576568726739@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87y3l5ic8f.fsf@gmail.com>
Date: Fri, 12 Jan 2018 15:01:22 +0100
In-Reply-To: <87y3l5ic8f.fsf@gmail.com> (Oleg Pykhalov's message of "Thu, 11
	Jan 2018 01:24:16 +0300")
Message-ID: <87shbbqiq5.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 30084@debbugs.gnu.org

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> From 186090075a1ae515bb4893763e7c528568e15939 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Thu, 11 Jan 2018 01:14:41 +0300
> Subject: [PATCH] gnu: Add urho3d.
>
> * gnu/packages/game-development.scm (urho3d): New public variable.

[...]

> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* (string-append "../build/Source/ThirdParty"
> +                                         "/SDL/include/generated/SDL_con=
fig.h")

IIUC there=E2=80=99s a bundled copy of SDL, right?  Can we instead build ag=
ainst
our SDL?

Ideally, to be safe from bundling, we should =E2=80=9Crm -rf ThirdParty=E2=
=80=9D in a
snippet.  Is that possible?

> +               (((string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYN=
AMIC"
> +                                " \"libpulse-simple\\.so\\.0\""))
> +                (string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNA=
MIC \""
> +                               (assoc-ref inputs "pulseaudio")
> +                               "/lib/libpulse-simple.so.0"
> +                               "\"")))

Please use a literal string in the =E2=80=98substitute*=E2=80=99 pattern (y=
ou can use
backslashes to split it on several lines.)

> +    (description "Lightweight, cross-platform 2D and 3D game engine
> +implemented in C++.  Inspired by OGRE and Horde3D.")

Full sentences please!  :-)

  https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descripti=
ons.html

Could you send an updated path?

Thank you,
Ludo=E2=80=99.