[bug#29938] [PATCH] gnu: Add sound-juicer and it's dependencies.

[bug#29938] [PATCH] gnu: Add sound-juicer and it's dependencies.

[nee]

Happy gnu year everyone,
here are the patches for a very handy software for ripping audio CDs
(assuming I'll figure out how to configure git-send-email).

I tested it on GuixSD by ripping 4 music cds and it worked well with
it's usual quirks. If you want to test it keep in mind:
1. The CD must be mounted before you start sound-juicer.
2. When you switch the disc you should restart sound-juicer, or it might
not notice.

[bug#29938] [PATCH 1/3] gnu: Add libdiscid.

[nee]

From: nee <nee.git@cock.li>

* gnu/packages/music.scm (libdiscid): New variable.
---
 gnu/packages/music.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 5b8728e59..5ab9978f7 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2017 Pierre Langlois <pierre.langlois@gmx.com>
 ;;; Copyright © 2017 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2018 nee <nee.git@hidamari.blue>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3752,3 +3753,27 @@ for the DSSI Soft Synth Interface.  A brief list of features:
 @end enumerate
 ")
     (license license:gpl2+)))
+
+(define-public libdiscid
+  (package
+    (name "libdiscid")
+    (version "0.6.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://ftp.musicbrainz.org/pub/musicbrainz/libdiscid/libdiscid-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1f9irlj3dpb5gyfdnb1m4skbjvx4d4hwiz2152f83m0d9jn47r7r"))))
+    (arguments `(#:test-target "check"))
+    (build-system cmake-build-system)
+    (home-page "https://musicbrainz.org/doc/libdiscid")
+    (synopsis "Disc id reader library")
+    (description "libdiscid is a C library for creating MusicBrainz and freedb
+disc IDs from audio CDs.  It reads a CD's table of contents (TOC) and generates
+an identifier which can be used to lookup the CD at MusicBrainz.  Additionally,
+it provides a submission URL for adding the disc ID to the database and gathers
+ISRCs and the MCN (=UPC/EAN) from disc.")
+    (license license:lgpl2.1+)))
-- 
2.15.1

[bug#29938] [PATCH 2/3] gnu: Add libmusicbrainz.

[nee]

From: nee <nee.git@cock.li>

* gnu/packages/music.scm (libmusicbrainz): New variable.
---
 gnu/packages/music.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 5ab9978f7..69641f578 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -114,6 +114,7 @@
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages tex)
   #:use-module (gnu packages tls)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages video)
   #:use-module (gnu packages web)
   #:use-module (gnu packages wxwidgets)
@@ -3777,3 +3778,35 @@ an identifier which can be used to lookup the CD at MusicBrainz.  Additionally,
 it provides a submission URL for adding the disc ID to the database and gathers
 ISRCs and the MCN (=UPC/EAN) from disc.")
     (license license:lgpl2.1+)))
+
+(define-public libmusicbrainz
+  (package
+    (name "libmusicbrainz")
+    (version "5.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/metabrainz/libmusicbrainz/releases/download/release-"
+             version "/libmusicbrainz-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0ikb9igyyk28jm34raxfzkw2qyn4nzzwsymdyprp7cmvi6g2ajb7"))     ))
+    (build-system cmake-build-system)
+    (arguments `(#:phases
+                 (modify-phases %standard-phases
+                   (replace 'check
+                     (lambda _
+                       (and
+                        ;; requires network connections
+                        ;; (zero? (system* "tests/mbtest"))
+                        (zero? (system* "tests/ctest"))))))))
+    (inputs `(("neon" ,neon)
+              ("libxml2" ,libxml2)))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (home-page "https://musicbrainz.org/doc/libmusicbrainz")
+    (synopsis "MusicBrainz client library")
+    (description "The MusicBrainz Client Library (libmusicbrainz), also known as
+mb_client, is a development library geared towards developers who wish to add
+MusicBrainz lookup capabilities to their applications.")
+    (license license:lgpl2.1+)))
-- 
2.15.1

[bug#29938] [PATCH 2/3] gnu: Add libmusicbrainz.

[Ludovic Courtès]

nee@cock.li skribis:

> From: nee <nee.git@cock.li>
>
> * gnu/packages/music.scm (libmusicbrainz): New variable.

Applied, thanks!

[bug#29938] [PATCH 3/3] gnu: Add sound-juicer.

[nee]

From: nee <nee.git@cock.li>

* gnu/packages/gnome.scm (sound-juicer): New variable.
---
 gnu/packages/gnome.scm | 43 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 42 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d17b5820f..fd8f9f8ba 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -24,7 +24,7 @@
 ;;; Copyright © 2016, 2017 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
 ;;; Copyright © 2017 Hartmut Goebel <h.goebel@crazy-compilers.com>
-;;; Copyright © 2017 nee <nee-git@hidamari.blue>
+;;; Copyright © 2017, 2018 nee <nee-git@hidamari.blue>
 ;;; Copyright © 2017 Chris Marusich <cmmarusich@gmail.com>
 ;;; Copyright © 2017 Mohammed Sadiq <sadiq@sadiqpk.org>
 ;;; Copyright © 2017 Brendan Tildesley <brendan.tildesley@openmailbox.org>
@@ -142,6 +142,7 @@
   #:use-module (gnu packages readline)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages speech)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages virtualization)
   #:use-module (gnu packages vpn)
   #:use-module (gnu packages xorg)
@@ -7076,3 +7077,43 @@ photo-booth-like software, such as Cheese.")
      "Cheese uses your webcam to take photos and videos.  Cheese can also
 apply fancy special effects and lets you share the fun with others.")
     (license license:gpl2+)))
+
+(define-public sound-juicer
+  (package
+    (name "sound-juicer")
+    (version "3.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "19qg4xv0f9rkq34lragkmhii1llxsa87llbl28i759b0ks4f6sny"))))
+    (build-system glib-or-gtk-build-system)
+    (native-inputs
+     `(("desktop-file-utils" ,desktop-file-utils)
+       ("intltool" ,intltool)
+       ("itstool" ,itstool)
+       ("pkg-config" ,pkg-config)
+       ("xmllint" ,libxml2)))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("gst-plugins-good" ,gst-plugins-good)
+       ("iso-codes" ,iso-codes)
+       ("libbrasero-media3" ,brasero)
+       ("libcanberra" ,libcanberra)
+       ("libdiscid" ,libdiscid)
+       ("libmusicbrainz" ,libmusicbrainz)
+       ("neon" ,neon)))
+    (home-page "https://wiki.gnome.org/Apps/SoundJuicer")
+    (synopsis "Audio music cd ripper")
+    (description "Sound Juicer extracts audio from compact discs and convert it
+into audio files that a personal computer or digital audio player can play.
+It supports ripping to any audio codec supported by a GStreamer plugin, such as
+mp3, Ogg Vorbis and FLAC")
+    (license license:gpl2+)))
-- 
2.15.1

[bug#29938] [PATCH 3/3] gnu: Add sound-juicer.

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 14468 bytes --]

2018-01-02 1:56 GMT+01:00 <nee@cock.li>:

> From: nee <nee.git@cock.li>
>
> * gnu/packages/gnome.scm (sound-juicer): New variable.
> ---
>  gnu/packages/gnome.scm | 43 ++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index d17b5820f..fd8f9f8ba 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -24,7 +24,7 @@
>  ;;; Copyright © 2016, 2017 Tobias Geerinckx-Rice <me@tobias.gr>
>  ;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
>  ;;; Copyright © 2017 Hartmut Goebel <h.goebel@crazy-compilers.com>
> -;;; Copyright © 2017 nee <nee-git@hidamari.blue>
> +;;; Copyright © 2017, 2018 nee <nee-git@hidamari.blue>
>  ;;; Copyright © 2017 Chris Marusich <cmmarusich@gmail.com>
>  ;;; Copyright © 2017 Mohammed Sadiq <sadiq@sadiqpk.org>
>  ;;; Copyright © 2017 Brendan Tildesley <brendan.tildesley@openmailbox.org
> >
> @@ -142,6 +142,7 @@
>    #:use-module (gnu packages readline)
>    #:use-module (gnu packages fonts)
>    #:use-module (gnu packages speech)
> +  #:use-module (gnu packages version-control)
>    #:use-module (gnu packages virtualization)
>    #:use-module (gnu packages vpn)
>    #:use-module (gnu packages xorg)
> @@ -7076,3 +7077,43 @@ photo-booth-like software, such as Cheese.")
>       "Cheese uses your webcam to take photos and videos.  Cheese can also
>  apply fancy special effects and lets you share the fun with others.")
>      (license license:gpl2+)))
> +
> +(define-public sound-juicer
> +  (package
> +    (name "sound-juicer")
> +    (version "3.24.0")
>


I built and linted libdiscid, musicbrainz and sound-juicer

They all build and lint fine, too bad my laptop has no cd drive so I can't
test run it

I also attempted

[env]$ ./pre-inst-env guix build --rounds=2 --check sound-juicer

and that seems to be ok too

@ build-started
/gnu/store/xvfdv0rs689hdkxcxnj2yi90l4d7x9bb-sound-juicer-3.24.0.drv -
x86_64-linux
/var/log/guix/drvs/xv//fdv0rs689hdkxcxnj2yi90l4d7x9bb-sound-juicer-3.24.0.drv.bz2
grafting '/gnu/store/752dyx419biwri7czf95r1kasrxf2p4k-sound-juicer-3.24.0'
-> '/gnu/store/41914r2v3qcv97dd1vn430zc0y2kjlac-sound-juicer-3.24.0'...
/gnu/store/41914r2v3qcv97dd1vn430zc0y2kjlac-sound-juicer-3.24.0


Now, guix size sound-juicer: is this good or bad ? I didn't use guix size
so often in the past so I'm not sure about this result

[env]$ ./pre-inst-env guix size sound-juicer
store item                                                       total
self
/gnu/store/c9yw98yxibbkrd0kwbbcqwkqbzgfgsvc-mesa-17.2.1            341.8
169.2  20.7%
/gnu/store/x4mzd88f16nk08jlim3rfqi3vw0g6wg5-llvm-3.9.1             144.1
75.0   9.2%

I wonder what in sound-juicer transitive closure depends on llvmm ?

/gnu/store/b4ha0azsz28g53cfc2zyww77w4a5nj9z-gtk+-3.22.21           681.7
44.4   5.4%
/gnu/store/yihvhxv3xyyvl1m2cy1lnf1lyi9h76fk-guile-2.2.2            131.2
44.2   5.4%
/gnu/store/n6nvxlk2j8ysffjh3jphn1k5silnakh6-glibc-2.25              38.5
37.1   4.5%
/gnu/store/0s5manjvfa0gmsv2r71rchky7ab70g1d-icu4c-58.2             122.7
35.0   4.3%
/gnu/store/3x53yv4v144c9xp02rs64z7j597kkqax-gcc-5.4.0-lib           68.6
30.1   3.7%
/gnu/store/7x2drw405w5rkphvg1vzhdy48fx26wx3-ghostscript-with-cups-9.21
183.2    25.3   3.1%

ghostscript with cups ? Bah

/gnu/store/fpxzlql0hq3x8l9kyjwvbpsrrsqswmdk-iso-codes-3.76          16.4
16.4   2.0%
/gnu/store/42d5rjrdkln6nwvzwdc8dyd4w6iy3n5j-coreutils-8.27          86.8
14.8   1.8%
/gnu/store/9xpjsr4zk2ny4ac54yrzjd0ysnpwyn8n-eudev-3.2.2            103.3
14.1   1.7%
/gnu/store/azbfh3i72lbaqvhgg5m7p6ymmqq0ii6q-glib-2.52.3            111.9
13.8   1.7%
/gnu/store/h15r555pry7i274zw1afhcv0c0ni2bbc-brasero-3.12.2         787.7
13.5   1.6%

The whole Brasero ? Wow

/gnu/store/j56x8kcdlyqbq9mjl5ahdvrz2qy6xwim-cups-2.2.4             287.7
12.2   1.5%

Cups ? Why ?

/gnu/store/ghmpqlplg05jjrqni48dvrs606xlmhs0-cups-minimal-2.2.4     150.7
12.1   1.5%
/gnu/store/zbywrj6klakskj0sppq56viqh9l56jl0-util-linux-2.30.1       87.7
12.1   1.5%
/gnu/store/kwzs8k97qy7avxxldnzavlii9zphh3d6-libxml2-2.9.4           81.1
10.0   1.2%
/gnu/store/knzhrdlih3y4pndp6b40j7ab3w3kgk7z-font-dejavu-2.37
9.7     9.7   1.2%
/gnu/store/b9jp579mdfnmk63112rx8lmncfh8awqy-pulseaudio-11.0
165.3     8.7   1.1%
/gnu/store/bfy1pxrcqfm2c5xvc0w0q61zf6zyj3lr-gst-plugins-base-1.12.4
229.3     8.5   1.0%
/gnu/store/n4b2farcwv1q80nrnya1i6f4a3lbl8rn-gstreamer-1.12.4
120.3     8.4   1.0%
/gnu/store/3vcaqrs4169a2607mqackjwfw9hqrmvv-poppler-0.59.0
154.9     7.0   0.9%
/gnu/store/jz1b4asy3pldfvv3pdgalcv90w79brs4-shared-mime-info-1.8
129.6     6.6   0.8%
/gnu/store/v2wn97alr58skirhpbxavb04fqm0qwqm-cdrtools-3.01
75.9     6.3   0.8%
/gnu/store/c4vl4hw5jccg0b23sfvs0kdnfdbxdlgm-cairo-1.14.10
141.5     6.0   0.7%
/gnu/store/f3rwis4xfhvmnfz77x66vb28ilbp854p-cairo-1.14.10
141.5     6.0   0.7%

Cairo 2 times with  different hashes ?

/gnu/store/m0m6bwzi8lx7kv8zbn3hjrim6flmgnf4-openssl-1.0.2l
74.6     5.9   0.7%
/gnu/store/09j7scnl3hahcmql986fsjpzj6gqsmzv-ncurses-6.0
74.3     5.7   0.7%
/gnu/store/b7y66db86k57vbb03nr4bfn9svmks4gf-bash-4.4.12
81.0     5.4   0.7%
/gnu/store/l8accdjcy2x0iwqag9vii8zf4h1ciml2-xkeyboard-config-2.21
5.4     5.4   0.7%
/gnu/store/clrddh6a60b31anv7a9hrk3i9id0k5zs-libxcb-1.12
74.4     5.1   0.6%
/gnu/store/np05q8mf1y9y4bk5y4ssj99m0dss2b1q-libx11-1.6.5
79.3     4.9   0.6%
/gnu/store/4c0dm8h5ln0zr1l93nwhhizf5p040yi6-gs-fonts-8.11
4.5     4.5   0.6%
/gnu/store/965dw3smmsvj6jyfxrkapp0gn9jh9djn-libunistring-0.9.7
73.1     4.5   0.5%
/gnu/store/jvsgj5l4lgdknari34rv29wv253n8jcl-gnutls-3.5.13
138.5     4.4   0.5%
/gnu/store/k0zn6pmqnq4865rwf82gvdv8mp2scgrg-libsoup-2.60.2
130.6     4.2   0.5%
/gnu/store/m5mpr30kyv4mm1nrzkbcwzbjskhrxsdf-gdk-pixbuf+svg-2.36.10
224.2     4.1   0.5%
/gnu/store/6srq8zd7fxlcm4ry9q2scdkvxy7l9wgg-gdk-pixbuf-2.36.10
128.3     4.1   0.5%
/gnu/store/b27qzpmvlrif5rw7i0z7n13z0k4njy62-gsettings-desktop-schemas-3.24.1
3.9     3.9   0.5%
/gnu/store/4b9y9f5fvghk2vmwpbgzncal7z3r4n5y-pango-1.40.12
201.5     3.9   0.5%
/gnu/store/13980g3067dcx7hw6m766qlhagj1vfck-libarchive-3.3.1
89.3     3.9   0.5%
/gnu/store/kdfwwd2r5ppdy8kd3yzl1sxibw3ahffq-fftwf-3.3.5
73.2     3.6   0.4%
/gnu/store/mpl9b9w60gjzsq470zka5l8p2bmy7r8v-sqlite-3.19.3
79.0     3.5   0.4%
/gnu/store/an52j0jrvd23qypbidd5f20k2wi75vh9-pcre-8.40
72.1     3.4   0.4%
/gnu/store/xr8mcc3yiaj9mypmgvr18cc1s62b7w1i-cups-filters-1.17.7
275.4     3.3   0.4%
/gnu/store/fy6ymaxvry5vn69k80xd4x8h3ax9i1if-qpdf-6.0.0
75.7     3.2   0.4%
/gnu/store/wqhsavzxaw9vipar22i0m31jwpx3wvws-libepoxy-1.4.1
344.8     3.0   0.4%
/gnu/store/iv2hwaaqii92pls2yl568nbaqh7d6sdw-gmime-2.6.23
117.0     2.9   0.4%
/gnu/store/1jp44pfmqcj3zycclvmmva3xcwinyg7l-freetype-2.8
73.6     2.8   0.3%
/gnu/store/qahszrwk4bv6sincnbhxfih1mgp158zj-libtheora-1.1.1
71.9     2.8   0.3%
/gnu/store/g1hpcah5jqd665zl3040d4nhqgzzbbhk-libvorbis-1.3.5
71.9     2.8   0.3%
/gnu/store/752dyx419biwri7czf95r1kasrxf2p4k-sound-juicer-3.24.0
818.5     2.7   0.3%
/gnu/store/scs7siybrjl5bb7sxqaskysf8n1ld718-gmp-6.1.2
71.2     2.6   0.3%
/gnu/store/5jl21csvr3jmsa4a7d08sqa2waks3f09-gmp-6.1.2
71.2     2.6   0.3%
/gnu/store/3k1y78v6nxjvmivnri5j46wai6ppvyz0-harfbuzz-1.5.1
171.4     2.5   0.3%
/gnu/store/sd1nm52b87353m41qxzwka0c0bbpk617-avahi-0.6.31
128.1     2.4   0.3%
/gnu/store/nniszqyslmgllha2cyi9g3pfsmm6sg16-atk-2.24.0
114.0     2.2   0.3%
/gnu/store/jz6k6rc0vhqfz1hpn92z8zf0rh19c2vc-alsa-lib-1.1.4.1
70.7     2.1   0.3%
/gnu/store/7841988i5qs5abnibcizx1b5vg0l0vhg-libtiff-4.0.8
73.9     2.1   0.3%
/gnu/store/nw400gfan3mxvjfwvy1q72s1ybmdscsk-fontconfig-2.12.3
80.7     2.0   0.2%
/gnu/store/3s6vjw0979hn5i4v4bqa8ybdmb0kn00l-flac-1.3.2
70.9     1.8   0.2%
/gnu/store/fjzyz9rww401m5m5517zrqnfmqpk8aa0-libsndfile-1.0.28
75.5     1.8   0.2%
/gnu/store/c6vpfgm9n7jzgr0llax0x7szqk9a5bfm-nettle-3.3
73.0     1.7   0.2%
/gnu/store/xr0zjan791j0pgvcs770m59za9bsjsr6-dbus-1.10.22
81.7     1.7   0.2%
/gnu/store/djzkjdadhl4qc6ck7aflc0rrbkf9c2gg-libcroco-0.6.12
124.7     1.7   0.2%
/gnu/store/w8kii3hjvmh50yxs52gkdywkq9jc7s19-pixman-0.34.0
70.2     1.6   0.2%
/gnu/store/x3ngr95v6x2y6d6wypl1ja64ximn7hnv-wayland-1.13.0
83.4     1.6   0.2%
/gnu/store/zhrajv6qf2hzn9c3g2bb07559hyrz5xp-bash-static-4.4.12
1.4     1.4   0.2%
/gnu/store/bw44dfc7sb38dk2j2k562bsjjsy93lvq-libgcrypt-1.7.8
71.7     1.3   0.2%
/gnu/store/mipizipnr4y2hly9b429j8id1albbgqi-readline-7.0
75.6     1.3   0.2%
/gnu/store/ryqd73alrlq5djsr18xjjihi735592im-pkg-config-0.29.2
69.9     1.3   0.2%
/gnu/store/zcmlf4nw54kh1912b9a04a7p0xn6xgyg-totem-pl-parser-3.10.8
146.5     1.3   0.2%
/gnu/store/jpg8ddw8ny40ja5agb90kn5nnncjbrrs-lcms-2.8
76.0     1.3   0.2%
/gnu/store/g3prm4h73vpvpywxixsksbzkzj9h0ia9-orc-0.4.28
69.9     1.3   0.2%
/gnu/store/2aa9nxjpwclshar0a4p0xprrxfi3q800-gpgme-1.9.0
71.7     1.2   0.2%
/gnu/store/9blidf28xz0a0glnv6a4xcw6nxadg427-libgc-7.6.0
70.4     1.2   0.1%
/gnu/store/g3nari57wcfnm00kv9bnpyzdzfq4h8pk-xz-5.2.2
70.7     1.1   0.1%
/gnu/store/d5xlg7jmkf5jqgnlxiihlnmj61xvshpy-at-spi2-core-2.24.1
127.2     1.1   0.1%
/gnu/store/8k6f3wjk1f3qcigrrvhwmhy0026j0y06-opus-1.2.1
69.7     1.1   0.1%
/gnu/store/f77rr2g8xyzyglzqbjbq4g5ql6jid38y-libxkbcommon-0.7.1
85.8     1.0   0.1%
/gnu/store/vdibsrn3w4pvn0yav5z8aa1hw6hadid2-librsvg-2.40.18
220.1     1.0   0.1%
/gnu/store/kpxi8h3669afr9r1bgvaf9ij3y4wdyyn-bash-minimal-4.4.12
39.5     1.0   0.1%
/gnu/store/sx9pbcmwa04nipwcwnfsyni79dl8nwfd-neon-0.30.2
88.0     0.9   0.1%
/gnu/store/hnk54xvxn07m01zjiyfcyhjncyqd22xp-libmusicbrainz-5.1.0
88.9     0.9   0.1%
/gnu/store/0cbapw0nxlybp0jbv3fi1krj95p95qsd-libdrm-2.4.83
72.8     0.9   0.1%
/gnu/store/b9ww6qv1ii9v6n45kin7543vkf6jfnd3-libpng-1.6.29
70.8     0.8   0.1%
/gnu/store/pd3nggfvrq50nh419an2ahay69mzrvck-libjpeg-9b
69.4     0.8   0.1%
/gnu/store/rp8lfy4yfj08dk41m4ia9b80yy93mzf6-libjpeg-8d
69.4     0.8   0.1%
/gnu/store/7v2w3506q0gf96rsf6wf3gdr2iv5frmm-libgpg-error-1.27
70.3     0.7   0.1%
/gnu/store/b8yzs5x0cnypb9vygcsxw5aiih9k3kmd-libxi-1.7.9
80.4     0.6   0.1%
/gnu/store/0f76ak4jn36qs7syhfaw5ag9958yabzh-libatomic-ops-7.4.4
0.6     0.6   0.1%
/gnu/store/wdlhrg370gm42s7ggyhnvnb4xrzpls1x-expat-2.2.1
69.2     0.6   0.1%
/gnu/store/47jgabf5wx296alb06pb5iig6cqbmx0v-gdbm-1.13
69.2     0.6   0.1%
/gnu/store/wzqbcf3by84gizns701c8byka2l54a3k-s2tc-1.0
69.2     0.6   0.1%
/gnu/store/vais0pchk05ihl7kqj7rq8zf8p4cjdha-libice-1.0.9
69.6     0.5   0.1%
/gnu/store/y6dfyda1wj41479wzqy7n32px4skrpmd-libcanberra-0.30
726.8     0.5   0.1%
/gnu/store/ljzqi3ajkc6l5r8hwdz7kr1zwbli3i7y-pciutils-3.5.5
71.8     0.5   0.1%
/gnu/store/kdwlvs51isdfbl61jdishzhly8h139zf-libbsd-0.8.3
69.1     0.5   0.1%
/gnu/store/c2k4gqjhnjyqyisci1sy81416i03pk22-libidn2-2.0.2
73.6     0.5   0.1%
/gnu/store/5rhk61dq276h7cdyn6ks112iahn4f8m8-libogg-1.3.2
69.1     0.5   0.1%
/gnu/store/jm3jsam5hk472mq1b9hcag1ladiarr8z-sound-theme-freedesktop-0.8
0.5     0.5   0.1%
/gnu/store/j38il4np3l29z14ilg2h352c89qsgl9y-openjpeg-1.5.2
77.2     0.5   0.1%
/gnu/store/jz7wvy930liqjvm95lhdv9i1dr1xxvxp-libxext-1.3.3
79.8     0.4   0.1%
/gnu/store/5lrk6d5cjsv2s29vfji6j59gyf18rb5m-acl-2.2.52
69.3     0.4   0.1%
/gnu/store/sfx1wh27i6gsrk21p87rdyikc64v7d51-zlib-1.2.11
69.0     0.4   0.0%
/gnu/store/mxsbvhljh0fk82hdsgy04p3l2d5hz4j4-libtasn1-4.12
69.0     0.3   0.0%
/gnu/store/jcsysx67d8y66n66hi856nfm2f92ws91-sbc-1.3
69.0     0.3   0.0%
/gnu/store/3ki105d90l97z7dd3gmvbr83407lqvyh-cdparanoia-10.2
69.0     0.3   0.0%
/gnu/store/l7306lcxgapca9348qk6hakgycwkrmfs-libelf-0.8.13
68.9     0.3   0.0%
/gnu/store/20jm67srhdzi01d2gdg36cspyip21lsd-libsm-1.2.2
89.0     0.3   0.0%
/gnu/store/p5hrrimz30kfp56rah7qn4ymshyg78mq-graphite2-1.3.10
68.9     0.3   0.0%
/gnu/store/insr5wrif9pn1mlqa5rl9k3sr5qf2q1y-kmod-24
71.3     0.3   0.0%
/gnu/store/4dc900sd73wyv40pvpa5pf8kx1a6b2c5-jbig2dec-0.13
68.9     0.3   0.0%
/gnu/store/a5qmn584x8w2c7cpq730cmlpspkcmv8x-dvd+rw-tools-7.1
76.1     0.3   0.0%
/gnu/store/cy29qj39bg2zk54hikybrllkk0zz2dz0-libnotify-0.7.7
128.5     0.3   0.0%
/gnu/store/593cj4b7nsa0csjfjnh0xx8y4rdpykxh-libxft-2.3.2
91.8     0.3   0.0%
/gnu/store/yz1lf55ag0904w9ib0q2kcjpdx33y7wm-attr-2.4.47
68.9     0.2   0.0%
/gnu/store/0z19av4dvsabbavibgpv7w0myxinivvm-at-spi2-atk-2.24.1
129.6     0.2   0.0%
/gnu/store/bs8nkjwy2sy6zdwppjlbbly6w9wgjdh0-libassuan-2.5.1
70.5     0.2   0.0%
/gnu/store/1xc97akbdcisrid2n8djpkn09f8bkl5f-libxdmcp-1.1.2
69.3     0.2   0.0%
/gnu/store/jnbb8ffxxvrw2b4z18zn0g08kqk9rsgl-libffi-3.2.1
68.8     0.1   0.0%
/gnu/store/ysxprjqrxbhh6k3lri0shlyfbyay6fr3-libxtst-1.2.3
80.5     0.1   0.0%
/gnu/store/kgy00x8jl7q965sngq1yyihbczxj15wk-libxrender-0.9.10
79.5     0.1   0.0%
/gnu/store/hxn2viwl04nwswpjkfg0iyyhm815yaza-libcap-2.25
68.8     0.1   0.0%
/gnu/store/yzlmd2nlcyjhx0ydbap7x32zjqxc3hz9-libcap-2.25
68.8     0.1   0.0%
/gnu/store/14f4vh3y3wdf3rfpzkpqfqbl9i81hyw8-libxcursor-1.1.14
79.7     0.1   0.0%
/gnu/store/pf1xr3i3pf7k1b3lr59gffzy891y1yv3-libxvmc-1.0.10
80.0     0.1   0.0%
/gnu/store/qh1fri7qppqi8bhyzbiw7h8knmk4cb3q-libltdl-2.4.6
68.8     0.1   0.0%
/gnu/store/0p4gxh2xiz31v2zx8mg43nv2djjyfwmn-libpciaccess-0.13.5
71.9     0.1   0.0%
/gnu/store/3sbjin1s657q32pw8vblr3cmzqb5b13a-hicolor-icon-theme-0.17
0.1     0.1   0.0%
/gnu/store/dgyan2zawxw7qnxrmf9yp3ll954c9sxm-libdaemon-0.14
68.7     0.1   0.0%
/gnu/store/s2g2446j1wl1zy4d23vs3a7dc3zzl2c2-libxv-1.0.11
79.8     0.1   0.0%
/gnu/store/4wm6z6dh5gkqbvxj7995lvr2bjwhqq25-libxxf86vm-1.1.4
79.8     0.1   0.0%
/gnu/store/85n2gzncy1dl6cbnky79nih4qhcwibds-libxfixes-5.0.3
79.4     0.1   0.0%
/gnu/store/ia2rwi4zdl2nhhwfmj1gaap1xz70mmxs-libpaper-1.1.24
69.7     0.1   0.0%
/gnu/store/bqgblj6gzkpi6jhyz63i02nqn2vjri3h-libdiscid-0.6.2
68.7     0.0   0.0%
/gnu/store/xv8bp0zxbr9iphr38wy0ll4lzkbh9i87-libxau-1.0.8
68.7     0.0   0.0%
/gnu/store/v3rw36lf3m9ncg6sihghchnbivix2gvi-libxinerama-1.1.3
79.8     0.0   0.0%
/gnu/store/5s19lin8dm65aygm85s8cwqsq41hym6d-libxdamage-1.1.4
79.4     0.0   0.0%
/gnu/store/27hw80d0nn2a5p56vk91qn6jvn036dla-libxshmfence-1.2
68.7     0.0   0.0%
total: 818.5 MiB

is this acceptable ? I don't know

I'd say LGTM unless someone else has anything to say

I hope at least that this saves someone else some work

[-- Attachment #2: Type: text/html, Size: 19048 bytes --]

[bug#29938] [PATCH 3/3] gnu: Add sound-juicer.

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

2018-01-02 17:35 GMT+01:00 Catonano <catonano@gmail.com>:

>
>

> is this acceptable ? I don't know
>
> I'd say LGTM unless someone else has anything to say
>
> I hope at least that this saves someone else some work
>

nee, it's not that I'm dubious about your work
In fact I find it pretty good
It's just that I'm somewhat new at this

Thank you !

[-- Attachment #2: Type: text/html, Size: 1084 bytes --]

[bug#29938] [PATCH 3/3] gnu: Add sound-juicer.

[nee]

Am 02.01.2018 um 17:35 schrieb Catonano:
> Now, guix size sound-juicer: is this good or bad ? I didn't use guix
> size so often in the past so I'm not sure about this result
> 
> [env]$ ./pre-inst-env guix size sound-juicer
> ...
I generally feel like a lot of packages pull too many
dependencies right now and that this should be improved.

> I wonder what in sound-juicer transitive closure depends on llvmm ?

It is required for mesa which is required by gtk+

> Cairo 2 times with  different hashes ?

Also appears in gtk+, but I haven't checked where exactly it comes from.

> ghostscript with cups ? Bah
> 
That probably comes from some kind of doc builder for something gtk
related AFAIK.

> /gnu/store/h15r555pry7i274zw1afhcv0c0ni2bbc-brasero-3.12.2        
> 787.7    13.5   1.6%
> 
> The whole Brasero ? Wow
> 

It needs to link the libbrasero libraries.
I shortly tried to split brasero libraries into a separate outputs
today, but I failed because one of the libraries references the icon
directory and I'm also not sure if it's worth bothering with too much.

> total: 818.5 MiB
> 
> is this acceptable ? I don't know
`guix size gtk+` takes 680 MiB and gtk+ is responsible for most of the
"WTF" dependencies. I wonder if it could be split up like qt.
I used guix graph and a little time scrolling on a gigantic image to
figure out that out.
The rest probably comes from gstreamer and seems acceptable to me.

I would say this patch is okay, unless you know something that can be
done directly on the sound-juicer package.

[bug#29938] [PATCH 3/3] gnu: Add sound-juicer.

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 2018 bytes --]

2018-01-04 4:30 GMT+01:00 nee <nee@cock.li>:

> Am 02.01.2018 um 17:35 schrieb Catonano:
> > Now, guix size sound-juicer: is this good or bad ? I didn't use guix
> > size so often in the past so I'm not sure about this result
> >
> > [env]$ ./pre-inst-env guix size sound-juicer
> > ...
> I generally feel like a lot of packages pull too many
> dependencies right now and that this should be improved.
>
> > I wonder what in sound-juicer transitive closure depends on llvmm ?
>
> It is required for mesa which is required by gtk+
>

Ah ok


> > Cairo 2 times with  different hashes ?
>
> Also appears in gtk+, but I haven't checked where exactly it comes from.
>

Interesting



> > ghostscript with cups ? Bah
> >
> That probably comes from some kind of doc builder for something gtk
> related AFAIK.
>

Ok


>
> > /gnu/store/h15r555pry7i274zw1afhcv0c0ni2bbc-brasero-3.12.2
> > 787.7    13.5   1.6%
> >
> > The whole Brasero ? Wow
> >
>
> It needs to link the libbrasero libraries.
> I shortly tried to split brasero libraries into a separate outputs
> today, but I failed because one of the libraries references the icon
> directory and I'm also not sure if it's worth bothering with too much.
>

I agree



> > total: 818.5 MiB
> >
> > is this acceptable ? I don't know
> `guix size gtk+` takes 680 MiB and gtk+ is responsible for most of the
> "WTF" dependencies. I wonder if it could be split up like qt.
> I used guix graph and a little time scrolling on a gigantic image to
> figure out that out.
>

When I have played with the nodejs graph, it was too big for Graphviz t
oprocess it and visualizing it was a challenge
We probably need something better to visualize graphs and spot patterns


> The rest probably comes from gstreamer and seems acceptable to me.
>
> I would say this patch is okay, unless you know something that can be
> done directly on the sound-juicer package.
>

No, this patch is ok for me too
As I said, I' m just new at this

As far as I am concerned, LGTM

Thanks for your work !

Ciao

[-- Attachment #2: Type: text/html, Size: 3846 bytes --]

bug#29938: [PATCH 3/3] gnu: Add sound-juicer.

[Ludovic Courtès]

nee@cock.li skribis:

> From: nee <nee.git@cock.li>
>
> * gnu/packages/gnome.scm (sound-juicer): New variable.

Applied, thanks.

When I run it (not under GNOME), I get a dialog box saying:

  The currently selected audio profile is not available on your
  installation.

If I click on “Change Profile”, the dialog box pops up again.

Did you manage to get it running?

Also, do you think we should add it to the ‘gnome’ meta-package?

Thank you,
Ludo’.

[bug#29938] [PATCH 3/3] gnu: Add sound-juicer.

[nee]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

Am 11.01.2018 um 10:35 schrieb Ludovic Courtès:
> When I run it (not under GNOME), I get a dialog box saying:
> 
>   The currently selected audio profile is not available on your
>   installation.
> 
> If I click on “Change Profile”, the dialog box pops up again.
> > Did you manage to get it running?
> 

I tested it on GNOME3 and XFCE now and couldn't reproduce that problem.
I didn't test removing the gnome-desktop-service though, maybe it
depends on that.
I tried: - changing the audio-format settings
	 - playing back a disk
	 - copying a disk with custom data entered
For my first patch I also tested that and had no problems with the
software or the flac/ogg files it created.

> Also, do you think we should add it to the ‘gnome’ meta-package?
> 

Since there are more laptops without CD drives and CDs in general are
declining I wouldn't add it as default. I think other distros also don't
have it in their default gnome.

> Thank you,
> Ludo’.
> 


[-- Attachment #2: 2018-01-12-151703_1920x1080_scrot.png --]
[-- Type: image/png, Size: 138693 bytes --]

[-- Attachment #3: Bildschirmfoto von »2018-01-12 15-22-23«.png --]
[-- Type: image/png, Size: 82991 bytes --]

[bug#29938] [PATCH 3/3] gnu: Add sound-juicer.

[Ludovic Courtès]

nee <nee@cock.li> skribis:

> Am 11.01.2018 um 10:35 schrieb Ludovic Courtès:
>> When I run it (not under GNOME), I get a dialog box saying:
>> 
>>   The currently selected audio profile is not available on your
>>   installation.
>> 
>> If I click on “Change Profile”, the dialog box pops up again.
>> > Did you manage to get it running?
>> 
>
> I tested it on GNOME3 and XFCE now and couldn't reproduce that problem.
> I didn't test removing the gnome-desktop-service though, maybe it
> depends on that.
> I tried: - changing the audio-format settings
> 	 - playing back a disk
> 	 - copying a disk with custom data entered
> For my first patch I also tested that and had no problems with the
> software or the flac/ogg files it created.

OK, it’s probably just that it relies on one of the GNOME or Freedesktop
services that’s lacking on my system.

>> Also, do you think we should add it to the ‘gnome’ meta-package?
>> 
>
> Since there are more laptops without CD drives and CDs in general are
> declining I wouldn't add it as default. I think other distros also don't
> have it in their default gnome.

Makes sense.

Thank you!

Ludo’.

[bug#29938] [PATCH 1/3] gnu: Add libdiscid.

[Ludovic Courtès]

nee@cock.li skribis:

> From: nee <nee.git@cock.li>
>
> * gnu/packages/music.scm (libdiscid): New variable.

Applied, thanks!