unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: "Clément Lassieur" <clement@lassieur.org>
Cc: 30744@debbugs.gnu.org
Subject: [bug#30744] [PATCH] tests: mail: Add test for dovecot.
Date: Fri, 09 Mar 2018 12:31:38 +0300	[thread overview]
Message-ID: <87sh99lhmt.fsf@gmail.com> (raw)
In-Reply-To: <87tvtqaoqg.fsf@lassieur.org> ("Clément Lassieur"'s message of "Thu, 08 Mar 2018 10:41:27 +0100")

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

Hello Clément,

Clément Lassieur <clement@lassieur.org> writes:

> Oleg Pykhalov <go.wigust@gmail.com> writes:

[…]

>> +          ;; Give the service time to start talking.
>> +          (wait-for-file "/var/run/dovecot/master.pid" marionette)
>
> Could you put it in a test context (test-assert with file-exists? for
> example, see tests/messaging.scm)?

OK.

I replaced ‘(wait-for-file …)’ and a comment with:
--8<---------------cut here---------------start------------->8---
;; Check Dovecot service's PID.
(test-assert "service process id"
  (let ((pid
         (number->string (wait-for-file "/var/run/dovecot/master.pid"
                                        marionette))))
    (marionette-eval `(file-exists? (string-append "/proc/" ,pid))
                     marionette)))
--8<---------------cut here---------------end--------------->8---

[…]

>> +                  (match (scandir TESTBOX/new)
>> +                    ((cwd .. message-file)
>
> You need to use double quotes, like ("." ".." message-file) I believe.

It works.  Thank you!

[…]

I think it's ready for a push to ‘origin/master’.  WDYT?

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2018-03-09  9:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 21:30 [bug#30744] [PATCH 1/2] services: dovecot: Copy dovecot.conf to /etc/dovecot Oleg Pykhalov
2018-03-07 21:32 ` [bug#30744] [PATCH] tests: mail: Add test for dovecot Oleg Pykhalov
2018-03-07 23:34   ` Clément Lassieur
2018-03-08  8:24     ` Oleg Pykhalov
2018-03-08  8:28       ` Oleg Pykhalov
2018-03-08  9:41         ` Clément Lassieur
2018-03-09  9:31           ` Oleg Pykhalov [this message]
2018-03-09 10:16             ` Clément Lassieur
2018-03-09 14:30               ` Oleg Pykhalov
2018-03-07 23:34 ` [bug#30744] [PATCH 1/2] services: dovecot: Copy dovecot.conf to /etc/dovecot Clément Lassieur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh99lhmt.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=30744@debbugs.gnu.org \
    --cc=clement@lassieur.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).