From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fATAz-0007uj-L5 for guix-patches@gnu.org; Mon, 23 Apr 2018 00:34:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fATAw-00015m-O5 for guix-patches@gnu.org; Mon, 23 Apr 2018 00:34:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56693) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fATAw-00015f-LL for guix-patches@gnu.org; Mon, 23 Apr 2018 00:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fATAw-0001E5-Fp for guix-patches@gnu.org; Mon, 23 Apr 2018 00:34:02 -0400 Subject: [bug#31178] [PATCH] gnu: Add inxi. Resent-Message-ID: References: <20180416123830.28716-1-ambrevar@gmail.com> <87r2n6gbpg.fsf@gnu.org> From: Pierre Neidhardt In-reply-to: <87r2n6gbpg.fsf@gnu.org> Date: Mon, 23 Apr 2018 10:03:23 +0530 Message-ID: <87sh7mr17w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31178@debbugs.gnu.org, 31176@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I didn't know Oleg was going to submit a patch, maybe there was some confusion in the process :p I've quickly reviewed our two patches. Overall I'd opt for mine :p =2D It's the latest version. =2D It has more inputs. I think we should use propagated-inputs and not native-inputs. What do you think? I'd opt for Oleg's description however! One thing I forgot is to add a comment about why I've used (with-fluids ((%default-port-encoding #f)) It's because the `inxi` file contains some weird character. It was mentioned before on the mailing list. =2D-=20 Pierre Neidhardt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlrdYhMACgkQm9z0l6S7 zH/kLgf+MBwv5a1DtkFf9qZLr1OUdFIju+NXe5IkluOvdm/E0tMwiFYoddfunQ7N 2PR5LWOnUywzkz0RSbafcyX1eLGT11fZ/A6z+BlpysfhtisErGcoDQgGoDJ59lPZ BcezH3uZkUxQvEVmxNovkvDjobKdXiVECPFdVGxsIwRkYJmxXzvlyesBB93ouL4d JWNCJsu3vUOTR/GfatgKeRIlvSzU9q1S6O1VLzgh5cAuPOpRdcVa0PHr1PohjwmY aqJFgnOfP/kjdWoxeU89IeJB9/eIPGTdJYJ84mPh37V6LSQfCmr7yid1iQOEX5Mv oN8ejjyT4mFkqQ18nklL2VP0r6n9jQ== =Wtmn -----END PGP SIGNATURE----- --=-=-=--